[flang][NFC] remove spurious dependency from IntrinsicCall 2/6

[clementval]

What is the ultimate goal of this? This code seems more related to lowering than optimization. Lowering will have a dependency in the other sense right?

[tblah]

In D143080#4096946, @clementval wrote:

What is the ultimate goal of this? This code seems more related to lowering than optimization. Lowering will have a dependency in the other sense right?

This is to allow implementation of HLFIR transformational intrinsic operations such as hlfir.sum. There will be a pass which rewrites hlfir.sum into the fir.call (and argument handling). lib/Lower already depends upon lib/Optimizer, so it would be best not to add a dependency from lib/Optimizer to lib/Lower (by leaving IntrinsicCall in lib/Lower and calling these functions from lib/Optimizer/HLFIR/Transforms/).

[clementval]

In D143080#4097010, @tblah wrote:

This is to allow implementation of HLFIR transformational intrinsic operations such as hlfir.sum. There will be a pass which rewrites hlfir.sum into the fir.call (and argument handling). lib/Lower already depends upon lib/Optimizer, so it would be best not to add a dependency from lib/Optimizer to lib/Lower (by leaving IntrinsicCall in lib/Lower and calling these functions from lib/Optimizer/HLFIR/Transforms/).

Ok thanks for the explanation

[jeanPerier]

LGTM

flang/lib/Lower/IntrinsicCall.cpp

 //
 //===----------------------------------------------------------------------===//
 
 #include "flang/Lower/IntrinsicCall.h"
 #include "flang/Common/static-multimap-view.h"
 #include "flang/Lower/Mangler.h"
 #include "flang/Lower/Runtime.h"
 #include "flang/Lower/Support/Utils.h"
-#include "flang/Lower/SymbolMap.h"
 #include "flang/Optimizer/Builder/BoxValue.h"
 #include "flang/Optimizer/Builder/Character.h"
 #include "flang/Optimizer/Builder/Complex.h"
 #include "flang/Optimizer/Builder/FIRBuilder.h"
 #include "flang/Optimizer/Builder/MutableBox.h"
 #include "flang/Optimizer/Builder/Runtime/Allocatable.h"
 #include "flang/Optimizer/Builder/Runtime/Character.h"
 #include "flang/Optimizer/Builder/Runtime/Command.h"