Page MenuHomePhabricator

[flang][NFC] Move runtime helpers used by intrinsics to lib/Optimizer 3/6

Authored by tblah on Feb 1 2023, 8:17 AM.



This will allow IntrinsicCall to be moved into lib/Optimizer later.

Diff Detail

Event Timeline

tblah created this revision.Feb 1 2023, 8:17 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
tblah requested review of this revision.Feb 1 2023, 8:17 AM
jeanPerier accepted this revision.Feb 2 2023, 1:19 AM

Please move the header in Builer/Runtime so that that all the runtime call generation tools sit in the same folder. Look good otherwise, thanks!

21 ↗(On Diff #493960)

It would make more sense to me to move this in "include/flang/Optimizer/Builder/Runtime/Intrinsics.h" and to have the function defined by this header be in the fir::runtime namespace.

This revision is now accepted and ready to land.Feb 2 2023, 1:19 AM
tblah updated this revision to Diff 494316.Feb 2 2023, 8:08 AM


  • Move new header to flang/include/flang/Optimizer/Builder/Runtime/Intrinsics.h
  • Move fucntions to fir::runtime namespace