This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add support for f8 data types to LLVM dialect types

Authored by ezhulenev on Jan 31 2023, 12:16 PM.



This change allows using fp8 pointers when exporting to LLVM, because we anyway export them as opaque pointers, however full support of fp8 types is not yet implemented on the LLVM side.

Diff Detail

Event Timeline

ezhulenev created this revision.Jan 31 2023, 12:16 PM
Herald added a project: Restricted Project. · View Herald Transcript
ezhulenev requested review of this revision.Jan 31 2023, 12:16 PM

Do not add f8 to supported floating point types

ezhulenev edited the summary of this revision. (Show Details)Jan 31 2023, 12:29 PM
ezhulenev edited reviewers, added: reedwm; removed: mpaszkowski.Jan 31 2023, 12:30 PM
ftynse added a comment.Feb 1 2023, 2:40 AM

Could you add a test?

ezhulenev updated this revision to Diff 494064.Feb 1 2023, 1:49 PM

Add a test for lowering f8 pointers to LLVM IR

ezhulenev updated this revision to Diff 498360.Feb 17 2023, 7:14 AM

Remove accidental change

This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2023, 6:52 PM
This revision was automatically updated to reflect the committed changes.