Page MenuHomePhabricator

reedwm (Reed Wanderman-Milne)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 9 2022, 11:09 AM (18 w, 6 d)

Recent Activity

Feb 9 2023

reedwm accepted D141863: [llvm][APFloat] Add NaN-in-negative-zero formats by AMD and GraphCore.
Feb 9 2023, 10:59 AM · Restricted Project, Restricted Project

Feb 8 2023

reedwm added inline comments to D141863: [llvm][APFloat] Add NaN-in-negative-zero formats by AMD and GraphCore.
Feb 8 2023, 10:05 PM · Restricted Project, Restricted Project

Feb 2 2023

reedwm added a comment to D141863: [llvm][APFloat] Add NaN-in-negative-zero formats by AMD and GraphCore.

Just some more minor nits about comments.

Feb 2 2023, 4:37 PM · Restricted Project, Restricted Project

Feb 1 2023

reedwm added a comment to D141863: [llvm][APFloat] Add NaN-in-negative-zero formats by AMD and GraphCore.

Looks good, just have some minor comments.

Feb 1 2023, 9:12 PM · Restricted Project, Restricted Project

Dec 1 2022

reedwm added a comment to D138540: Fix APFloat::toString on Float8E5M2 values..

Thanks for reviewing! Since I don't have commit access, can you commit this?

Dec 1 2022, 10:23 AM · Restricted Project, Restricted Project

Nov 22 2022

reedwm requested review of D138540: Fix APFloat::toString on Float8E5M2 values..
Nov 22 2022, 8:18 PM · Restricted Project, Restricted Project
reedwm accepted D138516: [mlir] Add tablegen types for fp8 types.
Nov 22 2022, 11:12 AM · Restricted Project, Restricted Project

Nov 15 2022

reedwm requested review of D138075: Add Float8E4M3FN type to MLIR..
Nov 15 2022, 4:05 PM · Restricted Project, Restricted Project
reedwm added a comment to D137760: Add FP8 E4M3 support to APFloat..

Thanks for this. Patch lgtm. Has a couple of format issues but probably ok as-is (this file is very inconsistently formatted and it looks like you overrode clang-format a bit for consistency with adjacent code).

Nov 15 2022, 11:31 AM · Restricted Project, Restricted Project, Restricted Project

Nov 9 2022

reedwm requested review of D137760: Add FP8 E4M3 support to APFloat..
Nov 9 2022, 8:28 PM · Restricted Project, Restricted Project, Restricted Project