Page MenuHomePhabricator

mpaszkowski (Michal Paszkowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2019, 4:37 PM (10 w, 2 d)

Recent Activity

Sun, Sep 29

mpaszkowski updated the diff for D66029: llvm-canon.

Updated the diff for the new revision, refactored naming functions, accepted suggestions by lebedev.
Thank you for the review! @lebedev.ri
Is the code ready for the mainline?

Sun, Sep 29, 5:43 AM · Restricted Project
mpaszkowski added inline comments to D66029: llvm-canon.
Sun, Sep 29, 5:38 AM · Restricted Project

Aug 28 2019

mpaszkowski added a comment to D66029: llvm-canon.

Gentle ping ;)

Aug 28 2019, 6:30 AM · Restricted Project

Aug 21 2019

mpaszkowski added a comment to D66029: llvm-canon.

Now the canonicalizer sorts values in PHI nodes. After a discussion, I have decided not to remove duplicates. Those duplicates could come from some other passes and in my opinion, the canonicalizer should make them stand out instead of removing them.

I suppose that you mean that, if passes are introducing duplicates, that's something that we'd rather fix? That might be true. I'm okay with proceeding on this basis. If we need the deduplicating behavior we'll find out.

Aug 21 2019, 11:16 PM · Restricted Project

Aug 19 2019

mpaszkowski added a comment to D66029: llvm-canon.

We have been experimenting with various ways of reordering output instructions hoping to add it now, but it looks to be much tougher than we thought. We hope to add it in a next commit.

Aug 19 2019, 4:18 PM · Restricted Project
mpaszkowski updated the diff for D66029: llvm-canon.
  • PHI node canonicalization
  • Tests
  • Release notes
  • Docs
Aug 19 2019, 3:57 PM · Restricted Project

Aug 18 2019

mpaszkowski added inline comments to D66029: llvm-canon.
Aug 18 2019, 12:48 PM · Restricted Project
mpaszkowski updated the diff for D66029: llvm-canon.

I would like to thank everyone for your valuable feedback! I have fixed the code and moved the pass to lib/Tranfroms/Utils. I hope I have correctly integrated the pass with the rest of the LLVM (we should have some checklist for that).

Aug 18 2019, 12:40 PM · Restricted Project

Aug 13 2019

mpaszkowski added a comment to D66029: llvm-canon.

First of all, thank you for your valuable feedback!

Aug 13 2019, 4:57 AM · Restricted Project

Aug 9 2019

mpaszkowski created D66029: llvm-canon.
Aug 9 2019, 1:33 PM · Restricted Project