Page MenuHomePhabricator

mpaszkowski (Michal Paszkowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2019, 4:37 PM (181 w, 5 d)

Recent Activity

Thu, Jan 19

mpaszkowski committed rG2bcedd464348: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata (authored by mpaszkowski).
[SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata
Thu, Jan 19, 6:27 AM · Restricted Project, Restricted Project
mpaszkowski closed D141734: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata.
Thu, Jan 19, 6:27 AM · Restricted Project, Restricted Project
mpaszkowski committed rG786cb151d938: [SPIR-V] Add -opaque-pointers=0 to some LIT tests (authored by mpaszkowski).
[SPIR-V] Add -opaque-pointers=0 to some LIT tests
Thu, Jan 19, 5:03 AM · Restricted Project, Restricted Project
mpaszkowski closed D142061: [SPIR-V] Add -opaque-pointers=0 to some LIT tests.
Thu, Jan 19, 5:02 AM · Restricted Project, Restricted Project

Wed, Jan 18

mpaszkowski added a comment to D141734: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata.

Full runtime testing results are now available: https://spirv-testing.khronos.org/job/82/. I will commit this patch after D142061.

Wed, Jan 18, 3:45 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D142061: [SPIR-V] Add -opaque-pointers=0 to some LIT tests.

@nikic I have created the issue for tracking the SPIR-V backend LIT tests with -opaque-pointers=0 here: https://github.com/llvm/llvm-project/issues/60133

Wed, Jan 18, 3:20 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D142061: [SPIR-V] Add -opaque-pointers=0 to some LIT tests.
Wed, Jan 18, 3:15 PM · Restricted Project, Restricted Project

Tue, Jan 17

mpaszkowski added a comment to D141337: [SPIR-V] Fix translation of aggregate undef operands.

Gentle ping!

Tue, Jan 17, 4:20 AM · Restricted Project, Restricted Project

Fri, Jan 13

mpaszkowski requested review of D141734: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata.
Fri, Jan 13, 3:32 PM · Restricted Project, Restricted Project
mpaszkowski committed rGe461bdf65b66: [SPIR-V] Fix switch lowering with common compare register (authored by mpaszkowski).
[SPIR-V] Fix switch lowering with common compare register
Fri, Jan 13, 2:00 PM · Restricted Project, Restricted Project
mpaszkowski closed D141203: [SPIR-V] Fix switch lowering with common compare register.
Fri, Jan 13, 1:59 PM · Restricted Project, Restricted Project

Mon, Jan 9

mpaszkowski requested review of D141337: [SPIR-V] Fix translation of aggregate undef operands.
Mon, Jan 9, 5:24 PM · Restricted Project, Restricted Project

Sat, Jan 7

mpaszkowski requested review of D141203: [SPIR-V] Fix switch lowering with common compare register.
Sat, Jan 7, 11:11 AM · Restricted Project, Restricted Project
mpaszkowski committed rG99203241df4d: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis (authored by mpaszkowski).
[SPIR-V] Map IR function pointers to registers in ModuleAnalysis
Sat, Jan 7, 6:40 AM · Restricted Project, Restricted Project
mpaszkowski closed D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.
Sat, Jan 7, 6:40 AM · Restricted Project, Restricted Project

Fri, Jan 6

mpaszkowski added a comment to D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.

@arsenm Thanks! I uploaded a new updated patch.

Fri, Jan 6, 7:27 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.
Fri, Jan 6, 7:26 AM · Restricted Project, Restricted Project

Dec 22 2022

mpaszkowski accepted D140490: [SPIRV] support __spirv_Load/Store builtin functions.

Thank you for the patch @iliya-diyachkov! The runtime testing results are now available. LGTM!

Dec 22 2022, 6:10 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.
Dec 22 2022, 6:05 AM · Restricted Project, Restricted Project

Dec 21 2022

mpaszkowski committed rG870808989676: [SPIR-V] Add atomic_flag builtin implementation (authored by mpaszkowski).
[SPIR-V] Add atomic_flag builtin implementation
Dec 21 2022, 2:01 PM · Restricted Project, Restricted Project
mpaszkowski closed D136310: [SPIR-V] Add atomic_flag builtin implementation.
Dec 21 2022, 2:00 PM · Restricted Project, Restricted Project

Dec 19 2022

mpaszkowski committed rGb0020f423feb: [SPIR-V] Support memory(...) function attributes (authored by mpaszkowski).
[SPIR-V] Support memory(...) function attributes
Dec 19 2022, 10:41 AM · Restricted Project, Restricted Project
mpaszkowski closed D139133: [SPIR-V] Support memory(...) function attributes.
Dec 19 2022, 10:41 AM · Restricted Project, Restricted Project
mpaszkowski committed rG3a26a650821d: [SPIR-V] Disable MachineLateInstrsCleanup pass (authored by mpaszkowski).
[SPIR-V] Disable MachineLateInstrsCleanup pass
Dec 19 2022, 10:27 AM · Restricted Project, Restricted Project
mpaszkowski closed D140103: [SPIR-V] Disable MachineLateInstrsCleanup pass.
Dec 19 2022, 10:27 AM · Restricted Project, Restricted Project

Dec 18 2022

mpaszkowski updated the diff for D140103: [SPIR-V] Disable MachineLateInstrsCleanup pass.
Dec 18 2022, 4:16 PM · Restricted Project, Restricted Project

Dec 15 2022

mpaszkowski added a comment to D140103: [SPIR-V] Disable MachineLateInstrsCleanup pass.

Sorry - I disabled this already for NVPTX and WebAssembly for the same reason but must have missed that SPIRV does not do regalloc when no SPIRV tests at all changed.

Dec 15 2022, 8:22 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D140103: [SPIR-V] Disable MachineLateInstrsCleanup pass.
Dec 15 2022, 6:33 AM · Restricted Project, Restricted Project
mpaszkowski added inline comments to D136310: [SPIR-V] Add atomic_flag builtin implementation.
Dec 15 2022, 3:05 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D136310: [SPIR-V] Add atomic_flag builtin implementation.
Dec 15 2022, 2:59 AM · Restricted Project, Restricted Project
mpaszkowski added a comment to D139133: [SPIR-V] Support memory(...) function attributes.

@arsenm I have removed the checks for ReadNone and also for ReadOnly. Both are replaced with the new memory(...) attributes in functions. I will keep tests for the legacy attributes because we have compilers feeding old LLVM IR into the SPIR-V backend.

The old attributes are converted into the new one during IR parsing, so that probably doesn't really test anything useful?

Dec 15 2022, 2:28 AM · Restricted Project, Restricted Project

Dec 14 2022

mpaszkowski added a comment to D139133: [SPIR-V] Support memory(...) function attributes.

@arsenm I have removed the checks for ReadNone and also for ReadOnly. Both are replaced with the new memory(...) attributes in functions. I will keep tests for the legacy attributes because we have compilers feeding old LLVM IR into the SPIR-V backend.

Dec 14 2022, 6:12 PM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D139133: [SPIR-V] Support memory(...) function attributes.
Dec 14 2022, 6:06 PM · Restricted Project, Restricted Project

Dec 1 2022

mpaszkowski added a comment to D139133: [SPIR-V] Support memory(...) function attributes.

This patch fixes the trivial-function-with-attributes.ll LIT test that is already present in the repository. Additionally, also the get_global_offset.ll test passes.

Dec 1 2022, 11:58 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D139133: [SPIR-V] Support memory(...) function attributes.
Dec 1 2022, 11:54 AM · Restricted Project, Restricted Project
mpaszkowski added a comment to D136310: [SPIR-V] Add atomic_flag builtin implementation.

Thank you @iliya-diyachkov and @arsenm for your review! I apologize that this took so long, but I have now addressed all the comments in the new diff.

Dec 1 2022, 9:28 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D136310: [SPIR-V] Add atomic_flag builtin implementation.
Dec 1 2022, 9:23 AM · Restricted Project, Restricted Project

Oct 30 2022

mpaszkowski accepted D137018: [SPIRV] support enqueue_kernel builtin functions.

Thanks for working on the builtins and preparing the patch! LGTM!

Oct 30 2022, 6:39 PM · Restricted Project, Restricted Project

Oct 19 2022

mpaszkowski requested review of D136310: [SPIR-V] Add atomic_flag builtin implementation.
Oct 19 2022, 6:06 PM · Restricted Project, Restricted Project
mpaszkowski committed rG6beac40fe40c: [SPIR-V] Add get_image_num_mip_levels implementation (authored by mpaszkowski).
[SPIR-V] Add get_image_num_mip_levels implementation
Oct 19 2022, 1:33 PM · Restricted Project, Restricted Project
mpaszkowski closed D135904: [SPIR-V] Add get_image_num_mip_levels implementation.
Oct 19 2022, 1:33 PM · Restricted Project, Restricted Project
mpaszkowski committed rG5fb4a051485a: [SPIR-V] Add atomic_init and fix atomic explicit lowering (authored by mpaszkowski).
[SPIR-V] Add atomic_init and fix atomic explicit lowering
Oct 19 2022, 1:16 PM · Restricted Project, Restricted Project
mpaszkowski closed D135902: [SPIR-V] Add atomic_init builtin and fix atomic explicit lowering.
Oct 19 2022, 1:16 PM · Restricted Project, Restricted Project
mpaszkowski added inline comments to D135902: [SPIR-V] Add atomic_init builtin and fix atomic explicit lowering.
Oct 19 2022, 12:32 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D135902: [SPIR-V] Add atomic_init builtin and fix atomic explicit lowering.

Thanks @iliya-diyachkov! The formatting is now fixed.

Oct 19 2022, 3:48 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D135902: [SPIR-V] Add atomic_init builtin and fix atomic explicit lowering.
Oct 19 2022, 3:47 AM · Restricted Project, Restricted Project
mpaszkowski added a comment to D135904: [SPIR-V] Add get_image_num_mip_levels implementation.

Thanks @andreytr! The formatting and indentation is now fixed.

Oct 19 2022, 3:38 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D135904: [SPIR-V] Add get_image_num_mip_levels implementation.
Oct 19 2022, 3:36 AM · Restricted Project, Restricted Project

Oct 13 2022

mpaszkowski committed rG14ea4f5bf262: [SPIRV] Fix formatting of function tests (authored by mpaszkowski).
[SPIRV] Fix formatting of function tests
Oct 13 2022, 4:56 PM · Restricted Project, Restricted Project
mpaszkowski closed D135624: [SPIRV] Fix formatting of function tests.
Oct 13 2022, 4:56 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D135904: [SPIR-V] Add get_image_num_mip_levels implementation.
Oct 13 2022, 12:00 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D135902: [SPIR-V] Add atomic_init builtin and fix atomic explicit lowering.
Oct 13 2022, 11:54 AM · Restricted Project, Restricted Project

Oct 10 2022

mpaszkowski requested review of D135624: [SPIRV] Fix formatting of function tests.
Oct 10 2022, 3:23 PM · Restricted Project, Restricted Project
mpaszkowski committed rG7a3c9a85c5fa: [SPIRV] Fix call lowering of "anonymous" functions (authored by mpaszkowski).
[SPIRV] Fix call lowering of "anonymous" functions
Oct 10 2022, 3:09 PM · Restricted Project, Restricted Project
mpaszkowski closed D135390: [SPIRV] Fix call lowering of "anonymous" functions.
Oct 10 2022, 3:09 PM · Restricted Project, Restricted Project

Oct 8 2022

mpaszkowski added a comment to D135390: [SPIRV] Fix call lowering of "anonymous" functions.

Updated the patch with the following changes:

Oct 8 2022, 7:16 PM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D135390: [SPIRV] Fix call lowering of "anonymous" functions.
Oct 8 2022, 7:08 PM · Restricted Project, Restricted Project

Oct 6 2022

mpaszkowski requested review of D135390: [SPIRV] Fix call lowering of "anonymous" functions.
Oct 6 2022, 12:55 PM · Restricted Project, Restricted Project

Oct 5 2022

mpaszkowski accepted D135106: [SPIRV] read kernel arg attributes from fuction/module metadata.

Thanks @iliya-diyachkov! LGTM!

Oct 5 2022, 4:38 AM · Restricted Project, Restricted Project
mpaszkowski added inline comments to D135106: [SPIRV] read kernel arg attributes from fuction/module metadata.
Oct 5 2022, 3:03 AM · Restricted Project, Restricted Project

Sep 13 2022

mpaszkowski accepted D133253: [SPIRV] add IR regularization pass.

Thanks for the patch and fixing the issues/comments! LGTM! I think this could be committed now.

Sep 13 2022, 4:38 PM · Restricted Project, Restricted Project
mpaszkowski committed rGcf46835e88e7: [Docs] Added LLVM SPIR-V Backend Working Group (authored by mpaszkowski).
[Docs] Added LLVM SPIR-V Backend Working Group
Sep 13 2022, 11:18 AM · Restricted Project, Restricted Project

Sep 5 2022

mpaszkowski accepted D133265: [SPIRV] Add tests to improve test coverage.
Sep 5 2022, 5:40 AM · Restricted Project, Restricted Project
mpaszkowski added a comment to D133265: [SPIRV] Add tests to improve test coverage.

Thank you @andreytr for the patch! LGTM!

Sep 5 2022, 5:39 AM · Restricted Project, Restricted Project

Aug 31 2022

mpaszkowski accepted D132648: [SPIRV] support builtin types and ExtInst selection.

LGTM! Thank you Ilya for preparing this patch and many previous patches!

Aug 31 2022, 1:56 PM · Restricted Project, Restricted Project

Aug 30 2022

mpaszkowski accepted D132903: [SPIRV] Add tests to improve test coverage.

LGTM! Thank you @andreytr for this patch and the tests!

Aug 30 2022, 4:35 AM · Restricted Project, Restricted Project

Aug 24 2022

mpaszkowski accepted D132024: [SPIRV] support builtin functions.

LGTM! Thank you @iliya-diyachkov for preparing the patch!

Aug 24 2022, 11:41 AM · Restricted Project, Restricted Project

Aug 4 2022

mpaszkowski committed rGff1d47196444: [Docs] Added my office hours (authored by mpaszkowski).
[Docs] Added my office hours
Aug 4 2022, 6:21 AM · Restricted Project, Restricted Project

Aug 2 2022

mpaszkowski accepted D130664: [SPIRV] Fix style of LIT tests and remove metadata.

Thank you @andreytr for preparing the patch and working on the LIT tests for the SPIR-V backend! LGTM!

Aug 2 2022, 3:18 PM · Restricted Project, Restricted Project

Aug 1 2022

mpaszkowski accepted D130518: [SPIRV] use tablegen to create SPIRVBaseInfo*.

Thank you for preparing the patch @iliya-diyachkov! LGTM!

Aug 1 2022, 8:52 AM · Restricted Project, Restricted Project

Jul 21 2022

mpaszkowski accepted D129730: [SPIRV] add PrepareFunctions pass and update other passes.

Thank you for the patch and correcting the issues @iliya-diyachkov! LGTM!

Jul 21 2022, 6:29 AM · Restricted Project, Restricted Project

May 18 2022

mpaszkowski accepted D125679: [Clang] Added options for integrated backend only used for SPIR-V for now.

The typos noticed by Ilia need to be fixed, but apart from this the patch LGTM! Thank you Anastasia!

May 18 2022, 5:12 PM · Restricted Project, Restricted Project

May 5 2022

mpaszkowski accepted D124416: [SPIRV] Add the SPIRV-specific intrinsics, two passes and tests.

Thank you @iliya-diyachkov for the patch and also for fixing the discrepancy in the data layout! The builds seem to be also passing now. LGTM!

May 5 2022, 6:03 AM · Restricted Project, Restricted Project

Apr 19 2022

mpaszkowski committed rGeab7d3639b3c: [SPIR-V](5/6) Add LegalizerInfo, InstructionSelector and utilities (authored by iliya-diyachkov).
[SPIR-V](5/6) Add LegalizerInfo, InstructionSelector and utilities
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski committed rG153dee34f161: [SPIR-V](6/6) Add the module analysis pass and the simplest tests (authored by iliya-diyachkov).
[SPIR-V](6/6) Add the module analysis pass and the simplest tests
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski committed rGec2590362e15: [SPIR-V](4/6) Add target lowering, TargetMachine and AsmPrinter (authored by iliya-diyachkov).
[SPIR-V](4/6) Add target lowering, TargetMachine and AsmPrinter
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski committed rG6c69427e880b: [SPIR-V](3/6) Add MC layer, object file support, and InstPrinter (authored by iliya-diyachkov).
[SPIR-V](3/6) Add MC layer, object file support, and InstPrinter
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski committed rG40114dd5bf41: [SPIR-V](2/6) Add SPIRV target description files (authored by iliya-diyachkov).
[SPIR-V](2/6) Add SPIRV target description files
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski closed D116465: [SPIRV 6/6] Add the module analysis pass and the simplest tests.
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski committed rG7fd4622d4801: [SPIR-V](1/6) Add stub for SPIRV backend (authored by iliya-diyachkov).
[SPIR-V](1/6) Add stub for SPIRV backend
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski closed D116464: [SPIRV 5/6] Add LegalizerInfo, InstructionSelector and utilities.
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski closed D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter.
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski closed D116462: [SPIRV 3/6] Add MC layer, object file support and InstPrinter.
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski closed D115786: [SPIR-V 2/6] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td.
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project
mpaszkowski closed D115009: [SPIRV 1/6] Add stub for SPIRV backend.
Apr 19 2022, 4:28 PM · Restricted Project, Restricted Project

Apr 11 2022

mpaszkowski added a comment to D116465: [SPIRV 6/6] Add the module analysis pass and the simplest tests.

Ping! We kindly ask for "LGTM" :)

Apr 11 2022, 2:52 PM · Restricted Project, Restricted Project

Mar 17 2022

mpaszkowski added a comment to D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter.

Gentle ping! We would like to ask for a final "LGTM".

Mar 17 2022, 2:54 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D116464: [SPIRV 5/6] Add LegalizerInfo, InstructionSelector and utilities.

Gentle ping! We would like to ask for a final "LGTM".

Mar 17 2022, 2:53 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D116465: [SPIRV 6/6] Add the module analysis pass and the simplest tests.

Gentle ping for final review and acceptance :)

Mar 17 2022, 2:51 PM · Restricted Project, Restricted Project

Mar 12 2022

mpaszkowski updated the diff for D115786: [SPIR-V 2/6] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td.
Mar 12 2022, 1:14 PM · Restricted Project, Restricted Project

Jan 27 2022

mpaszkowski added a comment to D115009: [SPIRV 1/6] Add stub for SPIRV backend.

Thank you to everyone for all the suggestions and feedback. In the recent weeks we have resolved all the comments and submitted all the necessary fixes to the initial six submitted patches:

Jan 27 2022, 3:26 AM · Restricted Project, Restricted Project
mpaszkowski added a comment to D115786: [SPIR-V 2/6] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td.

Resolved the comments and suggestions with the newly uploaded patch

Jan 27 2022, 3:07 AM · Restricted Project, Restricted Project

Jan 12 2022

mpaszkowski retitled D115786: [SPIR-V 2/6] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td from [SPIR-V 2/n] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td to [SPIR-V 2/6] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td.
Jan 12 2022, 1:02 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D115786: [SPIR-V 2/6] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td.
Jan 12 2022, 12:48 AM · Restricted Project, Restricted Project

Dec 14 2021

mpaszkowski requested review of D115786: [SPIR-V 2/6] Add SPIRV{InstrFormats,InstrInfo,RegisterInfo,RegisterBanks...}.td.
Dec 14 2021, 11:43 PM · Restricted Project, Restricted Project

Jul 22 2021

mpaszkowski updated the diff for D66029: llvm-canon.

Updated the patch to for the new version of LLVM. Currently the pass still utilizes the legacy pass manager. The pass will be ported to the new pass manager in a separate review.

Jul 22 2021, 9:24 AM · Restricted Project

Sep 11 2020

mpaszkowski added a comment to D66029: llvm-canon.
Sep 11 2020, 11:23 AM · Restricted Project

May 23 2020

mpaszkowski added a comment to D66029: llvm-canon.

@plotfi Should I create a new review so that the HarborMaster will be able run the builds after the fix?

May 23 2020, 5:47 AM · Restricted Project
mpaszkowski committed rG335de55fa338: Revert "Added a new IRCanonicalizer pass." (authored by mpaszkowski).
Revert "Added a new IRCanonicalizer pass."
May 23 2020, 5:16 AM
mpaszkowski added a reverting change for rG14d358537f12: Added a new IRCanonicalizer pass.: rG335de55fa338: Revert "Added a new IRCanonicalizer pass.".
May 23 2020, 5:16 AM