- User Since
- Aug 6 2019, 4:37 PM (52 w, 5 d)
May 23 2020
@plotfi Should I create a new review so that the HarborMaster will be able run the builds after the fix?
Reverted the commit and reopened the review after unsuccessful builds:
May 16 2020
May 2 2020
How do we get HarborMaster to run tests on the patch?
Updated the diff with suggestions from @plotfi.
Thank you @plotfi for review! I will update the diff in a second.
Apr 25 2020
Gentle ping! Is the code ready for the mainline?
Could you @plotfi take a look?
Apr 14 2020
First of all, I am sorry for such a late reply (had many things going on recently). I have updated the patch for the upstream version of the LLVM. Thanks to @aykevl I have corrected the docs/Passes.rst file. Additionaly, I have added a new flag which enables/disables sorting and reordering operands in commutative instructions.
Thanks, will fix that!
Sep 29 2019
Updated the diff for the new revision, refactored naming functions, accepted suggestions by lebedev.
Thank you for the review! @lebedev.ri
Is the code ready for the mainline?
Aug 28 2019
Gentle ping ;)
Aug 21 2019
Aug 19 2019
We have been experimenting with various ways of reordering output instructions hoping to add it now, but it looks to be much tougher than we thought. We hope to add it in a next commit.
- PHI node canonicalization
- Release notes
Aug 18 2019
I would like to thank everyone for your valuable feedback! I have fixed the code and moved the pass to lib/Tranfroms/Utils. I hope I have correctly integrated the pass with the rest of the LLVM (we should have some checklist for that).
Aug 13 2019
First of all, thank you for your valuable feedback!