User Details
- User Since
- Aug 6 2019, 4:37 PM (215 w, 1 d)
Tue, Sep 19
Sun, Sep 17
Tue, Sep 12
Thu, Sep 7
@sudonatalie Thank you for the patch! LGTM!
Wed, Sep 6
Rebased on top of @pmatos patch, added CLI option for SPV_INTEL_optnone, and moved the SPV_INTEL_optnone test to /extensions/. @iliya-diyachkov: Do you think we could have the patch merged now?
Tue, Sep 5
@Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I think that this solution despite being a "hack" seems to be the most straightforward. Eventual differences could be handled in the backend. I would be open for other solutions in the future (for example in case other targets would also stumble upon a similar dilemma), but this looks like a completely valid approach to me.
Thu, Aug 24
I will rebase the patch on top of @pmatos change adding SPV_INTEL_optnone by the end of the day.
Jul 26 2023
Thanks for catching the typo!
Jul 23 2023
New final revision can be found here: https://reviews.llvm.org/D156049
Jul 13 2023
Jun 29 2023
Still WIP, but CTS basic/* tests in both opaque pointer mode and typed pointer mode are now fixed. We still have failures in CTS printf/* tests.
There are some new regressions after this individual patch, we are hitting an assert in SPIRVInstructionSelector for example in integer_ops / long_logic. Full testing results: https://spirv-testing.khronos.org/job/142/
Jun 15 2023
May 11 2023
May 2 2023
Apr 27 2023
Apr 4 2023
Mar 30 2023
Added assert(!MBB.empty() && "MBB is empty!"). This should make it easier to spot similar issues in the future.
Updated the commit with a fix to the failing OpenCL CTS test and added one new LIT test.
Mar 26 2023
Mar 20 2023
Mar 13 2023
Mar 12 2023
Mar 11 2023
Mar 9 2023
Let's wait for the CTS testing results before pushing, but the patch LGTM! Thank you @iliya-diyachkov!
Mar 7 2023
Mar 3 2023
@iliya-diyachkov I checked the half / vstore_half_rtn test manually and it seems to work just fine. Looks like we just got one flaky run for some reason.
Mar 2 2023
Mar 1 2023
Feb 27 2023
Thanks @iliya-diyachkov! Fixed!
Feb 21 2023
Fixed formatting
There still remains a large number of LIT tests with pointers-to-opaque-structs representing OpenCL builtin types. I would suggest to do either one of these things in the next patch:
Feb 16 2023
Fixed issues
Feb 2 2023
Thank you! LGTM!
Feb 1 2023
Fixed formatting
Thanks @arsenm and @iliya-diyachkov for your comments! I have created a new revision https://reviews.llvm.org/D143107 which provides a solution that is compatible with the Khronos SPIR-V Translator and should support nested aggregates. I will close this one.
One (more important) note, only the last error "Element '1': conversion from 'const llvm::SPIRV::FPRoundingMode::FPRoundingMode' to 'unsigned int' requires a narrowing conversion" shows up during compilation and causes it to break. All the other errors show up only in IntelliSense in Visual Studio. This seems to be a known issue with Visual Studio.
@iliya-diyachkov I updated Visual Studio and there seems to be many more problems with building with MSVC (table below). There are no warnings in SPIRVUtils.cpp.
Jan 30 2023
@iliya-diyachkov Thanks! I will check with MSVC.
Jan 19 2023
Jan 18 2023
Full runtime testing results are now available: https://spirv-testing.khronos.org/job/82/. I will commit this patch after D142061.
@nikic I have created the issue for tracking the SPIR-V backend LIT tests with -opaque-pointers=0 here: https://github.com/llvm/llvm-project/issues/60133
Jan 17 2023
Gentle ping!
Jan 13 2023
Jan 9 2023
Jan 7 2023
Jan 6 2023
@arsenm Thanks! I uploaded a new updated patch.
Dec 22 2022
Thank you for the patch @iliya-diyachkov! The runtime testing results are now available. LGTM!