Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

mpaszkowski (Michal Paszkowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2019, 4:37 PM (215 w, 1 d)

Recent Activity

Tue, Sep 19

mpaszkowski committed rG2616c279d5a9: [SPIR-V] Preserve pointer address space for load/gep instructions (authored by mpaszkowski).
[SPIR-V] Preserve pointer address space for load/gep instructions
Tue, Sep 19, 1:49 AM · Restricted Project, Restricted Project
mpaszkowski closed D158761: [SPIR-V] Preserve pointer address space for load/gep instructions.
Tue, Sep 19, 1:49 AM · Restricted Project, Restricted Project
mpaszkowski committed rGec7baca17e78: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support (authored by mpaszkowski).
[SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support
Tue, Sep 19, 12:57 AM · Restricted Project, Restricted Project
mpaszkowski closed D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support.
Tue, Sep 19, 12:57 AM · Restricted Project, Restricted Project

Sun, Sep 17

mpaszkowski added a comment to D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support.

Sure, I have made this patch a bit smaller. Still all the fixes are present, but I have kept all the LIT names the same and kept them in the same directories. Renaming, moving, and merging of tests will come in a separate patch.

Thanks! What about removed tests, I'm not sure if we have an analogue of linked-list.ll (with check of OpTypeOpaque). If it's true, is it possible to write such a test?

Sun, Sep 17, 1:56 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support.
Sun, Sep 17, 1:51 AM · Restricted Project, Restricted Project

Tue, Sep 12

mpaszkowski committed rGefe0e10718cb: [SPIR-V] Support SPV_INTEL_arbitrary_precision_integers_extension, misc utils… (authored by mpaszkowski).
[SPIR-V] Support SPV_INTEL_arbitrary_precision_integers_extension, misc utils…
Tue, Sep 12, 2:54 AM · Restricted Project, Restricted Project
mpaszkowski closed D158764: [SPIR-V] Support SPV_INTEL_arbitrary_precision_integers_extension and add misc utilities for other extensions.
Tue, Sep 12, 2:54 AM · Restricted Project, Restricted Project

Thu, Sep 7

mpaszkowski accepted D159376: [SPIRV] Fix OpConstant float and double printing.

@sudonatalie Thank you for the patch! LGTM!

Thu, Sep 7, 1:22 PM · Restricted Project, Restricted Project
mpaszkowski accepted D157224: [Target] Fix typo in comments.
Thu, Sep 7, 12:20 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support.

Sorry for delay with the answer. It looks good in general.

Some tests look deleted and some look newly created, but they are just moved/renamed with many changes inside. Can we split these operations? I.e. make changes related to opaque pointers and builtin types in this patch and rename the tests in a separate patch. It will save the history of changes in the tests.

Thu, Sep 7, 12:09 PM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support.
Thu, Sep 7, 12:05 PM · Restricted Project, Restricted Project

Wed, Sep 6

mpaszkowski added a comment to D155978: [SPIRV] Add SPIR-V logical triple..

@Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I think that this solution despite being a "hack" seems to be the most straightforward. Eventual differences could be handled in the backend. I would be open for other solutions in the future (for example in case other targets would also stumble upon a similar dilemma), but this looks like a completely valid approach to me.

Thanks!
Do you know how we can get this merged? (we have no commit access on our end).

Wed, Sep 6, 10:02 PM · Restricted Project, Restricted Project, Restricted Project
mpaszkowski updated the diff for D158764: [SPIR-V] Support SPV_INTEL_arbitrary_precision_integers_extension and add misc utilities for other extensions.

Rebased on top of @pmatos patch, added CLI option for SPV_INTEL_optnone, and moved the SPV_INTEL_optnone test to /extensions/. @iliya-diyachkov: Do you think we could have the patch merged now?

Wed, Sep 6, 4:06 AM · Restricted Project, Restricted Project

Tue, Sep 5

mpaszkowski accepted D155978: [SPIRV] Add SPIR-V logical triple..

@Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I think that this solution despite being a "hack" seems to be the most straightforward. Eventual differences could be handled in the backend. I would be open for other solutions in the future (for example in case other targets would also stumble upon a similar dilemma), but this looks like a completely valid approach to me.

Tue, Sep 5, 4:35 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Aug 24

mpaszkowski added a comment to D158764: [SPIR-V] Support SPV_INTEL_arbitrary_precision_integers_extension and add misc utilities for other extensions.

I will rebase the patch on top of @pmatos change adding SPV_INTEL_optnone by the end of the day.

Thu, Aug 24, 12:00 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D158764: [SPIR-V] Support SPV_INTEL_arbitrary_precision_integers_extension and add misc utilities for other extensions.
Thu, Aug 24, 11:57 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D158761: [SPIR-V] Preserve pointer address space for load/gep instructions.
Thu, Aug 24, 11:32 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support.
Thu, Aug 24, 10:07 AM · Restricted Project, Restricted Project

Jul 26 2023

mpaszkowski added a comment to D156297: [SPIRV] Add support for SPV_INTEL_optnone.

This is a draft patch - I want to discuss somethings inline.

The output for optnone.ll is:

bin/llc -O0 -mtriple=spirv32-unknown-unknown ../llvm/test/CodeGen/SPIRV/optnone.ll -o -
	OpCapability Kernel
	OpCapability Addresses
	OpCapability Linkage
	%1 = OpExtInstImport "OpenCL.std"
	OpMemoryModel Physical32 OpenCL
	OpExecutionMode %4 ContractionOff
	OpSource Unknown 0
	OpName %4 "_Z3foov"
	OpDecorate %4 LinkageAttributes "_Z3foov" Export
	%2 = OpTypeVoid
	%3 = OpTypeFunction %2
	OpCapability OptNoneINTEL               ; -- Begin function _Z3foov
	OpExtension "�" "�" "�" "�" "�" "�"
	%4 = OpFunction %2 DontInline %3
	%5 = OpLabel
	OpReturn
	OpFunctionEnd

OpExtension emits some funky unicode characters, I feel like I am doing this incorrectly but similarly to what's being done in SPIRVAsmPrinter::outputGlobalRequirements() :

MCInst Inst;
    Inst.setOpcode(SPIRV::OpExtension);
    addStringImm(getSymbolicOperandMnemonic(
                     SPIRV::OperandCategory::ExtensionOperand, Ext),
                 Inst);
    outputMCInst(Inst);

The other issue is that afaiu the OpExtension declaractions need to come up the top of the module. How is this organized in the backend so that I can emit these at the top of the module? Do I need to add these to the module requirements somehow?

Jul 26 2023, 3:16 PM · Restricted Project, Restricted Project
mpaszkowski accepted D156231: [SPIRV][NFC] Fix typo in SPV_KHR_16bit_storage extension name.

Thanks for catching the typo!

Jul 26 2023, 2:49 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D156231: [SPIRV][NFC] Fix typo in SPV_KHR_16bit_storage extension name.

The site: https://spirv-testing.khronos.org/staging/
is not working at the moment, right? At least, this phab diff is not present there.

Jul 26 2023, 2:48 PM · Restricted Project, Restricted Project

Jul 23 2023

mpaszkowski abandoned D149679: [SPIR-V] [WIP] Convert tests to opaque pointers.

New final revision can be found here: https://reviews.llvm.org/D156049

Jul 23 2023, 3:05 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support.
Jul 23 2023, 2:33 AM · Restricted Project, Restricted Project

Jul 13 2023

mpaszkowski updated the diff for D149679: [SPIR-V] [WIP] Convert tests to opaque pointers.
Jul 13 2023, 12:11 PM · Restricted Project, Restricted Project

Jun 29 2023

mpaszkowski updated the diff for D149679: [SPIR-V] [WIP] Convert tests to opaque pointers.

Still WIP, but CTS basic/* tests in both opaque pointer mode and typed pointer mode are now fixed. We still have failures in CTS printf/* tests.

Jun 29 2023, 12:24 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D153099: [SPIR-V] Begin removing explicit setRegClass calls.

There are some new regressions after this individual patch, we are hitting an assert in SPIRVInstructionSelector for example in integer_ops / long_logic. Full testing results: https://spirv-testing.khronos.org/job/142/

Jun 29 2023, 9:44 AM · Restricted Project, Restricted Project

Jun 15 2023

mpaszkowski updated the diff for D149679: [SPIR-V] [WIP] Convert tests to opaque pointers.
Jun 15 2023, 12:15 PM · Restricted Project, Restricted Project

May 11 2023

mpaszkowski updated the diff for D149679: [SPIR-V] [WIP] Convert tests to opaque pointers.
May 11 2023, 5:56 AM · Restricted Project, Restricted Project

May 2 2023

mpaszkowski requested review of D149679: [SPIR-V] [WIP] Convert tests to opaque pointers.
May 2 2023, 12:19 PM · Restricted Project, Restricted Project

Apr 27 2023

mpaszkowski requested review of D149362: [SPIR-V] Rename SPIRVGlobalRegistry to SPIRVGlobalObjectRegistry.
Apr 27 2023, 11:00 AM · Restricted Project, Restricted Project

Apr 4 2023

mpaszkowski committed rG8bfb2b6d771c: [SPIR-V] Remove switch G_ICMP+G_BRCOND+G_BR before ISel (authored by mpaszkowski).
[SPIR-V] Remove switch G_ICMP+G_BRCOND+G_BR before ISel
Apr 4 2023, 2:54 PM · Restricted Project, Restricted Project
mpaszkowski closed D146923: [SPIR-V] Remove switch G_ICMP+G_BRCOND+G_BR before ISel.
Apr 4 2023, 2:54 PM · Restricted Project, Restricted Project

Mar 30 2023

mpaszkowski updated the diff for D146923: [SPIR-V] Remove switch G_ICMP+G_BRCOND+G_BR before ISel.

Added assert(!MBB.empty() && "MBB is empty!"). This should make it easier to spot similar issues in the future.

Mar 30 2023, 11:19 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D146923: [SPIR-V] Remove switch G_ICMP+G_BRCOND+G_BR before ISel.

Updated the commit with a fix to the failing OpenCL CTS test and added one new LIT test.

Mar 30 2023, 11:04 AM · Restricted Project, Restricted Project

Mar 26 2023

mpaszkowski requested review of D146923: [SPIR-V] Remove switch G_ICMP+G_BRCOND+G_BR before ISel.
Mar 26 2023, 11:26 AM · Restricted Project, Restricted Project

Mar 20 2023

mpaszkowski committed rGb333f3393934: [SPIR-V] Add Machine Value Type for SPIR-V builtins (authored by mpaszkowski).
[SPIR-V] Add Machine Value Type for SPIR-V builtins
Mar 20 2023, 3:17 PM · Restricted Project, Restricted Project
mpaszkowski closed D145703: [SPIR-V] Add Machine Value Type for SPIR-V builtins.
Mar 20 2023, 3:17 PM · Restricted Project, Restricted Project

Mar 13 2023

mpaszkowski committed rGdc4330a9259f: [SPIR-V] Promote arbitrary width ints to regular width (authored by mpaszkowski).
[SPIR-V] Promote arbitrary width ints to regular width
Mar 13 2023, 2:47 PM · Restricted Project, Restricted Project
mpaszkowski closed D145137: [SPIR-V] Promote arbitrary width ints to regular width.
Mar 13 2023, 2:46 PM · Restricted Project, Restricted Project

Mar 12 2023

mpaszkowski committed rG147ff1b494bc: [SPIR-V] Fix llvm deprecated warnings (authored by mpaszkowski).
[SPIR-V] Fix llvm deprecated warnings
Mar 12 2023, 12:50 PM · Restricted Project, Restricted Project
mpaszkowski closed D145709: [SPIR-V] Fix llvm deprecated warnings.
Mar 12 2023, 12:49 PM · Restricted Project, Restricted Project

Mar 11 2023

mpaszkowski added inline comments to D145703: [SPIR-V] Add Machine Value Type for SPIR-V builtins.
Mar 11 2023, 2:54 PM · Restricted Project, Restricted Project

Mar 9 2023

mpaszkowski accepted D144897: [SPIRV] fix several issues in builds with expensive checks.

Let's wait for the CTS testing results before pushing, but the patch LGTM! Thank you @iliya-diyachkov!

Mar 9 2023, 4:37 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D145137: [SPIR-V] Promote arbitrary width ints to regular width.

Why is this not changing any legalizer rules?

Mar 9 2023, 1:23 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D145709: [SPIR-V] Fix llvm deprecated warnings.
Mar 9 2023, 11:00 AM · Restricted Project, Restricted Project
mpaszkowski committed rG78ea3cb0bb19: [SPIR-V] Report modifying IR in SPIRVPrepareFunctions (authored by mpaszkowski).
[SPIR-V] Report modifying IR in SPIRVPrepareFunctions
Mar 9 2023, 10:24 AM · Restricted Project, Restricted Project
mpaszkowski closed D145121: [SPIR-V] Report modifying IR in SPIRVPrepareFunctions.
Mar 9 2023, 10:23 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D145703: [SPIR-V] Add Machine Value Type for SPIR-V builtins.
Mar 9 2023, 10:18 AM · Restricted Project, Restricted Project

Mar 7 2023

mpaszkowski updated the diff for D145121: [SPIR-V] Report modifying IR in SPIRVPrepareFunctions.
Mar 7 2023, 6:08 AM · Restricted Project, Restricted Project

Mar 3 2023

mpaszkowski added a comment to D144897: [SPIRV] fix several issues in builds with expensive checks.

@iliya-diyachkov I checked the half / vstore_half_rtn test manually and it seems to work just fine. Looks like we just got one flaky run for some reason.

Mar 3 2023, 4:27 PM · Restricted Project, Restricted Project

Mar 2 2023

mpaszkowski updated the diff for D145121: [SPIR-V] Report modifying IR in SPIRVPrepareFunctions.
Mar 2 2023, 11:49 AM · Restricted Project, Restricted Project

Mar 1 2023

mpaszkowski requested review of D145137: [SPIR-V] Promote arbitrary width ints to regular width.
Mar 1 2023, 6:37 PM · Restricted Project, Restricted Project
mpaszkowski committed rG20f650b231e3: [SPIR-V] Remove redundant check and fix typos (authored by mpaszkowski).
[SPIR-V] Remove redundant check and fix typos
Mar 1 2023, 3:56 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D145121: [SPIR-V] Report modifying IR in SPIRVPrepareFunctions.
Mar 1 2023, 2:30 PM · Restricted Project, Restricted Project
mpaszkowski added inline comments to D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types.
Mar 1 2023, 11:04 AM · Restricted Project, Restricted Project

Feb 27 2023

mpaszkowski committed rG5ac69674bf4f: [SPIR-V] Support TargetExtType for SPIR-V builtin types (authored by mpaszkowski).
[SPIR-V] Support TargetExtType for SPIR-V builtin types
Feb 27 2023, 12:40 PM · Restricted Project, Restricted Project
mpaszkowski closed D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types.
Feb 27 2023, 12:40 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types.

Thanks @iliya-diyachkov! Fixed!

Feb 27 2023, 6:02 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types.
Feb 27 2023, 6:00 AM · Restricted Project, Restricted Project

Feb 21 2023

mpaszkowski updated the diff for D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types.

Fixed formatting

Feb 21 2023, 4:57 PM · Restricted Project, Restricted Project
mpaszkowski committed rGb8435e392cc8: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands (authored by mpaszkowski).
[SPIR-V] Emit spv_undef intrinsic for aggregate undef operands
Feb 21 2023, 12:47 PM · Restricted Project, Restricted Project
mpaszkowski closed D143107: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands.
Feb 21 2023, 12:47 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types.

There still remains a large number of LIT tests with pointers-to-opaque-structs representing OpenCL builtin types. I would suggest to do either one of these things in the next patch:

Feb 21 2023, 8:10 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types.
Feb 21 2023, 8:02 AM · Restricted Project, Restricted Project

Feb 16 2023

mpaszkowski added a comment to D143107: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands.

Fixed issues

Feb 16 2023, 12:35 PM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D143107: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands.
Feb 16 2023, 12:33 PM · Restricted Project, Restricted Project

Feb 2 2023

mpaszkowski accepted D142937: [SPIRV][NFC] fix build warning in SPIRVUtils.cpp.

Thank you! LGTM!

Feb 2 2023, 10:44 AM · Restricted Project, Restricted Project

Feb 1 2023

mpaszkowski updated the diff for D143107: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands.

Fixed formatting

Feb 1 2023, 1:28 PM · Restricted Project, Restricted Project
mpaszkowski abandoned D141337: [SPIR-V] Fix translation of aggregate undef operands.

Thanks @arsenm and @iliya-diyachkov for your comments! I have created a new revision https://reviews.llvm.org/D143107 which provides a solution that is compatible with the Khronos SPIR-V Translator and should support nested aggregates. I will close this one.

Feb 1 2023, 1:13 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D143107: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands.
Feb 1 2023, 1:10 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D142937: [SPIRV][NFC] fix build warning in SPIRVUtils.cpp.

One (more important) note, only the last error "Element '1': conversion from 'const llvm::SPIRV::FPRoundingMode::FPRoundingMode' to 'unsigned int' requires a narrowing conversion" shows up during compilation and causes it to break. All the other errors show up only in IntelliSense in Visual Studio. This seems to be a known issue with Visual Studio.

Feb 1 2023, 8:03 AM · Restricted Project, Restricted Project
mpaszkowski added a comment to D142937: [SPIRV][NFC] fix build warning in SPIRVUtils.cpp.

@iliya-diyachkov I updated Visual Studio and there seems to be many more problems with building with MSVC (table below). There are no warnings in SPIRVUtils.cpp.

Feb 1 2023, 7:58 AM · Restricted Project, Restricted Project

Jan 30 2023

mpaszkowski added a comment to D142937: [SPIRV][NFC] fix build warning in SPIRVUtils.cpp.

@iliya-diyachkov Thanks! I will check with MSVC.

Jan 30 2023, 2:20 PM · Restricted Project, Restricted Project

Jan 19 2023

mpaszkowski committed rG2bcedd464348: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata (authored by mpaszkowski).
[SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata
Jan 19 2023, 6:27 AM · Restricted Project, Restricted Project
mpaszkowski closed D141734: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata.
Jan 19 2023, 6:27 AM · Restricted Project, Restricted Project
mpaszkowski committed rG786cb151d938: [SPIR-V] Add -opaque-pointers=0 to some LIT tests (authored by mpaszkowski).
[SPIR-V] Add -opaque-pointers=0 to some LIT tests
Jan 19 2023, 5:03 AM · Restricted Project, Restricted Project
mpaszkowski closed D142061: [SPIR-V] Add -opaque-pointers=0 to some LIT tests.
Jan 19 2023, 5:02 AM · Restricted Project, Restricted Project

Jan 18 2023

mpaszkowski added a comment to D141734: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata.

Full runtime testing results are now available: https://spirv-testing.khronos.org/job/82/. I will commit this patch after D142061.

Jan 18 2023, 3:45 PM · Restricted Project, Restricted Project
mpaszkowski added a comment to D142061: [SPIR-V] Add -opaque-pointers=0 to some LIT tests.

@nikic I have created the issue for tracking the SPIR-V backend LIT tests with -opaque-pointers=0 here: https://github.com/llvm/llvm-project/issues/60133

Jan 18 2023, 3:20 PM · Restricted Project, Restricted Project
mpaszkowski requested review of D142061: [SPIR-V] Add -opaque-pointers=0 to some LIT tests.
Jan 18 2023, 3:15 PM · Restricted Project, Restricted Project

Jan 17 2023

mpaszkowski added a comment to D141337: [SPIR-V] Fix translation of aggregate undef operands.

Gentle ping!

Jan 17 2023, 4:20 AM · Restricted Project, Restricted Project

Jan 13 2023

mpaszkowski requested review of D141734: [SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata.
Jan 13 2023, 3:32 PM · Restricted Project, Restricted Project
mpaszkowski committed rGe461bdf65b66: [SPIR-V] Fix switch lowering with common compare register (authored by mpaszkowski).
[SPIR-V] Fix switch lowering with common compare register
Jan 13 2023, 2:00 PM · Restricted Project, Restricted Project
mpaszkowski closed D141203: [SPIR-V] Fix switch lowering with common compare register.
Jan 13 2023, 1:59 PM · Restricted Project, Restricted Project

Jan 9 2023

mpaszkowski requested review of D141337: [SPIR-V] Fix translation of aggregate undef operands.
Jan 9 2023, 5:24 PM · Restricted Project, Restricted Project

Jan 7 2023

mpaszkowski requested review of D141203: [SPIR-V] Fix switch lowering with common compare register.
Jan 7 2023, 11:11 AM · Restricted Project, Restricted Project
mpaszkowski committed rG99203241df4d: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis (authored by mpaszkowski).
[SPIR-V] Map IR function pointers to registers in ModuleAnalysis
Jan 7 2023, 6:40 AM · Restricted Project, Restricted Project
mpaszkowski closed D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.
Jan 7 2023, 6:40 AM · Restricted Project, Restricted Project

Jan 6 2023

mpaszkowski added a comment to D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.

@arsenm Thanks! I uploaded a new updated patch.

Jan 6 2023, 7:27 AM · Restricted Project, Restricted Project
mpaszkowski updated the diff for D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.
Jan 6 2023, 7:26 AM · Restricted Project, Restricted Project

Dec 22 2022

mpaszkowski accepted D140490: [SPIRV] support __spirv_Load/Store builtin functions.

Thank you for the patch @iliya-diyachkov! The runtime testing results are now available. LGTM!

Dec 22 2022, 6:10 AM · Restricted Project, Restricted Project
mpaszkowski requested review of D140548: [SPIR-V] Map IR function pointers to registers in ModuleAnalysis.
Dec 22 2022, 6:05 AM · Restricted Project, Restricted Project

Dec 21 2022

mpaszkowski committed rG870808989676: [SPIR-V] Add atomic_flag builtin implementation (authored by mpaszkowski).
[SPIR-V] Add atomic_flag builtin implementation
Dec 21 2022, 2:01 PM · Restricted Project, Restricted Project
mpaszkowski closed D136310: [SPIR-V] Add atomic_flag builtin implementation.
Dec 21 2022, 2:00 PM · Restricted Project, Restricted Project

Dec 19 2022

mpaszkowski committed rGb0020f423feb: [SPIR-V] Support memory(...) function attributes (authored by mpaszkowski).
[SPIR-V] Support memory(...) function attributes
Dec 19 2022, 10:41 AM · Restricted Project, Restricted Project
mpaszkowski closed D139133: [SPIR-V] Support memory(...) function attributes.
Dec 19 2022, 10:41 AM · Restricted Project, Restricted Project
mpaszkowski committed rG3a26a650821d: [SPIR-V] Disable MachineLateInstrsCleanup pass (authored by mpaszkowski).
[SPIR-V] Disable MachineLateInstrsCleanup pass
Dec 19 2022, 10:27 AM · Restricted Project, Restricted Project
mpaszkowski closed D140103: [SPIR-V] Disable MachineLateInstrsCleanup pass.
Dec 19 2022, 10:27 AM · Restricted Project, Restricted Project

Dec 18 2022

mpaszkowski updated the diff for D140103: [SPIR-V] Disable MachineLateInstrsCleanup pass.
Dec 18 2022, 4:16 PM · Restricted Project, Restricted Project