Page MenuHomePhabricator

mpaszkowski (Michal Paszkowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2019, 4:37 PM (52 w, 5 d)

Recent Activity

May 23 2020

mpaszkowski added a comment to D66029: llvm-canon.

@plotfi Should I create a new review so that the HarborMaster will be able run the builds after the fix?

May 23 2020, 5:47 AM · Restricted Project
mpaszkowski committed rG335de55fa338: Revert "Added a new IRCanonicalizer pass." (authored by mpaszkowski).
Revert "Added a new IRCanonicalizer pass."
May 23 2020, 5:16 AM
mpaszkowski added a reverting change for rG14d358537f12: Added a new IRCanonicalizer pass.: rG335de55fa338: Revert "Added a new IRCanonicalizer pass.".
May 23 2020, 5:16 AM
mpaszkowski added a reverting change for rGa0c7108b99f8: [gn build] Port 14d358537f1: rGfc12ead8ff51: Revert "[gn build] Port 14d358537f1".
May 23 2020, 5:16 AM
mpaszkowski committed rGfc12ead8ff51: Revert "[gn build] Port 14d358537f1" (authored by mpaszkowski).
Revert "[gn build] Port 14d358537f1"
May 23 2020, 5:16 AM
mpaszkowski reopened D66029: llvm-canon.

Reverted the commit and reopened the review after unsuccessful builds:

May 23 2020, 5:15 AM · Restricted Project
mpaszkowski committed rG14d358537f12: Added a new IRCanonicalizer pass. (authored by mpaszkowski).
Added a new IRCanonicalizer pass.
May 23 2020, 4:12 AM
mpaszkowski closed D66029: llvm-canon.
May 23 2020, 4:12 AM · Restricted Project

May 16 2020

mpaszkowski added a comment to D66029: llvm-canon.

Nice work. I think this LGTM.

May 16 2020, 12:41 PM · Restricted Project

May 2 2020

mpaszkowski added a comment to D66029: llvm-canon.

How do we get HarborMaster to run tests on the patch?

May 2 2020, 1:46 PM · Restricted Project
mpaszkowski updated the diff for D66029: llvm-canon.

Updated the diff with suggestions from @plotfi.

May 2 2020, 1:46 PM · Restricted Project
mpaszkowski added a comment to D66029: llvm-canon.

Thank you @plotfi for review! I will update the diff in a second.

May 2 2020, 1:46 PM · Restricted Project

Apr 25 2020

mpaszkowski added a comment to D66029: llvm-canon.

Gentle ping! Is the code ready for the mainline?
Could you @plotfi take a look?

Apr 25 2020, 3:24 PM · Restricted Project

Apr 14 2020

mpaszkowski updated the diff for D66029: llvm-canon.

First of all, I am sorry for such a late reply (had many things going on recently). I have updated the patch for the upstream version of the LLVM. Thanks to @aykevl I have corrected the docs/Passes.rst file. Additionaly, I have added a new flag which enables/disables sorting and reordering operands in commutative instructions.

Apr 14 2020, 3:09 AM · Restricted Project
mpaszkowski added a comment to D66029: llvm-canon.

Thanks, will fix that!

Apr 14 2020, 2:37 AM · Restricted Project

Sep 29 2019

mpaszkowski updated the diff for D66029: llvm-canon.

Updated the diff for the new revision, refactored naming functions, accepted suggestions by lebedev.
Thank you for the review! @lebedev.ri
Is the code ready for the mainline?

Sep 29 2019, 5:43 AM · Restricted Project
mpaszkowski added inline comments to D66029: llvm-canon.
Sep 29 2019, 5:38 AM · Restricted Project

Aug 28 2019

mpaszkowski added a comment to D66029: llvm-canon.

Gentle ping ;)

Aug 28 2019, 6:30 AM · Restricted Project

Aug 21 2019

mpaszkowski added a comment to D66029: llvm-canon.

Now the canonicalizer sorts values in PHI nodes. After a discussion, I have decided not to remove duplicates. Those duplicates could come from some other passes and in my opinion, the canonicalizer should make them stand out instead of removing them.

I suppose that you mean that, if passes are introducing duplicates, that's something that we'd rather fix? That might be true. I'm okay with proceeding on this basis. If we need the deduplicating behavior we'll find out.

Aug 21 2019, 11:16 PM · Restricted Project

Aug 19 2019

mpaszkowski added a comment to D66029: llvm-canon.

We have been experimenting with various ways of reordering output instructions hoping to add it now, but it looks to be much tougher than we thought. We hope to add it in a next commit.

Aug 19 2019, 4:18 PM · Restricted Project
mpaszkowski updated the diff for D66029: llvm-canon.
  • PHI node canonicalization
  • Tests
  • Release notes
  • Docs
Aug 19 2019, 3:57 PM · Restricted Project

Aug 18 2019

mpaszkowski added inline comments to D66029: llvm-canon.
Aug 18 2019, 12:48 PM · Restricted Project
mpaszkowski updated the diff for D66029: llvm-canon.

I would like to thank everyone for your valuable feedback! I have fixed the code and moved the pass to lib/Tranfroms/Utils. I hope I have correctly integrated the pass with the rest of the LLVM (we should have some checklist for that).

Aug 18 2019, 12:40 PM · Restricted Project

Aug 13 2019

mpaszkowski added a comment to D66029: llvm-canon.

First of all, thank you for your valuable feedback!

Aug 13 2019, 4:57 AM · Restricted Project

Aug 9 2019

mpaszkowski created D66029: llvm-canon.
Aug 9 2019, 1:33 PM · Restricted Project