User Details
- User Since
- Aug 6 2019, 4:37 PM (181 w, 5 d)
Thu, Jan 19
Wed, Jan 18
Full runtime testing results are now available: https://spirv-testing.khronos.org/job/82/. I will commit this patch after D142061.
@nikic I have created the issue for tracking the SPIR-V backend LIT tests with -opaque-pointers=0 here: https://github.com/llvm/llvm-project/issues/60133
Tue, Jan 17
Gentle ping!
Fri, Jan 13
Mon, Jan 9
Sat, Jan 7
Fri, Jan 6
@arsenm Thanks! I uploaded a new updated patch.
Dec 22 2022
Thank you for the patch @iliya-diyachkov! The runtime testing results are now available. LGTM!
Dec 21 2022
Dec 19 2022
Dec 18 2022
Dec 15 2022
Dec 14 2022
@arsenm I have removed the checks for ReadNone and also for ReadOnly. Both are replaced with the new memory(...) attributes in functions. I will keep tests for the legacy attributes because we have compilers feeding old LLVM IR into the SPIR-V backend.
Dec 1 2022
This patch fixes the trivial-function-with-attributes.ll LIT test that is already present in the repository. Additionally, also the get_global_offset.ll test passes.
Thank you @iliya-diyachkov and @arsenm for your review! I apologize that this took so long, but I have now addressed all the comments in the new diff.
Oct 30 2022
Thanks for working on the builtins and preparing the patch! LGTM!
Oct 19 2022
Thanks @iliya-diyachkov! The formatting is now fixed.
Thanks @andreytr! The formatting and indentation is now fixed.
Oct 13 2022
Oct 10 2022
Oct 8 2022
Updated the patch with the following changes:
Oct 6 2022
Oct 5 2022
Thanks @iliya-diyachkov! LGTM!
Sep 13 2022
Thanks for the patch and fixing the issues/comments! LGTM! I think this could be committed now.
Sep 5 2022
Thank you @andreytr for the patch! LGTM!
Aug 31 2022
LGTM! Thank you Ilya for preparing this patch and many previous patches!
Aug 30 2022
LGTM! Thank you @andreytr for this patch and the tests!
Aug 24 2022
LGTM! Thank you @iliya-diyachkov for preparing the patch!
Aug 4 2022
Aug 2 2022
Thank you @andreytr for preparing the patch and working on the LIT tests for the SPIR-V backend! LGTM!
Aug 1 2022
Thank you for preparing the patch @iliya-diyachkov! LGTM!
Jul 21 2022
Thank you for the patch and correcting the issues @iliya-diyachkov! LGTM!
May 18 2022
The typos noticed by Ilia need to be fixed, but apart from this the patch LGTM! Thank you Anastasia!
May 5 2022
Thank you @iliya-diyachkov for the patch and also for fixing the discrepancy in the data layout! The builds seem to be also passing now. LGTM!
Apr 19 2022
Apr 11 2022
Ping! We kindly ask for "LGTM" :)
Mar 17 2022
Gentle ping! We would like to ask for a final "LGTM".
Gentle ping! We would like to ask for a final "LGTM".
Gentle ping for final review and acceptance :)
Mar 12 2022
Jan 27 2022
Thank you to everyone for all the suggestions and feedback. In the recent weeks we have resolved all the comments and submitted all the necessary fixes to the initial six submitted patches:
Resolved the comments and suggestions with the newly uploaded patch
Jan 12 2022
Dec 14 2021
Jul 22 2021
Updated the patch to for the new version of LLVM. Currently the pass still utilizes the legacy pass manager. The pass will be ported to the new pass manager in a separate review.
Sep 11 2020
May 23 2020
@plotfi Should I create a new review so that the HarborMaster will be able run the builds after the fix?