Page MenuHomePhabricator

[OpenMP] Delete old plugins
Needs ReviewPublic

Authored by jhuber6 on Jan 28 2023, 3:47 PM.

Details

Summary

It's time to remove the old plugins as the next-gen has already been set
to default in LLVM 16.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jan 28 2023, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 3:47 PM
tianshilei1992 requested review of this revision.Jan 28 2023, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 3:47 PM

optimize run lines

fix test line again

Where's dynamic_cuda and dynamic_hsa. Also why not replace plugins with nextgen instead of keeping the name.

Where's dynamic_cuda and dynamic_hsa. Also why not replace plugins with nextgen instead of keeping the name.

Oh right, the two dynamic libraries have to be moved.

Also, I don't think the nextgen plugins managed the tests. Does this patch retain that code?

Shall we wait to see if people using the nextgen report breakages before deleting the current/previous? I don't think the latest branch has actually shipped to anyone yet

Seems like the schedule is the end of Feb. I'll update the patch properly by then.

Is this ready?

I can commandeer tomorrow

jhuber6 commandeered this revision.Tue, Mar 21, 9:28 AM
jhuber6 edited reviewers, added: tianshilei1992; removed: jhuber6.
jhuber6 updated this revision to Diff 507019.Tue, Mar 21, 9:28 AM

Hopefully this works.