This is an archive of the discontinued LLVM Phabricator instance.

Differential D14265

DI: Reverse direction of subprogram -> function edge.
ClosedPublic

Authored by pcc on Nov 2 2015, 4:27 PM.

Details

Reviewers
dexonsmith
Commits
rGd4bff30370db: DI: Reverse direction of subprogram -> function edge.
rL252219: DI: Reverse direction of subprogram -> function edge.
Summary

Previously, subprograms contained a metadata reference to the function they
described. Because most clients need to get or set a subprogram for a given
function rather than the other way around, this created unneeded inefficiency.

For example, many passes needed to call the function llvm::makeSubprogramMap()
to build a mapping from functions to subprograms, and the IR linker needed to
fix up function references in a way that caused quadratic complexity in the IR
linking phase of LTO.

This change reverses the direction of the edge by storing the subprogram as
function-level metadata and removing DISubprogram's function field.

Since this is an IR change, a bitcode upgrade has been provided.

Fixes PR23367.

Diff Detail

Event Timeline

pcc updated this revision to Diff 39002.Nov 2 2015, 4:27 PM
pcc retitled this revision from to DI: Reverse direction of subprogram -> function edge..
pcc updated this object.
pcc added a reviewer: dexonsmith.
pcc added a subscriber: llvm-commits.
Herald added subscribers: dsanders, jyknight, axw. · View Herald TranscriptNov 2 2015, 4:27 PM
krasin added a subscriber: krasin.Nov 2 2015, 4:49 PM
axw added a comment.Nov 2 2015, 5:04 PM

bindings/go changes LGTM

aprantl added a subscriber: aprantl.Nov 3 2015, 9:52 AM

I'm impressed that we apparently never needed the other direction.
This looks good from a debug info point of view.

Two questions/remarks:

  • Could you include your upgrade script so people can upgrade their out-of-tree testcases?
  • Shouldn't we drop the function field from the DISubprogram bitcode representation?

thanks for working on this!
adrian

dblaikie added a subscriber: dblaikie.Nov 3 2015, 10:02 AM

Generally looks good to me - one or two minor comments.

lib/Bitcode/Writer/BitcodeWriter.cpp
1027

Could we use the size of the record to determine whether we're in the old format or the new one? Rather than including an empty field?

lib/IR/DebugInfoMetadata.cpp
364

I wonder if this function is even needed anymore... hopefully we'll just not encounter DISubprograms for a Function that aren't attached to the same Function.

yaron.keren added a subscriber: yaron.keren.Nov 3 2015, 11:17 AM
pcc updated this revision to Diff 39110.Nov 3 2015, 1:16 PM
  • Remove function field from bitcode repr
  • Defer setSubprogram until materialized
pcc added a comment.Nov 3 2015, 1:17 PM

Adrian wrote:

Could you include your upgrade script so people can upgrade their out-of-tree testcases?

add-subprogram-attachments.sh3 KBDownload

Attached. This is basically the same as Duncan's upgrade script attached to PR23367 with a quick hack to remove function references from subprograms.

Duncan wrote:

This call is only valid if F is a definition. Otherwise it will assert. IIRC, metadata typically gets parsed *before* function bodies, so I think this could even rarely be valid?

It seems that this check is done in the verifier rather than in setSubprogram itself. (This actually makes more sense to me because it may be more convenient for a frontend to create the subprogram before generating code for the function.)

But I've done something along the lines of what you suggested in order to ensure that unmaterialized functions are verifiable. Because we always read function prototypes before metadata, I don't think we need to handle the case where the thing that the SP refers to is not a function.

I didn't look at tests... did you have an upgrade test?

Yes, see test/Bitcode/upgrade-subprogram.ll.

lib/Bitcode/Writer/BitcodeWriter.cpp
1027

We can; done.

lib/IR/DebugInfoMetadata.cpp
364

I don't think it is. If I replace this function body with just the pointer comparison the test suite still passes. But this change is pretty large as it is, so I'd prefer to make that change separately.

jevinskie added a subscriber: jevinskie.Nov 4 2015, 11:07 AM
dexonsmith edited edge metadata.Nov 5 2015, 11:52 AM
dexonsmith added a subscriber: dexonsmith.

I have a couple of minor comments below; otherwise this LGTM, as long
as you can somehow prevent the DIBuilder API changes from inserting
bugs in frontends (more below).

Closed by commit rL252219: DI: Reverse direction of subprogram -> function edge. (authored by pcc). · Explain WhyNov 5 2015, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 394 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
bindings/
go/
llvm/
2 lines
4 lines
2 lines
4 lines
2 lines
3 lines
include/
llvm/
IR/
12 lines
2 lines
63 lines
lib/
AsmParser/
15 lines
Bitcode/
Reader/
28 lines
Writer/
2 lines
CodeGen/
AsmPrinter/
8 lines
3 lines
IR/
1 line
31 lines
22 lines
27 lines
13 lines
77 lines
Linker/
50 lines
Transforms/
IPO/
13 lines
25 lines
8 lines
Instrumentation/
8 lines
18 lines
Utils/
4 lines
test/
Assembler/
4 lines
12 lines
4 lines
Bitcode/
upgrade-subprogram.ll/
Linker/
Inputs/
subprogram-linkonce-weak.ll
15 lines
Bitcode/
CodeGen/
AArch64/
4 lines
AMDGPU/
4 lines
ARM/
12 lines
20 lines
20 lines
4 lines
4 lines
2 lines
4 lines
4 lines
6 lines
12 lines
4 lines
6 lines
12 lines
4 lines
4 lines
4 lines
4 lines
Hexagon/
4 lines
4 lines
Inputs/
4 lines
MIR/
X86/
4 lines
4 lines
4 lines
4 lines
4 lines
PowerPC/
4 lines
4 lines
4 lines
4 lines
WinEH/
4 lines
X86/
4 lines
4 lines
6 lines
8 lines
6 lines
12 lines
8 lines
4 lines
8 lines
4 lines
8 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
2 lines
4 lines
2 lines
4 lines
4 lines
XCore/
4 lines
DebugInfo/
AArch64/
8 lines
4 lines
4 lines
4 lines
12 lines
4 lines
ARM/
4 lines
8 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
COFF/
4 lines
4 lines
2 lines
4 lines
12 lines
4 lines
2 lines
Generic/
4 lines
4 lines
8 lines
12 lines
4 lines
8 lines
4 lines
4 lines
4 lines
Inputs/
16 lines
12 lines
4 lines
4 lines
4 lines
4 lines
4 lines
8 lines
6 lines
4 lines
8 lines
8 lines
4 lines
4 lines
8 lines
12 lines
16 lines
8 lines
4 lines
4 lines
4 lines
8 lines
4 lines
8 lines
8 lines
4 lines
4 lines
8 lines
4 lines
4 lines
8 lines
4 lines
8 lines
4 lines
26 lines
4 lines
8 lines
4 lines
20 lines
4 lines
4 lines
8 lines
8 lines
4 lines
4 lines
4 lines
Inputs/
16 lines
4 lines
Mips/
4 lines
4 lines
4 lines
4 lines
Sparc/
4 lines
SystemZ/
8 lines
X86/
4 lines
4 lines
20 lines
4 lines
12 lines
4 lines
12 lines
4 lines
4 lines
4 lines
4 lines
8 lines
4 lines
8 lines
8 lines
4 lines
4 lines
4 lines
4 lines
10 lines
12 lines
12 lines
8 lines
4 lines
4 lines
4 lines
12 lines
4 lines
4 lines
4 lines
4 lines
8 lines
4 lines
4 lines
4 lines
8 lines
4 lines
10 lines
4 lines
4 lines
4 lines
4 lines
4 lines
8 lines
24 lines
4 lines
4 lines
4 lines
8 lines
8 lines
4 lines
18 lines
4 lines
4 lines
4 lines
12 lines
4 lines
4 lines
16 lines
4 lines
4 lines
8 lines
4 lines
4 lines
4 lines
8 lines
4 lines
4 lines
6 lines
16 lines
4 lines
24 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
8 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
8 lines
4 lines
4 lines
8 lines
4 lines
4 lines
4 lines
8 lines
12 lines
4 lines
4 lines
4 lines
12 lines
4 lines
36 lines
4 lines
4 lines
4 lines
4 lines
4 lines
8 lines
4 lines
4 lines
4 lines
8 lines
10 lines
4 lines
4 lines
4 lines
8 lines
Instrumentation/
AddressSanitizer/
4 lines
DataFlowSanitizer/
7 lines
MemorySanitizer/
4 lines
SanitizerCoverage/
4 lines
4 lines
JitListener/
12 lines
4 lines
Linker/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
Inputs/
4 lines
4 lines
4 lines
8 lines
4 lines
8 lines
21 lines
30 lines
8 lines
12 lines
4 lines
8 lines
12 lines
8 lines
8 lines
8 lines
MC/
ARM/
4 lines
ELF/
4 lines
Transforms/
AddDiscriminators/
4 lines
4 lines
4 lines
4 lines
4 lines
ArgumentPromotion/
10 lines
DeadArgElim/
11 lines
DeadStoreElimination/
4 lines
GCOVProfiling/
12 lines
6 lines
8 lines
4 lines
4 lines
4 lines
GVN/
4 lines
4 lines
Inline/
12 lines
10 lines
16 lines
8 lines
InstCombine/
4 lines
4 lines
4 lines
LoopIdiom/
4 lines
LoopReroll/
4 lines
LoopRotate/
4 lines
LoopSimplify/
4 lines
LoopUnroll/
4 lines
LoopVectorize/
X86/
8 lines
12 lines
8 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
Mem2Reg/
4 lines
4 lines
ObjCARC/
8 lines
SLPVectorizer/
X86/
4 lines
SafeStack/
4 lines
SampleProfile/
4 lines
8 lines
4 lines
4 lines
4 lines
12 lines
8 lines
8 lines
8 lines
4 lines
4 lines
8 lines
8 lines
ScalarRepl/
4 lines
Scalarizer/
4 lines
SimplifyCFG/
4 lines
4 lines
4 lines
StripSymbols/
4 lines
4 lines
8 lines
Verifier/
4 lines
tools/
dsymutil/
Inputs/
8 lines
8 lines
unittests/
IR/
8 lines
97 lines
Transforms/
Utils/
31 lines

Diff 39002

bindings/go/llvm/DIBuilderBindings.h

bindings/go/llvm/DIBuilderBindings.cpp

bindings/go/llvm/IRBindings.h

bindings/go/llvm/IRBindings.cpp

bindings/go/llvm/dibuilder.go

bindings/go/llvm/ir.go

include/llvm/IR/DIBuilder.h

include/llvm/IR/DebugInfo.h

include/llvm/IR/DebugInfoMetadata.h

lib/AsmParser/LLParser.cpp

lib/Bitcode/Reader/BitcodeReader.cpp

lib/Bitcode/Writer/BitcodeWriter.cpp

Show First 20 Lines • Show All 1,018 Lines • ▼ Show 20 Linesstatic void WriteDISubprogram(const DISubprogram *N, const ValueEnumerator &VE,
Record.push_back(N->isLocalToUnit()); Record.push_back(N->isLocalToUnit());
Record.push_back(N->isDefinition()); Record.push_back(N->isDefinition());
Record.push_back(N->getScopeLine()); Record.push_back(N->getScopeLine());
Record.push_back(VE.getMetadataOrNullID(N->getContainingType())); Record.push_back(VE.getMetadataOrNullID(N->getContainingType()));
Record.push_back(N->getVirtuality()); Record.push_back(N->getVirtuality());
Record.push_back(N->getVirtualIndex()); Record.push_back(N->getVirtualIndex());
Record.push_back(N->getFlags()); Record.push_back(N->getFlags());
Record.push_back(N->isOptimized()); Record.push_back(N->isOptimized());
Record.push_back(VE.getMetadataOrNullID(N->getRawFunction())); Record.push_back(0);
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Could we use the size of the record to determine whether we're in the old format or the new one? Rather than including an empty field?

dblaikie: Could we use the size of the record to determine whether we're in the old format or the new one?
pccAuthorUnsubmitted
Not Done
ReplyInline Actions

We can; done.

pcc: We can; done.
Record.push_back(VE.getMetadataOrNullID(N->getTemplateParams().get())); Record.push_back(VE.getMetadataOrNullID(N->getTemplateParams().get()));
Record.push_back(VE.getMetadataOrNullID(N->getDeclaration())); Record.push_back(VE.getMetadataOrNullID(N->getDeclaration()));
Record.push_back(VE.getMetadataOrNullID(N->getVariables().get())); Record.push_back(VE.getMetadataOrNullID(N->getVariables().get()));
Stream.EmitRecord(bitc::METADATA_SUBPROGRAM, Record, Abbrev); Stream.EmitRecord(bitc::METADATA_SUBPROGRAM, Record, Abbrev);
Record.clear(); Record.clear();
} }
▲ Show 20 Lines • Show All 2,046 Lines • Show Last 20 Lines

lib/CodeGen/AsmPrinter/DwarfDebug.cpp

lib/CodeGen/LiveDebugVariables.cpp

lib/IR/AsmWriter.cpp

lib/IR/DIBuilder.cpp

lib/IR/DebugInfo.cpp

lib/IR/DebugInfoMetadata.cpp

Show First 20 Lines • Show All 336 Lines • ▼ Show 20 LinesDISubprogram *DILocalScope::getSubprogram() const {
return const_cast<DISubprogram *>(cast<DISubprogram>(this)); return const_cast<DISubprogram *>(cast<DISubprogram>(this));
} }
DISubprogram *DISubprogram::getImpl( DISubprogram *DISubprogram::getImpl(
LLVMContext &Context, Metadata *Scope, MDString *Name, LLVMContext &Context, Metadata *Scope, MDString *Name,
MDString *LinkageName, Metadata *File, unsigned Line, Metadata *Type, MDString *LinkageName, Metadata *File, unsigned Line, Metadata *Type,
bool IsLocalToUnit, bool IsDefinition, unsigned ScopeLine, bool IsLocalToUnit, bool IsDefinition, unsigned ScopeLine,
Metadata *ContainingType, unsigned Virtuality, unsigned VirtualIndex, Metadata *ContainingType, unsigned Virtuality, unsigned VirtualIndex,
unsigned Flags, bool IsOptimized, Metadata *Function, unsigned Flags, bool IsOptimized, Metadata *TemplateParams,
Metadata *TemplateParams, Metadata *Declaration, Metadata *Variables, Metadata *Declaration, Metadata *Variables, StorageType Storage,
StorageType Storage, bool ShouldCreate) { bool ShouldCreate) {
assert(isCanonical(Name) && "Expected canonical MDString"); assert(isCanonical(Name) && "Expected canonical MDString");
assert(isCanonical(LinkageName) && "Expected canonical MDString"); assert(isCanonical(LinkageName) && "Expected canonical MDString");
DEFINE_GETIMPL_LOOKUP(DISubprogram, DEFINE_GETIMPL_LOOKUP(DISubprogram,
(Scope, getString(Name), getString(LinkageName), File, (Scope, getString(Name), getString(LinkageName), File,
Line, Type, IsLocalToUnit, IsDefinition, ScopeLine, Line, Type, IsLocalToUnit, IsDefinition, ScopeLine,
ContainingType, Virtuality, VirtualIndex, Flags, ContainingType, Virtuality, VirtualIndex, Flags,
IsOptimized, Function, TemplateParams, Declaration, IsOptimized, TemplateParams, Declaration, Variables));
Variables));
Metadata *Ops[] = {File, Scope, Name, Name, Metadata *Ops[] = {File, Scope, Name, Name,
LinkageName, Type, ContainingType, Function, LinkageName, Type, ContainingType, TemplateParams,
TemplateParams, Declaration, Variables}; Declaration, Variables};
DEFINE_GETIMPL_STORE(DISubprogram, DEFINE_GETIMPL_STORE(DISubprogram,
(Line, ScopeLine, Virtuality, VirtualIndex, Flags, (Line, ScopeLine, Virtuality, VirtualIndex, Flags,
IsLocalToUnit, IsDefinition, IsOptimized), IsLocalToUnit, IsDefinition, IsOptimized),
Ops); Ops);
} }
Function *DISubprogram::getFunction() const {
// FIXME: Should this be looking through bitcasts?
return dyn_cast_or_null<Function>(getFunctionConstant());
}
bool DISubprogram::describes(const Function *F) const { bool DISubprogram::describes(const Function *F) const {
dblaikieUnsubmitted
Not Done
ReplyInline Actions

I wonder if this function is even needed anymore... hopefully we'll just not encounter DISubprograms for a Function that aren't attached to the same Function.

dblaikie: I wonder if this function is even needed anymore... hopefully we'll just not encounter…
pccAuthorUnsubmitted
Not Done
ReplyInline Actions

I don't think it is. If I replace this function body with just the pointer comparison the test suite still passes. But this change is pretty large as it is, so I'd prefer to make that change separately.

pcc: I don't think it is. If I replace this function body with just the pointer comparison the test…
assert(F && "Invalid function"); assert(F && "Invalid function");
if (F == getFunction()) if (F->getSubprogram() == this)
return true; return true;
StringRef Name = getLinkageName(); StringRef Name = getLinkageName();
if (Name.empty()) if (Name.empty())
Name = getName(); Name = getName();
return F->getName() == Name; return F->getName() == Name;
} }
void DISubprogram::replaceFunction(Function *F) {
replaceFunction(F ? ConstantAsMetadata::get(F)
: static_cast<ConstantAsMetadata *>(nullptr));
}
DILexicalBlock *DILexicalBlock::getImpl(LLVMContext &Context, Metadata *Scope, DILexicalBlock *DILexicalBlock::getImpl(LLVMContext &Context, Metadata *Scope,
Metadata *File, unsigned Line, Metadata *File, unsigned Line,
unsigned Column, StorageType Storage, unsigned Column, StorageType Storage,
bool ShouldCreate) { bool ShouldCreate) {
// Fixup column. // Fixup column.
adjustColumn(Column); adjustColumn(Column);
assert(Scope && "Expected scope"); assert(Scope && "Expected scope");
▲ Show 20 Lines • Show All 178 Lines • Show Last 20 Lines

lib/IR/LLVMContextImpl.h

lib/IR/Verifier.cpp

lib/Linker/LinkModules.cpp

lib/Transforms/IPO/ArgumentPromotion.cpp

lib/Transforms/IPO/DeadArgumentElimination.cpp

lib/Transforms/IPO/StripSymbols.cpp

lib/Transforms/Instrumentation/DataFlowSanitizer.cpp

lib/Transforms/Instrumentation/GCOVProfiling.cpp

lib/Transforms/Utils/CloneFunction.cpp

test/Assembler/2010-02-05-FunctionLocalMetadataBecomesNull.ll

test/Assembler/disubprogram.ll

test/Assembler/drop-debug-info.ll

test/Bitcode/upgrade-subprogram.ll

test/Bitcode/upgrade-subprogram.ll.bc

test/CodeGen/AArch64/aarch64-2014-08-11-MachineCombinerCrash.ll

test/CodeGen/AMDGPU/llvm.dbg.value.ll

test/CodeGen/ARM/2010-08-04-StackVariable.ll

test/CodeGen/ARM/2011-01-19-MergedGlobalDbg.ll

test/CodeGen/ARM/2011-08-02-MergedGlobalDbg.ll

test/CodeGen/ARM/coalesce-dbgvalue.ll

test/CodeGen/ARM/debug-frame-vararg.ll

test/CodeGen/ARM/debug-frame.ll

test/CodeGen/ARM/debug-info-arg.ll

test/CodeGen/ARM/debug-info-blocks.ll

test/CodeGen/ARM/debug-info-branch-folding.ll

test/CodeGen/ARM/debug-info-d16-reg.ll

test/CodeGen/ARM/debug-info-no-frame.ll

test/CodeGen/ARM/debug-info-qreg.ll

test/CodeGen/ARM/debug-info-s16-reg.ll

test/CodeGen/ARM/debug-info-sreg2.ll

test/CodeGen/ARM/debug-segmented-stacks.ll

test/CodeGen/ARM/sched-it-debug-nodes.ll

test/CodeGen/ARM/vfp-regs-dwarf.ll

test/CodeGen/Hexagon/cfi-late.ll

test/CodeGen/Hexagon/hwloop-dbg.ll

test/CodeGen/Inputs/DbgValueOtherTargets.ll

test/CodeGen/MIR/X86/expected-metadata-node-after-debug-location.mir

test/CodeGen/MIR/X86/expected-metadata-node-after-exclaim.mir

test/CodeGen/MIR/X86/instructions-debug-location.mir

test/CodeGen/MIR/X86/metadata-operands.mir

test/CodeGen/MIR/X86/unknown-metadata-node.mir

test/CodeGen/PowerPC/dbg.ll

test/CodeGen/PowerPC/pr17168.ll

test/CodeGen/PowerPC/pr24546.ll

test/CodeGen/PowerPC/unwind-dw2-g.ll

test/CodeGen/WinEH/wineh-cloning.ll

test/CodeGen/X86/2010-01-18-DbgValue.ll

test/CodeGen/X86/2010-05-25-DotDebugLoc.ll

test/CodeGen/X86/2010-05-26-DotDebugLoc.ll

test/CodeGen/X86/2010-05-28-Crash.ll

test/CodeGen/X86/2010-06-01-DeadArg-DbgInfo.ll

test/CodeGen/X86/2010-08-04-StackVariable.ll

test/CodeGen/X86/2010-09-16-EmptyFilename.ll

test/CodeGen/X86/2010-11-02-DbgParameter.ll

test/CodeGen/X86/2011-01-24-DbgValue-Before-Use.ll

test/CodeGen/X86/2012-11-30-handlemove-dbg.ll

test/CodeGen/X86/2012-11-30-misched-dbg.ll

test/CodeGen/X86/2012-11-30-regpres-dbg.ll

test/CodeGen/X86/MachineSink-DbgValue.ll

test/CodeGen/X86/dbg-changes-codegen-branch-folding.ll

test/CodeGen/X86/dbg-combine.ll

test/CodeGen/X86/debugloc-argsize.ll

test/CodeGen/X86/fpstack-debuginstr-kill.ll

test/CodeGen/X86/machine-trace-metrics-crash.ll

test/CodeGen/X86/misched-code-difference-with-debug.ll

test/CodeGen/X86/null-streamer.ll

test/CodeGen/X86/stack-protector-dbginfo.ll

test/CodeGen/X86/unknown-location.ll

test/CodeGen/XCore/dwarf_debug.ll

test/DebugInfo/AArch64/cfi-eof-prologue.ll

test/DebugInfo/AArch64/coalescing.ll

test/DebugInfo/AArch64/constant-dbgloc.ll

test/DebugInfo/AArch64/dwarfdump.ll

test/DebugInfo/AArch64/frameindices.ll

test/DebugInfo/AArch64/struct_by_value.ll

test/DebugInfo/ARM/PR16736.ll

test/DebugInfo/ARM/cfi-eof-prologue.ll

test/DebugInfo/ARM/constant-dbgloc.ll

test/DebugInfo/ARM/float-args.ll

test/DebugInfo/ARM/header.ll

test/DebugInfo/ARM/lowerbdgdeclare_vla.ll

test/DebugInfo/ARM/multiple-constant-uses-drops-dbgloc.ll

test/DebugInfo/ARM/s-super-register.ll

test/DebugInfo/ARM/selectiondag-deadcode.ll

test/DebugInfo/ARM/single-constant-use-preserves-dbgloc.ll

test/DebugInfo/COFF/asan-module-ctor.ll

test/DebugInfo/COFF/asm.ll

test/DebugInfo/COFF/cpp-mangling.ll

test/DebugInfo/COFF/multifile.ll

test/DebugInfo/COFF/multifunction.ll

test/DebugInfo/COFF/simple.ll

test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll

test/DebugInfo/Generic/2009-11-05-DeadGlobalVariable.ll

test/DebugInfo/Generic/2009-11-10-CurrentFn.ll

test/DebugInfo/Generic/2010-03-24-MemberFn.ll

test/DebugInfo/Generic/2010-04-06-NestedFnDbgInfo.ll

test/DebugInfo/Generic/2010-04-19-FramePtr.ll

test/DebugInfo/Generic/2010-05-10-MultipleCU.ll

test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll

test/DebugInfo/Generic/2010-07-19-Crash.ll

test/DebugInfo/Generic/2010-10-01-crash.ll

test/DebugInfo/Generic/Inputs/gmlt.ll

test/DebugInfo/Generic/PR20038.ll

test/DebugInfo/Generic/array.ll

test/DebugInfo/Generic/block-asan.ll

test/DebugInfo/Generic/constant-pointers.ll

test/DebugInfo/Generic/constant-sdnodes-have-dbg-location.ll

test/DebugInfo/Generic/constantfp-sdnodes-have-dbg-location.ll

test/DebugInfo/Generic/cross-cu-inlining.ll

test/DebugInfo/Generic/cross-cu-linkonce-distinct.ll

test/DebugInfo/Generic/cross-cu-linkonce.ll

test/DebugInfo/Generic/cu-range-hole.ll

test/DebugInfo/Generic/cu-ranges.ll

test/DebugInfo/Generic/dead-argument-order.ll

test/DebugInfo/Generic/debug-info-qualifiers.ll

test/DebugInfo/Generic/debuginfofinder-multiple-cu.ll

test/DebugInfo/Generic/def-line.ll

test/DebugInfo/Generic/dwarf-public-names.ll

test/DebugInfo/Generic/enum-types.ll

test/DebugInfo/Generic/enum.ll

test/DebugInfo/Generic/global.ll

test/DebugInfo/Generic/gvn.ll

test/DebugInfo/Generic/incorrect-variable-debugloc.ll

test/DebugInfo/Generic/incorrect-variable-debugloc1.ll

test/DebugInfo/Generic/inline-debug-info-multiret.ll

test/DebugInfo/Generic/inline-debug-info.ll

test/DebugInfo/Generic/inline-no-debug-info.ll

test/DebugInfo/Generic/inline-scopes.ll

test/DebugInfo/Generic/inlined-arguments.ll

test/DebugInfo/Generic/inlined-vars.ll

test/DebugInfo/Generic/location-verifier.ll

test/DebugInfo/Generic/lto-comp-dir.ll

test/DebugInfo/Generic/member-order.ll

test/DebugInfo/Generic/missing-abstract-variable.ll

test/DebugInfo/Generic/multiline.ll

test/DebugInfo/Generic/namespace.ll

test/DebugInfo/Generic/namespace_function_definition.ll

test/DebugInfo/Generic/namespace_inline_function_definition.ll

test/DebugInfo/Generic/piece-verifier.ll

test/DebugInfo/Generic/recursive_inlining.ll

test/DebugInfo/Generic/restrict.ll

test/DebugInfo/Generic/sugared-constants.ll

test/DebugInfo/Generic/tu-composite.ll

test/DebugInfo/Generic/two-cus-from-same-file.ll

test/DebugInfo/Generic/unconditional-branch.ll

test/DebugInfo/Generic/varargs.ll

test/DebugInfo/Generic/version.ll

test/DebugInfo/Inputs/gmlt.ll

test/DebugInfo/Inputs/line.ll

test/DebugInfo/Mips/InlinedFnLocalVar.ll

test/DebugInfo/Mips/delay-slot.ll

test/DebugInfo/Mips/fn-call-line.ll

test/DebugInfo/Mips/prologue_end.ll

test/DebugInfo/Sparc/gnu-window-save.ll

test/DebugInfo/SystemZ/variable-loc.ll

test/DebugInfo/X86/2010-04-13-PubType.ll

test/DebugInfo/X86/2011-09-26-GlobalVarContext.ll

test/DebugInfo/X86/2011-12-16-BadStructRef.ll

test/DebugInfo/X86/DW_AT_byte_size.ll

test/DebugInfo/X86/DW_AT_linkage_name.ll

test/DebugInfo/X86/DW_AT_location-reference.ll

test/DebugInfo/X86/DW_AT_object_pointer.ll

test/DebugInfo/X86/DW_AT_specification.ll

test/DebugInfo/X86/DW_AT_stmt_list_sec_offset.ll

test/DebugInfo/X86/InlinedFnLocalVar.ll

test/DebugInfo/X86/aligned_stack_var.ll

test/DebugInfo/X86/arange-and-stub.ll

test/DebugInfo/X86/arguments.ll

test/DebugInfo/X86/array.ll

test/DebugInfo/X86/array2.ll

test/DebugInfo/X86/block-capture.ll

test/DebugInfo/X86/byvalstruct.ll

test/DebugInfo/X86/coff_debug_info_type.ll

test/DebugInfo/X86/coff_relative_names.ll

test/DebugInfo/X86/concrete_out_of_line.ll

test/DebugInfo/X86/constant-aggregate.ll

test/DebugInfo/X86/cu-ranges-odr.ll

test/DebugInfo/X86/cu-ranges.ll

test/DebugInfo/X86/dbg-byval-parameter.ll

test/DebugInfo/X86/dbg-const-int.ll

test/DebugInfo/X86/dbg-const.ll

test/DebugInfo/X86/dbg-declare-arg.ll

test/DebugInfo/X86/dbg-declare.ll

test/DebugInfo/X86/dbg-file-name.ll

test/DebugInfo/X86/dbg-i128-const.ll

test/DebugInfo/X86/dbg-merge-loc-entry.ll

test/DebugInfo/X86/dbg-prolog-end.ll

test/DebugInfo/X86/dbg-subrange.ll

test/DebugInfo/X86/dbg-value-const-byref.ll

test/DebugInfo/X86/dbg-value-dag-combine.ll

test/DebugInfo/X86/dbg-value-inlined-parameter.ll

test/DebugInfo/X86/dbg-value-isel.ll

test/DebugInfo/X86/dbg-value-location.ll

test/DebugInfo/X86/dbg-value-range.ll

test/DebugInfo/X86/dbg-value-terminator.ll

test/DebugInfo/X86/dbg_value_direct.ll

test/DebugInfo/X86/debug-dead-local-var.ll

test/DebugInfo/X86/debug-info-access.ll

test/DebugInfo/X86/debug-info-block-captured-self.ll

test/DebugInfo/X86/debug-info-blocks.ll

test/DebugInfo/X86/debug-info-static-member.ll

test/DebugInfo/X86/debug-loc-asan.ll

test/DebugInfo/X86/debug-loc-empty-entries.ll

test/DebugInfo/X86/debug-loc-offset.ll

test/DebugInfo/X86/debug-ranges-offset.ll

test/DebugInfo/X86/debug_frame.ll

test/DebugInfo/X86/decl-derived-member.ll

test/DebugInfo/X86/deleted-bit-piece.ll

test/DebugInfo/X86/discriminator.ll

test/DebugInfo/X86/dw_op_minus.ll

test/DebugInfo/X86/dwarf-aranges-no-dwarf-labels.ll

test/DebugInfo/X86/dwarf-aranges.ll

test/DebugInfo/X86/dwarf-linkage-names.ll

test/DebugInfo/X86/dwarf-public-names.ll

test/DebugInfo/X86/dwarf-pubnames-split.ll

test/DebugInfo/X86/earlydup-crash.ll

test/DebugInfo/X86/elf-names.ll

test/DebugInfo/X86/empty-and-one-elem-array.ll

test/DebugInfo/X86/ending-run.ll

test/DebugInfo/X86/fission-inline.ll

test/DebugInfo/X86/fission-ranges.ll

test/DebugInfo/X86/float_const.ll

test/DebugInfo/X86/formal_parameter.ll

test/DebugInfo/X86/frame-register.ll

test/DebugInfo/X86/generate-odr-hash.ll

test/DebugInfo/X86/ghost-sdnode-dbgvalues.ll

test/DebugInfo/X86/gnu-public-names.ll

test/DebugInfo/X86/header.ll

test/DebugInfo/X86/inline-member-function.ll

test/DebugInfo/X86/inline-seldag-test.ll

test/DebugInfo/X86/inlined-formal-parameter.ll

test/DebugInfo/X86/inlined-indirect-value.ll

test/DebugInfo/X86/instcombine-instrinsics.ll

test/DebugInfo/X86/lexical_block.ll

test/DebugInfo/X86/line-info.ll

test/DebugInfo/X86/linkage-name.ll

test/DebugInfo/X86/low-pc-cu.ll

test/DebugInfo/X86/mi-print.ll

test/DebugInfo/X86/misched-dbg-value.ll

test/DebugInfo/X86/missing-file-line.ll

test/DebugInfo/X86/multiple-at-const-val.ll

test/DebugInfo/X86/nophysreg.ll

test/DebugInfo/X86/objc-property-void.ll

test/DebugInfo/X86/op_deref.ll

test/DebugInfo/X86/parameters.ll

test/DebugInfo/X86/pieces-1.ll

test/DebugInfo/X86/pieces-2.ll

test/DebugInfo/X86/pieces-3.ll

test/DebugInfo/X86/pr11300.ll

test/DebugInfo/X86/pr12831.ll

test/DebugInfo/X86/pr13303.ll

test/DebugInfo/X86/pr19307.ll

test/DebugInfo/X86/prologue-stack.ll

test/DebugInfo/X86/reference-argument.ll

test/DebugInfo/X86/rvalue-ref.ll

test/DebugInfo/X86/sret.ll

test/DebugInfo/X86/sroasplit-1.ll

test/DebugInfo/X86/sroasplit-2.ll

test/DebugInfo/X86/sroasplit-3.ll

test/DebugInfo/X86/sroasplit-4.ll

test/DebugInfo/X86/sroasplit-5.ll

test/DebugInfo/X86/stmt-list-multiple-compile-units.ll

test/DebugInfo/X86/stmt-list.ll

test/DebugInfo/X86/subrange-type.ll

test/DebugInfo/X86/subreg.ll

test/DebugInfo/X86/subregisters.ll

test/DebugInfo/X86/template.ll

test/DebugInfo/X86/tls.ll

test/DebugInfo/X86/union-const.ll

test/DebugInfo/X86/union-template.ll

test/DebugInfo/X86/vla.ll

test/Instrumentation/AddressSanitizer/debug_info.ll

test/Instrumentation/DataFlowSanitizer/debug.ll

test/Instrumentation/MemorySanitizer/store-origin.ll

test/Instrumentation/SanitizerCoverage/coverage-dbg.ll

test/Instrumentation/SanitizerCoverage/coverage2-dbg.ll

test/JitListener/multiple.ll

test/JitListener/simple.ll

test/Linker/2011-08-04-DebugLoc.ll

test/Linker/2011-08-04-DebugLoc2.ll

test/Linker/2011-08-04-Metadata.ll

test/Linker/2011-08-04-Metadata2.ll

test/Linker/2011-08-18-unique-class-type.ll

test/Linker/2011-08-18-unique-class-type2.ll

test/Linker/2011-08-18-unique-debug-type.ll

test/Linker/2011-08-18-unique-debug-type2.ll

test/Linker/DbgDeclare.ll

test/Linker/DbgDeclare2.ll

test/Linker/Inputs/replaced-function-matches-first-subprogram.ll

test/Linker/Inputs/subprogram-linkonce-weak.ll

test/Linker/Inputs/type-unique-inheritance-a.ll

test/Linker/Inputs/type-unique-inheritance-b.ll

test/Linker/Inputs/type-unique-simple2-a.ll

test/Linker/Inputs/type-unique-simple2-b.ll

test/Linker/replaced-function-matches-first-subprogram.ll

test/Linker/subprogram-linkonce-weak.ll

test/Linker/type-unique-odr-a.ll

test/Linker/type-unique-odr-b.ll

test/Linker/type-unique-simple-a.ll

test/Linker/type-unique-simple-b.ll

test/Linker/type-unique-simple2-a.ll

test/Linker/type-unique-simple2-b.ll

test/Linker/type-unique-type-array-a.ll

test/Linker/type-unique-type-array-b.ll

test/MC/ARM/coff-debugging-secrel.ll

test/MC/ELF/cfi-version.ll

test/Transforms/AddDiscriminators/basic.ll

test/Transforms/AddDiscriminators/first-only.ll

test/Transforms/AddDiscriminators/multiple.ll

test/Transforms/AddDiscriminators/no-discriminators.ll

test/Transforms/AddDiscriminators/oneline.ll

test/Transforms/ArgumentPromotion/dbg.ll

test/Transforms/DeadArgElim/dbginfo.ll

test/Transforms/DeadStoreElimination/inst-limits.ll

test/Transforms/GCOVProfiling/function-numbering.ll

test/Transforms/GCOVProfiling/global-ctor.ll

test/Transforms/GCOVProfiling/linezero.ll

test/Transforms/GCOVProfiling/linkagename.ll

test/Transforms/GCOVProfiling/return-block.ll

test/Transforms/GCOVProfiling/version.ll

test/Transforms/GVN/load-pre-nonlocal.ll

test/Transforms/GVN/phi-translate.ll

test/Transforms/Inline/alloca-dbgdeclare-merge.ll

test/Transforms/Inline/alloca-dbgdeclare.ll

test/Transforms/Inline/debug-info-duplicate-calls.ll

test/Transforms/Inline/inline_dbg_declare.ll

test/Transforms/InstCombine/debug-line.ll

test/Transforms/InstCombine/debuginfo.ll

test/Transforms/InstCombine/lifetime.ll

test/Transforms/LoopIdiom/debug-line.ll

test/Transforms/LoopReroll/reroll_with_dbg.ll

test/Transforms/LoopRotate/dbgvalue.ll

test/Transforms/LoopSimplify/dbg-loc.ll

test/Transforms/LoopUnroll/runtime-loop1.ll

test/Transforms/LoopVectorize/X86/no_fpmath.ll

test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll

test/Transforms/LoopVectorize/X86/vectorization-remarks-profitable.ll

test/Transforms/LoopVectorize/X86/vectorization-remarks.ll

test/Transforms/LoopVectorize/conditional-assignment.ll

test/Transforms/LoopVectorize/control-flow.ll

test/Transforms/LoopVectorize/dbg.value.ll

test/Transforms/LoopVectorize/debugloc.ll

test/Transforms/LoopVectorize/no_array_bounds.ll

test/Transforms/LoopVectorize/no_switch.ll

test/Transforms/Mem2Reg/ConvertDebugInfo.ll

test/Transforms/Mem2Reg/ConvertDebugInfo2.ll

test/Transforms/ObjCARC/ensure-that-exception-unwind-path-is-visited.ll

test/Transforms/SLPVectorizer/X86/debug_info.ll

test/Transforms/SafeStack/debug-loc.ll

test/Transforms/SampleProfile/branch.ll

test/Transforms/SampleProfile/calls.ll

test/Transforms/SampleProfile/coverage-warning.ll

test/Transforms/SampleProfile/discriminator.ll

test/Transforms/SampleProfile/entry_counts.ll

test/Transforms/SampleProfile/fnptr.ll

test/Transforms/SampleProfile/gcc-simple.ll

test/Transforms/SampleProfile/inline-coverage.ll

test/Transforms/SampleProfile/inline.ll

test/Transforms/SampleProfile/nolocinfo.ll

test/Transforms/SampleProfile/offset.ll

test/Transforms/SampleProfile/propagate.ll

test/Transforms/SampleProfile/remarks.ll

test/Transforms/ScalarRepl/debuginfo-preserved.ll

test/Transforms/Scalarizer/dbginfo.ll

test/Transforms/SimplifyCFG/branch-fold-dbg.ll

test/Transforms/SimplifyCFG/hoist-dbgvalue.ll

test/Transforms/SimplifyCFG/trap-debugloc.ll

test/Transforms/StripSymbols/2010-06-30-StripDebug.ll

test/Transforms/StripSymbols/2010-08-25-crash.ll

test/Transforms/StripSymbols/strip-dead-debug-info.ll

test/Verifier/metadata-function-dbg.ll

test/tools/dsymutil/Inputs/frame-dw2.ll

test/tools/dsymutil/Inputs/frame-dw4.ll

unittests/IR/IRBuilderTest.cpp

unittests/IR/MetadataTest.cpp

unittests/Transforms/Utils/Cloning.cpp