axw (Andrew Wilkins)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 19 2014, 4:11 PM (204 w, 1 d)

Recent Activity

Dec 27 2017

axw committed rL321509: [bindings/go] fix vet errors.
[bindings/go] fix vet errors
Dec 27 2017, 8:11 PM

Jul 10 2017

axw committed rL307607: [cmake] Check for Haiku when setting LIB_NAMES for GNU ld.
[cmake] Check for Haiku when setting LIB_NAMES for GNU ld
Jul 10 2017, 6:18 PM
axw closed D34998: Check for Haiku when setting LIB_NAMES for GNU ld by committing rL307607: [cmake] Check for Haiku when setting LIB_NAMES for GNU ld.
Jul 10 2017, 6:18 PM

Jul 6 2017

axw accepted D34998: Check for Haiku when setting LIB_NAMES for GNU ld.
Jul 6 2017, 7:38 PM

Jun 8 2017

axw committed rL304968: [Go] Subtypes function.
[Go] Subtypes function
Jun 8 2017, 12:33 AM
axw closed D33901: [Go] Subtypes function by committing rL304968: [Go] Subtypes function.
Jun 8 2017, 12:33 AM
axw accepted D33901: [Go] Subtypes function.

Thank you, I'll submit this shortly.

Jun 8 2017, 12:28 AM

Jun 7 2017

axw added a comment to D33901: [Go] Subtypes function.

Sorry, I shouldn't really have said *suggest*. Can you please rename GetSubtypes to Subtypes? GetFoo is not idiomatic in Go (there are some instances of GetFoo in the existing code, but they're stuck like that until someone decides to break compatibility).

Jun 7 2017, 5:50 AM

Jun 6 2017

axw requested changes to D33901: [Go] Subtypes function.

Code looks fine, and thanks for adding a test. I just think this one should be a method rather than a free function.

Jun 6 2017, 5:21 PM

Mar 30 2017

axw committed rL299185: Go binding: Add GetCurrentDebugLocation to obtain debug location from builder.
Go binding: Add GetCurrentDebugLocation to obtain debug location from builder
Mar 30 2017, 10:12 PM
axw closed D31415: Go binding: Add GetCurrentDebugLocation to obtain debug location from builder by committing rL299185: Go binding: Add GetCurrentDebugLocation to obtain debug location from builder.
Mar 30 2017, 10:12 PM
axw accepted D31415: Go binding: Add GetCurrentDebugLocation to obtain debug location from builder.

Thanks.

Mar 30 2017, 10:10 PM

Mar 29 2017

axw requested changes to D31415: Go binding: Add GetCurrentDebugLocation to obtain debug location from builder.

Actually, I've just run the tests and it's asserting:

Mar 29 2017, 7:29 PM
axw accepted D31415: Go binding: Add GetCurrentDebugLocation to obtain debug location from builder.

LGTM

Mar 29 2017, 5:24 PM

Mar 25 2017

axw added a comment to D28215: Add check for BSD when setting LIB_NAMES for GNU ld.

Thanks for taking a look at this, @axw. Is there anything else that needs to happen before this can be merged?

Mar 25 2017, 11:11 PM
axw committed rL298798: Add check for BSD when setting LIB_NAMES for GNU ld.
Add check for BSD when setting LIB_NAMES for GNU ld
Mar 25 2017, 11:11 PM
axw closed D28215: Add check for BSD when setting LIB_NAMES for GNU ld by committing rL298798: Add check for BSD when setting LIB_NAMES for GNU ld.
Mar 25 2017, 11:11 PM

Feb 16 2017

axw added a comment to D30042: Go binding: Add methods for missing PassManagerBuilder C APIs.

Thank you for your review and approve. I don't have a permission to commit. Could you please commit this patch to repository?

Feb 16 2017, 9:53 PM
axw committed rL295420: Go binding: Add methods for missing PassManagerBuilder C APIs.
Go binding: Add methods for missing PassManagerBuilder C APIs
Feb 16 2017, 9:52 PM
axw closed D30042: Go binding: Add methods for missing PassManagerBuilder C APIs by committing rL295420: Go binding: Add methods for missing PassManagerBuilder C APIs.
Feb 16 2017, 9:52 PM
axw accepted D30042: Go binding: Add methods for missing PassManagerBuilder C APIs.

LGTM, thanks.

Feb 16 2017, 5:08 PM

Jan 15 2017

axw accepted D28215: Add check for BSD when setting LIB_NAMES for GNU ld.
Jan 15 2017, 4:03 PM

Dec 11 2016

axw accepted D27393: [llvm-config] Fix bug where `--libfiles` and `--names` would produce incorrect output.

Sorry for the delay.

Dec 11 2016, 11:23 PM

Dec 5 2016

axw committed rL288772: [llgo] set debuglocs for calls in synthetic functions.
[llgo] set debuglocs for calls in synthetic functions
Dec 5 2016, 9:49 PM
axw closed D22905: [llgo] set debuglocs for calls in synthetic functions by committing rL288772: [llgo] set debuglocs for calls in synthetic functions.
Dec 5 2016, 9:49 PM

Nov 15 2016

axw accepted D26339: Update go binding to use the new attribute API.

LGTM, sorry for the delay.

Nov 15 2016, 3:24 PM

Oct 23 2016

axw accepted D25865: Fix llvm-shlib cmake build.
Oct 23 2016, 10:26 PM
axw added a comment to D25865: Fix llvm-shlib cmake build.

Couple of little things, LGTM otherwise.

Oct 23 2016, 6:37 PM

Aug 24 2016

axw accepted D23755: [cmake] Use separate doctrees to prevent races between Sphinx instances .

LGTM

Aug 24 2016, 10:52 PM
axw accepted D23832: cmake: Add ordering dep between HTML Sphinx docs and manpages.

LGTM

Aug 24 2016, 10:52 PM

Jul 28 2016

axw retitled D22905: [llgo] set debuglocs for calls in synthetic functions from to [llgo] set debuglocs for calls in synthetic functions.
Jul 28 2016, 1:38 AM

Jul 26 2016

axw committed rL276829: [llvm-go] parameterize $GOPATH construction.
[llvm-go] parameterize $GOPATH construction
Jul 26 2016, 8:29 PM
axw closed D21634: [llvm-go] parameterize $GOPATH construction.
Jul 26 2016, 8:29 PM
axw committed rL276828: [llgo] add llgo source path to LLVM_GO_PACKAGES.
[llgo] add llgo source path to LLVM_GO_PACKAGES
Jul 26 2016, 8:08 PM
axw closed D21635: [llgo] add llgo source path to LLVM_GO_PACKAGES.
Jul 26 2016, 8:08 PM
axw added a comment to D21634: [llvm-go] parameterize $GOPATH construction.

@pcc ping?

Jul 26 2016, 7:53 PM
axw added a comment to D21635: [llgo] add llgo source path to LLVM_GO_PACKAGES.

@pcc ping?

Jul 26 2016, 7:52 PM

Jun 22 2016

axw added a dependency for D21635: [llgo] add llgo source path to LLVM_GO_PACKAGES: D21634: [llvm-go] parameterize $GOPATH construction.
Jun 22 2016, 10:52 PM
axw added a dependent revision for D21634: [llvm-go] parameterize $GOPATH construction: D21635: [llgo] add llgo source path to LLVM_GO_PACKAGES.
Jun 22 2016, 10:52 PM
axw retitled D21635: [llgo] add llgo source path to LLVM_GO_PACKAGES from to [llgo] add llgo source path to LLVM_GO_PACKAGES.
Jun 22 2016, 10:51 PM
axw retitled D21634: [llvm-go] parameterize $GOPATH construction from to [llvm-go] parameterize $GOPATH construction.
Jun 22 2016, 10:49 PM

Apr 24 2016

axw committed rL267374: [llgo] llgoi: separate evaluation from printing.
[llgo] llgoi: separate evaluation from printing
Apr 24 2016, 6:24 PM
axw closed D13761: [llgo] llgoi: separate evaluation from printing.
Apr 24 2016, 6:24 PM

Apr 22 2016

axw added a comment to D13761: [llgo] llgoi: separate evaluation from printing.

@pcc PTAL. Sorry for leaving this for so long.

Apr 22 2016, 3:01 AM
axw updated the diff for D13761: [llgo] llgoi: separate evaluation from printing.

Addressed review comments

  • removed source printing flag
  • moved __llgoiResults extraction to interpretLine
  • replaced existing CHECKs in lit tests
Apr 22 2016, 3:01 AM

Mar 29 2016

axw committed rL264815: [llgo] add USES_TERMINAL option to check-libgo.
[llgo] add USES_TERMINAL option to check-libgo
Mar 29 2016, 5:34 PM
axw closed D9495: [llgo] add USES_TERMINAL option to check-libgo by committing rL264815: [llgo] add USES_TERMINAL option to check-libgo.
Mar 29 2016, 5:34 PM
axw added a comment to D9495: [llgo] add USES_TERMINAL option to check-libgo.

Ping.

Mar 29 2016, 5:32 PM

Mar 23 2016

axw added a comment to D18355: [llgo] Increment "Debug Info Version".
In D18355#380939, @axw wrote:

LGTM, thanks. One of these days we should expose llvm::DEBUG_METADATA_VERSION to the C API.

I don't have commit access to LLVM yet (this is my first patch ever). Could you commit it for me?

Mar 23 2016, 4:15 PM
axw committed rL264212: [llgo] Increment "Debug Info Version".
[llgo] Increment "Debug Info Version"
Mar 23 2016, 4:14 PM
axw closed D18355: [llgo] Increment "Debug Info Version" by committing rL264212: [llgo] Increment "Debug Info Version".
Mar 23 2016, 4:14 PM
axw committed rL264153: [cmake] fix libgo-llgo paths in install target.
[cmake] fix libgo-llgo paths in install target
Mar 23 2016, 5:47 AM

Mar 22 2016

axw accepted D18355: [llgo] Increment "Debug Info Version".

LGTM, thanks. One of these days we should expose llvm::DEBUG_METADATA_VERSION to the C API.

Mar 22 2016, 3:50 PM

Mar 14 2016

axw added a comment to D9495: [llgo] add USES_TERMINAL option to check-libgo.

@pcc the newer gofrontend revision has the necessary fixes. check-libgo no longer hangs, and prints out results as they're available. OK to land now?

Mar 14 2016, 11:17 PM
axw closed D15188: [llgo] Roll gofrontend forward.

Closed by rL263536

Mar 14 2016, 10:59 PM
axw committed rL263536: [llgo] Roll gofrontend forward.
[llgo] Roll gofrontend forward
Mar 14 2016, 10:46 PM
axw committed rL263530: bindings/go: reinstate TargetMachine.TargetData.
bindings/go: reinstate TargetMachine.TargetData
Mar 14 2016, 10:09 PM
axw closed D18173: bindings/go: reinstate TargetMachine.TargetData.
Mar 14 2016, 10:09 PM
axw added inline comments to D15188: [llgo] Roll gofrontend forward.
Mar 14 2016, 10:08 PM
axw added a comment to D18173: bindings/go: reinstate TargetMachine.TargetData.
In D18173#375236, @pcc wrote:

Maybe this should be renamed CreateTargetData to emphasize that the TargetData is owned by the caller. We probably need to update the code in llgo for the new ownership as well.

Mar 14 2016, 9:59 PM
axw updated the diff for D15188: [llgo] Roll gofrontend forward.

TargetMachine.TargetData -> TargetMachine.CreateTargetData

Mar 14 2016, 9:59 PM
axw updated the diff for D18173: bindings/go: reinstate TargetMachine.TargetData.

Rename TargetMachine.TargetData to TargetMachine.CreateTargetData

Mar 14 2016, 9:58 PM
axw added a dependency for D15188: [llgo] Roll gofrontend forward: D18173: bindings/go: reinstate TargetMachine.TargetData.
Mar 14 2016, 8:19 PM
axw added a dependent revision for D18173: bindings/go: reinstate TargetMachine.TargetData: D15188: [llgo] Roll gofrontend forward.
Mar 14 2016, 8:19 PM
axw retitled D18173: bindings/go: reinstate TargetMachine.TargetData from to bindings/go: reinstate TargetMachine.TargetData.
Mar 14 2016, 8:19 PM

Feb 18 2016

axw added a comment to D15188: [llgo] Roll gofrontend forward.

Ping. Once this is in, I'll look at updating to 1.6.

Feb 18 2016, 4:09 AM

Feb 11 2016

axw committed rL260641: Avoid linking LLVM component libraries with libLLVM.
Avoid linking LLVM component libraries with libLLVM
Feb 11 2016, 5:47 PM
axw closed D16945: LLVM overhaul to avoid linking LLVM component libraries with libLLVM by committing rL260641: Avoid linking LLVM component libraries with libLLVM.
Feb 11 2016, 5:47 PM

Feb 10 2016

axw resigned from D16945: LLVM overhaul to avoid linking LLVM component libraries with libLLVM.

IMO this is good to go, but I'm biased as I was involved in writing it. I'll resign as reviewer for that reason. @beanz, PTAL.

Feb 10 2016, 5:28 PM

Feb 9 2016

axw added inline comments to D16945: LLVM overhaul to avoid linking LLVM component libraries with libLLVM.
Feb 9 2016, 7:11 PM
axw added a comment to D15188: [llgo] Roll gofrontend forward.

@pcc Thanks, PTAL.

Feb 9 2016, 5:07 AM
axw updated the diff for D15188: [llgo] Roll gofrontend forward.
  • Fix autoconf file copying
  • Call hash/equal functions directly, not through descriptors.
Feb 9 2016, 5:06 AM

Feb 8 2016

axw requested changes to D16945: LLVM overhaul to avoid linking LLVM component libraries with libLLVM.

I hope what I've said is clear - please ask if not. I can see if I can find some time to propose an alternative, but also very busy with day job.

Feb 8 2016, 2:59 AM

Jan 26 2016

axw abandoned D11863: [llgo] drop use of __go_new_nopointers.

Superceded by D15188

Jan 26 2016, 10:47 PM
axw added a comment to D15188: [llgo] Roll gofrontend forward.

@pcc Ping. This is ready for review now.

Jan 26 2016, 12:18 AM
axw added a comment to D15188: [llgo] Roll gofrontend forward.
In D15188#331740, @axw wrote:

Revert removal of __go_runtime_error

No longer causing errors. Have not bisected
to find out what the issue is yet.

Jan 26 2016, 12:17 AM
axw updated D15188: [llgo] Roll gofrontend forward.
Jan 26 2016, 12:16 AM

Jan 20 2016

axw committed rL258383: llvm-go: call llvm-config with components.
llvm-go: call llvm-config with components
Jan 20 2016, 6:37 PM
axw closed D16392: llvm-go: call llvm-config with components.
Jan 20 2016, 6:37 PM
axw abandoned D16387: [llvm-go] add component lib deps to llvm-go.

Superceded by D16392

Jan 20 2016, 6:34 PM
axw retitled D16392: llvm-go: call llvm-config with components from to llvm-go: call llvm-config with components.
Jan 20 2016, 6:34 PM
axw added a comment to D16387: [llvm-go] add component lib deps to llvm-go.
In D16387#331920, @pcc wrote:

For both libLLVMGlobalISel and libLLVMDebugInfoCodeView? The former would be lacking a build rule due it being optional, but was causing llvm-config to complain due to the component not being marked optional. I've fixed that in r258379.

Okay, I see.

I don't think that helps. As far as I can see, that list of components is only used by the standalone Go bindings build (bindings/go/build.sh).

It used to be passed to llvm-config by llvm-go.go until your change r258283, and things worked until then. As you are fixing build breakage I would have preferred a more minimal change that reverts things to the way they used to work. But this is fine as well, LGTM.

Jan 20 2016, 6:31 PM
axw added a comment to D16387: [llvm-go] add component lib deps to llvm-go.
In D16387#331898, @pcc wrote:

Does this solve the problem?

Jan 20 2016, 6:12 PM
axw committed rL258379: [GlobalISel] make library an optional component.
[GlobalISel] make library an optional component
Jan 20 2016, 5:44 PM
axw closed D16386: [GlobalISel] make library an optional component.
Jan 20 2016, 5:44 PM
axw retitled D16387: [llvm-go] add component lib deps to llvm-go from to [llvm-go] add component lib deps to llvm-go.
Jan 20 2016, 5:40 PM
axw updated the diff for D16386: [GlobalISel] make library an optional component.

Remove unrelated changes

Jan 20 2016, 5:35 PM
axw retitled D16386: [GlobalISel] make library an optional component from to [GlobalISel] make library an optional component.
Jan 20 2016, 5:33 PM
axw updated the diff for D15188: [llgo] Roll gofrontend forward.

Revert removal of __go_runtime_error

Jan 20 2016, 4:35 PM

Jan 19 2016

axw committed rL258283: tools/llvm-config: improve shared library support.
tools/llvm-config: improve shared library support
Jan 19 2016, 8:07 PM
axw closed D15986: llvm-config: handle BUILD_SHARED_LIBS correctly by committing rL258283: tools/llvm-config: improve shared library support.
Jan 19 2016, 8:07 PM

Jan 18 2016

axw added a comment to D16208: [docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB.
In D16208#328470, @axw wrote:

Looks like this got merged before I was able to comment on this.

Sorry, I probably should have left it open a bit longer. Your suggestions read well, I'll commit them early next week.

Jan 18 2016, 9:47 PM
axw committed rL258112: docs: address post-commit review.
docs: address post-commit review
Jan 18 2016, 9:47 PM

Jan 15 2016

axw added a comment to D16208: [docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB.

Looks like this got merged before I was able to comment on this.

Jan 15 2016, 5:35 PM

Jan 14 2016

axw committed rL257864: [docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB.
[docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB
Jan 14 2016, 7:37 PM
axw closed D16208: [docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB.
Jan 14 2016, 7:37 PM
axw retitled D16208: [docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB from to [docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB.
Jan 14 2016, 5:34 PM

Jan 11 2016

axw committed rL257457: Revert r257003.
Revert r257003
Jan 11 2016, 11:27 PM
axw added a comment to D15033: tools/llvm-config: improve shared library support.

I have reverted this, because it breaks if you have BUILD_SHARED_LIBS=on and we're about to branch for 3.8. I'll reapply when D15986 (or another fix) is ready to land.

Jan 11 2016, 11:27 PM

Jan 7 2016

axw planned changes to D15188: [llgo] Roll gofrontend forward.

I've just come back to this and found that it's broken. Unsure of what's changed in the interim, but I get "panic: panic during panic" caused by type descriptor comparisons. Will come back to this when I have time.

Jan 7 2016, 11:03 PM