This is an archive of the discontinued LLVM Phabricator instance.

Differential D142538

[Libomptarget] Stop testing LTO on AMD offloading
ClosedPublic

Authored by jhuber6 on Jan 25 2023, 6:47 AM.

Details

Reviewers
ye-luo
jdoerfert
tianshilei1992
JonChesterfield
Summary

Recent patches made -foffload-lto effectively a no-op on AMD
offloading. We no longer need to test them separately.

Diff Detail

Event Timeline

jhuber6 created this revision.Jan 25 2023, 6:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 6:47 AM
Herald added subscribers: kosarev, kerbowa, inglorion, jvesely. · View Herald Transcript
jhuber6 requested review of this revision.Jan 25 2023, 6:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 6:47 AM
Herald added a subscriber: openmp-commits. · View Herald Transcript
Harbormaster completed remote builds in B209857: Diff 492092.Jan 25 2023, 6:50 AM
Herald added a subscriber: sstefan1. · View Herald TranscriptJan 25 2023, 6:50 AM
tianshilei1992 accepted this revision.Jan 25 2023, 7:01 AM

No need to update the next gen plugin?

This revision is now accepted and ready to land.Jan 25 2023, 7:01 AM
jhuber6 added a subscriber: kevinsala.Jan 25 2023, 7:02 AM
In D142538#4079840, @tianshilei1992 wrote:

No need to update the next gen plugin?

As far as I know, the nextgen used these definitions as well, I couldn't find another reference to them there. But maybe @kevinsala knows.

jhuber6 closed this revision.Mar 23 2023, 1:23 PM

This was committed externally and I forgot to link it up.

Herald added a subscriber: jplehr. · View Herald TranscriptMar 23 2023, 1:23 PM

Revision Contents

PathSize
openmp/
libomptarget/
plugins/
amdgpu/
4 lines

Diff 492092

openmp/libomptarget/plugins/amdgpu/CMakeLists.txt

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines
# Report to the parent scope that we are building a plugin for hsa. # Report to the parent scope that we are building a plugin for hsa.
# This controls whether tests are run for the nvptx offloading target # This controls whether tests are run for the nvptx offloading target
# Run them if libhsa is available, or if the user explicitly asked for dlopen # Run them if libhsa is available, or if the user explicitly asked for dlopen
# Otherwise this plugin is being built speculatively and there may be no hsa available # Otherwise this plugin is being built speculatively and there may be no hsa available
option(LIBOMPTARGET_FORCE_AMDGPU_TESTS "Build AMDGPU libomptarget tests" OFF) option(LIBOMPTARGET_FORCE_AMDGPU_TESTS "Build AMDGPU libomptarget tests" OFF)
if (LIBOMPTARGET_FOUND_AMDGPU_GPU OR LIBOMPTARGET_FORCE_AMDGPU_TESTS) if (LIBOMPTARGET_FOUND_AMDGPU_GPU OR LIBOMPTARGET_FORCE_AMDGPU_TESTS)
# Report to the parent scope that we are building a plugin for amdgpu # Report to the parent scope that we are building a plugin for amdgpu
set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS} amdgcn-amd-amdhsa amdgcn-amd-amdhsa-oldDriver" PARENT_SCOPE) set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS} amdgcn-amd-amdhsa" PARENT_SCOPE)
set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS} amdgcn-amd-amdhsa amdgcn-amd-amdhsa-LTO" PARENT_SCOPE)
list(APPEND LIBOMPTARGET_TESTED_PLUGINS "omptarget.rtl.amdgpu") list(APPEND LIBOMPTARGET_TESTED_PLUGINS "omptarget.rtl.amdgpu")
set(LIBOMPTARGET_TESTED_PLUGINS "${LIBOMPTARGET_TESTED_PLUGINS}" PARENT_SCOPE) set(LIBOMPTARGET_TESTED_PLUGINS "${LIBOMPTARGET_TESTED_PLUGINS}" PARENT_SCOPE)
else() else()
libomptarget_say("Not generating amdgcn test targets as libhsa is not linkable") libomptarget_say("Not generating amdgcn test targets as libhsa is not linkable")
return() return()
endif() endif()