Differential D142476

[mlir][LLVM] Add result attribute import support
ClosedPublic
Actions

Authored by Dinistro on Jan 24 2023, 7:42 AM.

Tags

Subscribers

View All 27 Subscribers

Details

Reviewers

gysit
definelicht
ftynse
dcaballe

Commits

rG56880fd257e2: [mlir][LLVM] Add result attribute import support

Summary

This commit introduces support for importing result attributes.

Depends on D142372

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Dinistro created this revision.Jan 24 2023, 7:42 AM

Herald added a reviewer: ftynse. · View Herald TranscriptJan 24 2023, 7:42 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript

Dinistro requested review of this revision.Jan 24 2023, 7:42 AM

Herald added a reviewer: dcaballe. · View Herald TranscriptJan 24 2023, 7:42 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

gysit accepted this revision.Jan 24 2023, 8:17 AM

gysit added inline comments.

mlir/lib/Target/LLVMIR/ModuleImport.cpp
1488	nit: I would probably inline this list onto the convertParameterAttribute method.
mlir/test/Target/LLVMIR/Import/function-attributes.ll
64	nit: maybe try if two of the result attributes can appear on one function by combining two tests?

This revision is now accepted and ready to land.Jan 24 2023, 8:17 AM

Harbormaster completed remote builds in B209671: Diff 491795.Jan 24 2023, 9:54 AM

address additional comments and extend tests

Harbormaster completed remote builds in B209851: Diff 492085.Jan 25 2023, 6:50 AM

Closed by commit rG56880fd257e2: [mlir][LLVM] Add result attribute import support (authored by Dinistro). · Explain WhyJan 25 2023, 6:54 AM

This revision was automatically updated to reflect the committed changes.

Dinistro added a commit: rG56880fd257e2: [mlir][LLVM] Add result attribute import support.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Target/

LLVMIR/

8 lines

lib/

Target/

LLVMIR/

ModuleImport.cpp

85 lines

test/

Target/

LLVMIR/

Import/

function-attributes.ll

40 lines

Diff 492098

mlir/include/mlir/Target/LLVMIR/ModuleImport.h

Loading...

mlir/lib/Target/LLVMIR/ModuleImport.cpp

Loading...

mlir/test/Target/LLVMIR/Import/function-attributes.ll

Loading...