This is an archive of the discontinued LLVM Phabricator instance.

[mlir][LLVM] Add result attribute import support

Authored by Dinistro on Jan 24 2023, 7:42 AM.



This commit introduces support for importing result attributes.

Depends on D142372

Diff Detail

Event Timeline

Dinistro created this revision.Jan 24 2023, 7:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Dinistro requested review of this revision.Jan 24 2023, 7:42 AM
gysit accepted this revision.Jan 24 2023, 8:17 AM
gysit added inline comments.

nit: I would probably inline this list onto the convertParameterAttribute method.


nit: maybe try if two of the result attributes can appear on one function by combining two tests?

This revision is now accepted and ready to land.Jan 24 2023, 8:17 AM
Dinistro updated this revision to Diff 492085.Jan 25 2023, 6:18 AM
Dinistro marked 2 inline comments as done.

address additional comments and extend tests

This revision was automatically updated to reflect the committed changes.