This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add tests for folding `(and/or (icmp eq/ne A, Pow2), (icmp eq/ne A, -Pow2))`; NFC
ClosedPublic

Authored by goldstein.w.n on Jan 23 2023, 3:23 AM.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jan 23 2023, 3:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 3:23 AM
Herald added a subscriber: pengfei. · View Herald Transcript
goldstein.w.n requested review of this revision.Jan 23 2023, 3:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 3:23 AM

Remove some dud tests, add some useful negative cases

pengfei added inline comments.Jan 28 2023, 11:05 PM
llvm/test/CodeGen/X86/icmp-pow2-logic-npow2.ll
8

Missing test for i16.

goldstein.w.n marked an inline comment as done.

Add i16 + vec test

goldstein.w.n added inline comments.Jan 29 2023, 11:19 AM
llvm/test/CodeGen/X86/icmp-pow2-logic-npow2.ll
8

Missing test for i16.

Added. Also added a vector version.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2023, 4:59 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.