This is an archive of the discontinued LLVM Phabricator instance.

Differential D142221

[AMDGPU] Fix passing tests.
AbandonedPublic

Authored by kosarev on Jan 20 2023, 7:57 AM.

Details

Reviewers
arsenm
foad
Orlando
Group Reviewers
Restricted Project
Summary

Completes https://reviews.llvm.org/D142027 .

Diff Detail

Unit TestsFailed

TimeTest
40 msx64 debian > LLVM.CodeGen/AArch64::O0-pipeline.ll
60 msx64 debian > LLVM.CodeGen/AArch64::O3-pipeline.ll
60 msx64 debian > LLVM.CodeGen/ARM::O3-pipeline.ll
50 msx64 debian > LLVM.CodeGen/LoongArch::O0-pipeline.ll
70 msx64 debian > LLVM.CodeGen/LoongArch::opt-pipeline.ll
View Full Test Results (9 Failed)

Event Timeline

kosarev created this revision.Jan 20 2023, 7:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 7:57 AM
Herald added subscribers: StephenFan, kerbowa, tpr and 4 others. · View Herald Transcript
kosarev requested review of this revision.Jan 20 2023, 7:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 7:57 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
arsenm accepted this revision.Jan 20 2023, 7:58 AM
This revision is now accepted and ready to land.Jan 20 2023, 7:58 AM
kosarev added a reviewer: Restricted Project.Jan 20 2023, 7:58 AM
Orlando added a comment.Jan 20 2023, 8:01 AM

I just landed a commit 99c12afeb4a1afa608d487351eebe79ebf058b8d that fixes this. Sorry about that, and thanks for looking into the problem anyway.

kosarev abandoned this revision.Jan 20 2023, 8:02 AM

Already fixed in https://reviews.llvm.org/rG99c12afeb4a1afa608d487351eebe79ebf058b8d .

Harbormaster completed remote builds in B208992: Diff 490855.Jan 20 2023, 9:50 AM

Revision Contents

PathSize
llvm/
test/
CodeGen/
AMDGPU/
5 lines

Diff 490855

llvm/test/CodeGen/AMDGPU/llc-pipeline.ll

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
; GCN-O0-NEXT: DummyCGSCCPass ; GCN-O0-NEXT: DummyCGSCCPass
; GCN-O0-NEXT: FunctionPass Manager ; GCN-O0-NEXT: FunctionPass Manager
; GCN-O0-NEXT: Safe Stack instrumentation pass ; GCN-O0-NEXT: Safe Stack instrumentation pass
; GCN-O0-NEXT: Insert stack protectors ; GCN-O0-NEXT: Insert stack protectors
; GCN-O0-NEXT: Dominator Tree Construction ; GCN-O0-NEXT: Dominator Tree Construction
; GCN-O0-NEXT: Post-Dominator Tree Construction ; GCN-O0-NEXT: Post-Dominator Tree Construction
; GCN-O0-NEXT: Natural Loop Information ; GCN-O0-NEXT: Natural Loop Information
; GCN-O0-NEXT: Legacy Divergence Analysis ; GCN-O0-NEXT: Legacy Divergence Analysis
; GCN-O0-NEXT: Assignment Tracking Analysis
; GCN-O0-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection ; GCN-O0-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection
; GCN-O0-NEXT: MachineDominator Tree Construction ; GCN-O0-NEXT: MachineDominator Tree Construction
; GCN-O0-NEXT: SI Fix SGPR copies ; GCN-O0-NEXT: SI Fix SGPR copies
; GCN-O0-NEXT: MachinePostDominator Tree Construction ; GCN-O0-NEXT: MachinePostDominator Tree Construction
; GCN-O0-NEXT: SI Lower i1 Copies ; GCN-O0-NEXT: SI Lower i1 Copies
; GCN-O0-NEXT: Finalize ISel and expand pseudo-instructions ; GCN-O0-NEXT: Finalize ISel and expand pseudo-instructions
; GCN-O0-NEXT: Local Stack Slot Allocation ; GCN-O0-NEXT: Local Stack Slot Allocation
; GCN-O0-NEXT: Register Usage Information Propagation ; GCN-O0-NEXT: Register Usage Information Propagation
▲ Show 20 Lines • Show All 178 Lines • ▼ Show 20 Lines
; GCN-O1-NEXT: Insert stack protectors ; GCN-O1-NEXT: Insert stack protectors
; GCN-O1-NEXT: Dominator Tree Construction ; GCN-O1-NEXT: Dominator Tree Construction
; GCN-O1-NEXT: Post-Dominator Tree Construction ; GCN-O1-NEXT: Post-Dominator Tree Construction
; GCN-O1-NEXT: Natural Loop Information ; GCN-O1-NEXT: Natural Loop Information
; GCN-O1-NEXT: Legacy Divergence Analysis ; GCN-O1-NEXT: Legacy Divergence Analysis
; GCN-O1-NEXT: Basic Alias Analysis (stateless AA impl) ; GCN-O1-NEXT: Basic Alias Analysis (stateless AA impl)
; GCN-O1-NEXT: Function Alias Analysis Results ; GCN-O1-NEXT: Function Alias Analysis Results
; GCN-O1-NEXT: Branch Probability Analysis ; GCN-O1-NEXT: Branch Probability Analysis
; GCN-O1-NEXT: Assignment Tracking Analysis
; GCN-O1-NEXT: Lazy Branch Probability Analysis ; GCN-O1-NEXT: Lazy Branch Probability Analysis
; GCN-O1-NEXT: Lazy Block Frequency Analysis ; GCN-O1-NEXT: Lazy Block Frequency Analysis
; GCN-O1-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection ; GCN-O1-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection
; GCN-O1-NEXT: MachineDominator Tree Construction ; GCN-O1-NEXT: MachineDominator Tree Construction
; GCN-O1-NEXT: SI Fix SGPR copies ; GCN-O1-NEXT: SI Fix SGPR copies
; GCN-O1-NEXT: MachinePostDominator Tree Construction ; GCN-O1-NEXT: MachinePostDominator Tree Construction
; GCN-O1-NEXT: SI Lower i1 Copies ; GCN-O1-NEXT: SI Lower i1 Copies
; GCN-O1-NEXT: Finalize ISel and expand pseudo-instructions ; GCN-O1-NEXT: Finalize ISel and expand pseudo-instructions
▲ Show 20 Lines • Show All 279 Lines • ▼ Show 20 Lines
; GCN-O1-OPTS-NEXT: Insert stack protectors ; GCN-O1-OPTS-NEXT: Insert stack protectors
; GCN-O1-OPTS-NEXT: Dominator Tree Construction ; GCN-O1-OPTS-NEXT: Dominator Tree Construction
; GCN-O1-OPTS-NEXT: Post-Dominator Tree Construction ; GCN-O1-OPTS-NEXT: Post-Dominator Tree Construction
; GCN-O1-OPTS-NEXT: Natural Loop Information ; GCN-O1-OPTS-NEXT: Natural Loop Information
; GCN-O1-OPTS-NEXT: Legacy Divergence Analysis ; GCN-O1-OPTS-NEXT: Legacy Divergence Analysis
; GCN-O1-OPTS-NEXT: Basic Alias Analysis (stateless AA impl) ; GCN-O1-OPTS-NEXT: Basic Alias Analysis (stateless AA impl)
; GCN-O1-OPTS-NEXT: Function Alias Analysis Results ; GCN-O1-OPTS-NEXT: Function Alias Analysis Results
; GCN-O1-OPTS-NEXT: Branch Probability Analysis ; GCN-O1-OPTS-NEXT: Branch Probability Analysis
; GCN-O1-OPTS-NEXT: Assignment Tracking Analysis
; GCN-O1-OPTS-NEXT: Lazy Branch Probability Analysis ; GCN-O1-OPTS-NEXT: Lazy Branch Probability Analysis
; GCN-O1-OPTS-NEXT: Lazy Block Frequency Analysis ; GCN-O1-OPTS-NEXT: Lazy Block Frequency Analysis
; GCN-O1-OPTS-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection ; GCN-O1-OPTS-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection
; GCN-O1-OPTS-NEXT: MachineDominator Tree Construction ; GCN-O1-OPTS-NEXT: MachineDominator Tree Construction
; GCN-O1-OPTS-NEXT: SI Fix SGPR copies ; GCN-O1-OPTS-NEXT: SI Fix SGPR copies
; GCN-O1-OPTS-NEXT: MachinePostDominator Tree Construction ; GCN-O1-OPTS-NEXT: MachinePostDominator Tree Construction
; GCN-O1-OPTS-NEXT: SI Lower i1 Copies ; GCN-O1-OPTS-NEXT: SI Lower i1 Copies
; GCN-O1-OPTS-NEXT: Finalize ISel and expand pseudo-instructions ; GCN-O1-OPTS-NEXT: Finalize ISel and expand pseudo-instructions
▲ Show 20 Lines • Show All 288 Lines • ▼ Show 20 Lines
; GCN-O2-NEXT: Insert stack protectors ; GCN-O2-NEXT: Insert stack protectors
; GCN-O2-NEXT: Dominator Tree Construction ; GCN-O2-NEXT: Dominator Tree Construction
; GCN-O2-NEXT: Post-Dominator Tree Construction ; GCN-O2-NEXT: Post-Dominator Tree Construction
; GCN-O2-NEXT: Natural Loop Information ; GCN-O2-NEXT: Natural Loop Information
; GCN-O2-NEXT: Legacy Divergence Analysis ; GCN-O2-NEXT: Legacy Divergence Analysis
; GCN-O2-NEXT: Basic Alias Analysis (stateless AA impl) ; GCN-O2-NEXT: Basic Alias Analysis (stateless AA impl)
; GCN-O2-NEXT: Function Alias Analysis Results ; GCN-O2-NEXT: Function Alias Analysis Results
; GCN-O2-NEXT: Branch Probability Analysis ; GCN-O2-NEXT: Branch Probability Analysis
; GCN-O2-NEXT: Assignment Tracking Analysis
; GCN-O2-NEXT: Lazy Branch Probability Analysis ; GCN-O2-NEXT: Lazy Branch Probability Analysis
; GCN-O2-NEXT: Lazy Block Frequency Analysis ; GCN-O2-NEXT: Lazy Block Frequency Analysis
; GCN-O2-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection ; GCN-O2-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection
; GCN-O2-NEXT: MachineDominator Tree Construction ; GCN-O2-NEXT: MachineDominator Tree Construction
; GCN-O2-NEXT: SI Fix SGPR copies ; GCN-O2-NEXT: SI Fix SGPR copies
; GCN-O2-NEXT: MachinePostDominator Tree Construction ; GCN-O2-NEXT: MachinePostDominator Tree Construction
; GCN-O2-NEXT: SI Lower i1 Copies ; GCN-O2-NEXT: SI Lower i1 Copies
; GCN-O2-NEXT: Finalize ISel and expand pseudo-instructions ; GCN-O2-NEXT: Finalize ISel and expand pseudo-instructions
▲ Show 20 Lines • Show All 300 Lines • ▼ Show 20 Lines
; GCN-O3-NEXT: Insert stack protectors ; GCN-O3-NEXT: Insert stack protectors
; GCN-O3-NEXT: Dominator Tree Construction ; GCN-O3-NEXT: Dominator Tree Construction
; GCN-O3-NEXT: Post-Dominator Tree Construction ; GCN-O3-NEXT: Post-Dominator Tree Construction
; GCN-O3-NEXT: Natural Loop Information ; GCN-O3-NEXT: Natural Loop Information
; GCN-O3-NEXT: Legacy Divergence Analysis ; GCN-O3-NEXT: Legacy Divergence Analysis
; GCN-O3-NEXT: Basic Alias Analysis (stateless AA impl) ; GCN-O3-NEXT: Basic Alias Analysis (stateless AA impl)
; GCN-O3-NEXT: Function Alias Analysis Results ; GCN-O3-NEXT: Function Alias Analysis Results
; GCN-O3-NEXT: Branch Probability Analysis ; GCN-O3-NEXT: Branch Probability Analysis
; GCN-O3-NEXT: Assignment Tracking Analysis
; GCN-O3-NEXT: Lazy Branch Probability Analysis ; GCN-O3-NEXT: Lazy Branch Probability Analysis
; GCN-O3-NEXT: Lazy Block Frequency Analysis ; GCN-O3-NEXT: Lazy Block Frequency Analysis
; GCN-O3-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection ; GCN-O3-NEXT: AMDGPU DAG->DAG Pattern Instruction Selection
; GCN-O3-NEXT: MachineDominator Tree Construction ; GCN-O3-NEXT: MachineDominator Tree Construction
; GCN-O3-NEXT: SI Fix SGPR copies ; GCN-O3-NEXT: SI Fix SGPR copies
; GCN-O3-NEXT: MachinePostDominator Tree Construction ; GCN-O3-NEXT: MachinePostDominator Tree Construction
; GCN-O3-NEXT: SI Lower i1 Copies ; GCN-O3-NEXT: SI Lower i1 Copies
; GCN-O3-NEXT: Finalize ISel and expand pseudo-instructions ; GCN-O3-NEXT: Finalize ISel and expand pseudo-instructions
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines