This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Only test kmp_atomic_float10_max_min.c on X86
ClosedPublic

Authored by tianshilei1992 on Jan 19 2023, 8:16 PM.

Details

Summary

The test openmp/runtime/test/atomic/kmp_atomic_float10_max_min.c uses a compiler
flag -mlong-double-80 that might not be supported by all targets. Currently it
requires x86-registered-target, but that requirement can be true when LLVM
supports X86 while the actual libomp arch is not X86. For example, when LLVM
is built on AArch64 with all targets enabled, x86-registered-target can be met.
If libomp is built with native target, aka. AArch64, the test will still be enabled,
causing test failure.

This patch only enables the test if the actual target is X86. The actual target
is determined by LIBOMP_ARCH.

Fix #53696.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jan 19 2023, 8:16 PM
tianshilei1992 requested review of this revision.Jan 19 2023, 8:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 8:16 PM
tianshilei1992 edited the summary of this revision. (Show Details)Jan 19 2023, 8:16 PM
jlpeyton accepted this revision.Jan 20 2023, 7:44 AM
jlpeyton added a subscriber: jlpeyton.

LGTM

This revision is now accepted and ready to land.Jan 20 2023, 7:44 AM