Page MenuHomePhabricator

[clang][lex] Pass hash location to more PPCallbacks methods
Needs ReviewPublic

Authored by KyleFromKitware on Jan 17 2023, 12:27 PM.

Details

Diff Detail

Unit TestsFailed

TimeTest
6,180 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/gdb::gdb_pretty_printer_test.sh.cpp
Script: -- : 'RUN: at line 20'; /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/install/bin/clang++ --target=x86_64-unknown-linux-gnu /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp.exe -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -g -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/lib -lc++ -pthread
3,400 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp
Script: -- : 'COMPILED WITH'; /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/install/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only
4,140 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/gdb::gdb_pretty_printer_test.sh.cpp
Script: -- : 'RUN: at line 20'; /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/install/bin/clang++ --target=x86_64-unknown-linux-gnu /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp.exe -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -g -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread

Event Timeline

KyleFromKitware created this object with edit policy "KyleFromKitware (Kyle Edwards)".
KyleFromKitware requested review of this revision.Jan 17 2023, 12:27 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a subscriber: cfe-commits. · View Herald Transcript
KyleFromKitware removed a project: Restricted Project.Jan 17 2023, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 2:11 PM

WIP - currently updating the tests for pp-trace and in the process debugging an issue with the location of the #endif hash.

Added Introducer parameter to Pragma callbacks.

dang added a comment.Jan 24 2023, 6:32 AM

LGTM for the ExtractAPI changes.

Rebased onto main for D141000.

KyleFromKitware changed the edit policy from "KyleFromKitware (Kyle Edwards)" to "All Users".Jan 27 2023, 8:53 AM