Page MenuHomePhabricator
Differential D141961

[clang][lex] Pass hash location to more PPCallbacks methods
Needs ReviewPublic
Actions

Authored by KyleFromKitware on Jan 17 2023, 12:27 PM.

Details

Reviewers
ributzka
njames93
dang

Diff Detail

Unit TestsFailed
View All

TimeTest
6,180 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/gdb::gdb_pretty_printer_test.sh.cpp
Script: -- : 'RUN: at line 20'; /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/install/bin/clang++ --target=x86_64-unknown-linux-gnu /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp.exe -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -g -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/ed8fff71fbdc-1/llvm-project/libcxx-ci/build/generic-cxx2b/lib -lc++ -pthread
3,400 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp
Script: -- : 'COMPILED WITH'; /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/install/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only
4,140 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/gdb::gdb_pretty_printer_test.sh.cpp
Script: -- : 'RUN: at line 20'; /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/install/bin/clang++ --target=x86_64-unknown-linux-gnu /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp.exe -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -g -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/6995c72a17e4-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread

Event Timeline

KyleFromKitware created this revision.Jan 17 2023, 12:27 PM
KyleFromKitware created this object with edit policy "KyleFromKitware (Kyle Edwards)".
Herald added a reviewer: ributzka. · View Herald TranscriptJan 17 2023, 12:27 PM
Herald added a reviewer: njames93. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: kadircet, carlosgalvezp, shchenz and 3 others. · View Herald Transcript
KyleFromKitware requested review of this revision.Jan 17 2023, 12:27 PM
Herald added a reviewer: dang. · View Herald TranscriptJan 17 2023, 12:27 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a subscriber: cfe-commits. · View Herald Transcript
KyleFromKitware removed a project: Restricted Project.Jan 17 2023, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 2:11 PM
KyleFromKitware added a comment.Jan 17 2023, 2:13 PM

WIP - currently updating the tests for pp-trace and in the process debugging an issue with the location of the #endif hash.

Harbormaster completed remote builds in B208315: Diff 489916.Jan 17 2023, 2:25 PM
KyleFromKitware updated this revision to Diff 490160.Jan 18 2023, 7:48 AM
Harbormaster completed remote builds in B208495: Diff 490160.Jan 18 2023, 8:30 AM
KyleFromKitware added a child revision: D142030: [pp-trace] Print HashLoc/Introducer parameter.Jan 18 2023, 8:36 AM
KyleFromKitware added a child revision: D142121: [clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase.Jan 19 2023, 8:02 AM
KyleFromKitware updated this revision to Diff 491745.Jan 24 2023, 6:13 AM
KyleFromKitware added a parent revision: D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters.

Added Introducer parameter to Pragma callbacks.

dang added a comment.Jan 24 2023, 6:32 AM

LGTM for the ExtractAPI changes.

KyleFromKitware updated this revision to Diff 491773.Jan 24 2023, 7:07 AM

Rebased onto main for D141000.

Harbormaster completed remote builds in B209651: Diff 491773.Jan 24 2023, 9:11 AM
KyleFromKitware updated this revision to Diff 492574.Jan 26 2023, 2:43 PM
Harbormaster completed remote builds in B210223: Diff 492574.Jan 26 2023, 4:20 PM
KyleFromKitware changed the edit policy from "KyleFromKitware (Kyle Edwards)" to "All Users".Jan 27 2023, 8:53 AM
KyleFromKitware updated this revision to Diff 494645.Feb 3 2023, 7:59 AM
Harbormaster completed remote builds in B211731: Diff 494645.Feb 3 2023, 8:57 AM

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-include-fixer/
find-all-symbols/
10 lines
9 lines
clang-tidy/
67 lines
74 lines
bugprone/
2 lines
cppcoreguidelines/
2 lines
google/
13 lines
modernize/
53 lines
readability/
11 lines
3 lines
12 lines
utils/
9 lines
2 lines
clangd/
11 lines
3 lines
2 lines
include-cleaner/
lib/
22 lines
modularize/
34 lines
pp-trace/
70 lines
66 lines
clang/
include/
clang/
Lex/
361 lines
38 lines
21 lines
11 lines
lib/
CodeGen/
5 lines
6 lines
ExtractAPI/
5 lines
Frontend/
2 lines
99 lines
Rewrite/
14 lines
Index/
21 lines
Lex/
30 lines
68 lines
33 lines
16 lines
Parse/
9 lines
tools/
libclang/
5 lines
unittests/
Basic/
6 lines
Lex/
22 lines

Diff 492574

View Options

clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllMacros.h

Loading...
View Options

clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllMacros.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h

Loading...
View Options

clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/bugprone/MacroParenthesesCheck.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/readability/RedundantPreprocessorCheck.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

Loading...
View Options

clang-tools-extra/clangd/CollectMacros.h

Loading...
View Options

clang-tools-extra/clangd/CollectMacros.cpp

Loading...
View Options

clang-tools-extra/clangd/Preamble.cpp

Loading...
View Options

clang-tools-extra/include-cleaner/lib/Record.cpp

Loading...
View Options

clang-tools-extra/modularize/PreprocessorTracker.cpp

Loading...
View Options

clang-tools-extra/pp-trace/PPCallbacksTracker.h

Loading...
View Options

clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

Loading...
View Options

clang/include/clang/Lex/PPCallbacks.h

Loading...
View Options

clang/include/clang/Lex/PPConditionalDirectiveRecord.h

Loading...
View Options

clang/include/clang/Lex/PreprocessingRecord.h

Loading...
View Options

clang/include/clang/Lex/Preprocessor.h

Loading...
View Options

clang/lib/CodeGen/MacroPPCallbacks.h

Loading...
View Options

clang/lib/CodeGen/MacroPPCallbacks.cpp

Loading...
View Options

clang/lib/ExtractAPI/ExtractAPIConsumer.cpp

Loading...
View Options

clang/lib/Frontend/ASTUnit.cpp

Loading...
View Options

clang/lib/Frontend/PrintPreprocessedOutput.cpp

Loading...
View Options

clang/lib/Frontend/Rewrite/InclusionRewriter.cpp

Loading...
View Options

clang/lib/Index/IndexingAction.cpp

Loading...
View Options

clang/lib/Lex/PPConditionalDirectiveRecord.cpp

Loading...
View Options

clang/lib/Lex/PPDirectives.cpp

Loading...
View Options

clang/lib/Lex/Pragma.cpp

Loading...
View Options

clang/lib/Lex/PreprocessingRecord.cpp

Loading...
View Options

clang/lib/Parse/ParsePragma.cpp

Loading...
View Options

clang/tools/libclang/Indexing.cpp

Loading...
View Options

clang/unittests/Basic/SourceManagerTest.cpp

Loading...
View Options

clang/unittests/Lex/PPCallbacksTest.cpp

Loading...