This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase

Authored by KyleFromKitware on Jan 19 2023, 8:02 AM.


Group Reviewers
Restricted Project

Diff Detail

Event Timeline

KyleFromKitware created this object with edit policy "KyleFromKitware (Kyle Edwards)".
Herald added a project: Restricted Project. · View Herald Transcript
KyleFromKitware requested review of this revision.Jan 19 2023, 8:02 AM

What's the purpose behind this refactor, If its for 142123, then this should be blocked until a consensus is reached over there?

Yes, this is for D142123. However, even if that doesn't land, I'd still like to land this. We use the code from D142123 in CMake's CI system, and getting it to work without this change resulted in a massive amount of code duplication. This refactoring would allow us to eliminate such duplication on our end.