Paths

Table of Contentst

Differential D141961

[clang][lex] Pass hash location to more PPCallbacks methods
Needs ReviewPublic
Actions

Authored by KyleFromKitware on Jan 17 2023, 12:27 PM.

Tags

Subscribers

Details

Reviewers

ributzka
njames93
dang

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	4,040 ms	libcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp Script: -- : 'COMPILED WITH'; /home/libcxx-builder/.buildkite-agent/builds/2747d845bec9-1/llvm-project/libcxx-ci/install/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/2747d845bec9-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/2747d845bec9-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2747d845bec9-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/2747d845bec9-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only

Event Timeline

KyleFromKitware created this revision.Jan 17 2023, 12:27 PM

KyleFromKitware created this object with edit policy "KyleFromKitware (Kyle Edwards)".

Herald added a reviewer: ributzka. · View Herald TranscriptJan 17 2023, 12:27 PM

Herald added a reviewer: njames93. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: kadircet, carlosgalvezp, shchenz and 3 others. · View Herald Transcript

KyleFromKitware requested review of this revision.Jan 17 2023, 12:27 PM

Herald added a reviewer: dang. · View Herald TranscriptJan 17 2023, 12:27 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

Herald added a subscriber: cfe-commits. · View Herald Transcript

KyleFromKitware removed a project: Restricted Project.Jan 17 2023, 2:11 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 2:11 PM

WIP - currently updating the tests for pp-trace and in the process debugging an issue with the location of the #endif hash.

Harbormaster completed remote builds in B208315: Diff 489916.Jan 17 2023, 2:25 PM

KyleFromKitware updated this revision to Diff 490160.Jan 18 2023, 7:48 AM

Harbormaster completed remote builds in B208495: Diff 490160.Jan 18 2023, 8:30 AM

KyleFromKitware added a child revision: D142030: [pp-trace] Print HashLoc/Introducer parameter.Jan 18 2023, 8:36 AM

KyleFromKitware added a child revision: D142121: [clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase.Jan 19 2023, 8:02 AM

Added Introducer parameter to Pragma callbacks.

LGTM for the ExtractAPI changes.

Rebased onto main for D141000.

Harbormaster completed remote builds in B209651: Diff 491773.Jan 24 2023, 9:11 AM

KyleFromKitware updated this revision to Diff 492574.Jan 26 2023, 2:43 PM

Harbormaster completed remote builds in B210223: Diff 492574.Jan 26 2023, 4:20 PM

KyleFromKitware changed the edit policy from "KyleFromKitware (Kyle Edwards)" to "All Users".Jan 27 2023, 8:53 AM

KyleFromKitware updated this revision to Diff 494645.Feb 3 2023, 7:59 AM

Harbormaster completed remote builds in B211731: Diff 494645.Feb 3 2023, 8:57 AM

Revision Contents
Changeset List

Path

Size

clang-tools-extra/

clang-include-fixer/

find-all-symbols/

FindAllMacros.h

10 lines

FindAllMacros.cpp

9 lines

clang-tidy/

ExpandModularHeadersPPCallbacks.h

22 lines

ExpandModularHeadersPPCallbacks.cpp

24 lines

bugprone/

MacroParenthesesCheck.cpp

2 lines

cppcoreguidelines/

MacroUsageCheck.cpp

2 lines

google/

UpgradeGoogletestCaseCheck.cpp

13 lines

modernize/

MacroToEnumCheck.cpp

53 lines

readability/

DuplicateIncludeCheck.cpp

11 lines

ElseAfterReturnCheck.cpp

3 lines

RedundantPreprocessorCheck.cpp

12 lines

utils/

HeaderGuard.cpp

9 lines

RenamerClangTidyCheck.cpp

2 lines

clangd/

CollectMacros.h

11 lines

2 lines

include-cleaner/

lib/

22 lines

modularize/

PreprocessorTracker.cpp

34 lines

pp-trace/

PPCallbacksTracker.h

27 lines

PPCallbacksTracker.cpp

32 lines

clang/

include/

clang/

Lex/

161 lines

PPConditionalDirectiveRecord.h

38 lines

PreprocessingRecord.h

21 lines

7 lines

lib/

CodeGen/

MacroPPCallbacks.h

5 lines

MacroPPCallbacks.cpp

6 lines

ExtractAPI/

ExtractAPIConsumer.cpp

5 lines

Frontend/

2 lines

PrintPreprocessedOutput.cpp

10 lines

Rewrite/

InclusionRewriter.cpp

14 lines

Index/

IndexingAction.cpp

21 lines

Lex/

PPConditionalDirectiveRecord.cpp

30 lines

PPDirectives.cpp

58 lines

PreprocessingRecord.cpp

16 lines

tools/

libclang/

5 lines

unittests/

Basic/

SourceManagerTest.cpp

6 lines

Lex/

PPCallbacksTest.cpp

8 lines

Diff 489916

clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllMacros.h

Loading...

clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllMacros.cpp

Loading...

clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h

Loading...

clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp

Loading...

clang-tools-extra/clang-tidy/bugprone/MacroParenthesesCheck.cpp

Loading...

clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp

Loading...

clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp

Loading...

clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp

Loading...

clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp

Loading...

clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

Loading...

clang-tools-extra/clang-tidy/readability/RedundantPreprocessorCheck.cpp

Loading...

clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp

Loading...

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

Loading...

clang-tools-extra/clangd/CollectMacros.h

Loading...

clang-tools-extra/clangd/Preamble.cpp

Loading...

clang-tools-extra/include-cleaner/lib/Record.cpp

Loading...

clang-tools-extra/modularize/PreprocessorTracker.cpp

Loading...

clang-tools-extra/pp-trace/PPCallbacksTracker.h

Loading...

clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

Loading...

clang/include/clang/Lex/PPCallbacks.h

Loading...

clang/include/clang/Lex/PPConditionalDirectiveRecord.h

Loading...

clang/include/clang/Lex/PreprocessingRecord.h

Loading...

clang/include/clang/Lex/Preprocessor.h

Loading...

clang/lib/CodeGen/MacroPPCallbacks.h

Loading...

clang/lib/CodeGen/MacroPPCallbacks.cpp

Loading...

clang/lib/ExtractAPI/ExtractAPIConsumer.cpp

Loading...

clang/lib/Frontend/ASTUnit.cpp

Loading...

clang/lib/Frontend/PrintPreprocessedOutput.cpp

Loading...

clang/lib/Frontend/Rewrite/InclusionRewriter.cpp

Loading...

clang/lib/Index/IndexingAction.cpp

Loading...

clang/lib/Lex/PPConditionalDirectiveRecord.cpp

Loading...

clang/lib/Lex/PPDirectives.cpp

Loading...

clang/lib/Lex/PreprocessingRecord.cpp

Loading...

clang/tools/libclang/Indexing.cpp

Loading...

clang/unittests/Basic/SourceManagerTest.cpp

Loading...

clang/unittests/Lex/PPCallbacksTest.cpp

Loading...