This is an archive of the discontinued LLVM Phabricator instance.

[SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata
ClosedPublic

Authored by mpaszkowski on Jan 13 2023, 3:32 PM.

Details

Summary

This change makes the AsmPrinter emit OpExecutionMode ContractionOff when both opencl.enable.FP_CONTRACT and spirv.ExecutionMode metadata are not present. All 16 contractions OpenCL CTS tests pass after this change.

no_fp_contractions_metadata.ll and fp_contractions_metadata.ll LIT tests were added and other tests checking OpenCL metadata were moved to OpenCL/metadata directory.

Diff Detail

Event Timeline

mpaszkowski created this revision.Jan 13 2023, 3:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 3:32 PM
mpaszkowski requested review of this revision.Jan 13 2023, 3:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 3:32 PM
This revision is now accepted and ready to land.Jan 16 2023, 8:53 AM
iliya-diyachkov accepted this revision.Jan 17 2023, 3:21 PM

This patch looks good to me. Thanks, Michal.

Full runtime testing results are now available: https://spirv-testing.khronos.org/job/82/. I will commit this patch after D142061.

This revision was landed with ongoing or failed builds.Jan 19 2023, 6:27 AM
This revision was automatically updated to reflect the committed changes.