This is an archive of the discontinued LLVM Phabricator instance.

[SPIR-V] Add -opaque-pointers=0 to some LIT tests
ClosedPublic

Authored by mpaszkowski on Jan 18 2023, 3:15 PM.

Details

Summary

@nikic in D141912 removed auto-detection of typed pointers and added -opaque-pointers=0 to LITs which still require changes in other backends. Unfortunately, we still have such tests in the SPIR-V backend. This patch adds -opaque-pointers=0 to the 50 LIT tests which still require changes. I will create a tracker issue on GitHub for those tests and convert as many as possible to opaque pointers starting next week. However, some will need to wait for Joshua's changes introducing target extension types for OpenCL.

@nikic Please accept the patch and keep us in the loop. I will include you in the upcoming patches.

Diff Detail

Event Timeline

mpaszkowski created this revision.Jan 18 2023, 3:15 PM
mpaszkowski requested review of this revision.Jan 18 2023, 3:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 3:15 PM

@nikic I have created the issue for tracking the SPIR-V backend LIT tests with -opaque-pointers=0 here: https://github.com/llvm/llvm-project/issues/60133

nikic accepted this revision.Jan 19 2023, 2:08 AM

LGTM

This revision is now accepted and ready to land.Jan 19 2023, 2:08 AM
This revision was landed with ongoing or failed builds.Jan 19 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.