This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add additional tests for ctlz{_zero_undef} to test folding with xor; NFC
ClosedPublic

Authored by goldstein.w.n on Jan 11 2023, 3:15 PM.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jan 11 2023, 3:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 3:15 PM
Herald added a subscriber: pengfei. · View Herald Transcript
goldstein.w.n requested review of this revision.Jan 11 2023, 3:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 3:15 PM
pengfei added inline comments.Jan 12 2023, 12:25 AM
llvm/test/CodeGen/X86/clz.ll
626

This seems manually mentained. Please keep it as it. The same for below changes.

1791

Missing a ctlz_xor31_i32_ture unintentionally?
Actually, I think it's better if we intersect use i8_true, i16_false etc. to reduce the size. I'd prefer to use less tests while not compromise the cover rate.

pengfei added inline comments.Jan 12 2023, 12:31 AM
llvm/test/CodeGen/X86/clz.ll
1791

Please ignore, I found the identical test above.

goldstein.w.n marked 2 inline comments as done.

Add back rep, remove to gratuitous tests

llvm/test/CodeGen/X86/clz.ll
1791

Missing a ctlz_xor31_i32_ture unintentionally?
Actually, I think it's better if we intersect use i8_true, i16_false etc. to reduce the size. I'd prefer to use less tests while not compromise the cover rate.

I intersected i16 / i64. Think worth keeping both cases for i8 b.c its a special case. LMK if you feel strongly about dropping.

pengfei accepted this revision.Jan 13 2023, 3:25 AM

LGTM.

This revision is now accepted and ready to land.Jan 13 2023, 3:25 AM

Will wait 24 hours to push.

This revision was landed with ongoing or failed builds.Jan 17 2023, 11:06 AM
This revision was automatically updated to reflect the committed changes.