[clang-repl] XFAIL riscv targets in simple-exception test case

[asb]

Summary

I'm not familiar with this infrastructure so haven't dug into why it's failing, but it is failing for me on RISC-V. As Arm targets are also XFAILed it doesn't seem like an unreasonable "fix" to XFAIL for RISC-V too - but if it looks like an easy fix might be possible from someone who's been working in the area, I'd obviously welcome that as an alternative!

For reference, the output of this test is currently:

clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> Running f()
terminate called after throwing an instance of 'char const*'
Aborted (core dumped)

[sunho]

Do you have an exception support in your libstdc++ and it's dynamically linked? I believe if clang-repl was able to execute the program, it must have successfully linked to cxxthrow symbols and so exception handling works correctly.

[sunho]

Maybe @Hahnfeld knows something as he added riscv support to clang-repl recently.

[Hahnfeld]

Yes, this is correct: The JITLink backend for RISC-V doesn't (yet) register the eh frames into libunwind, so throwing and catching exceptions through JITted code doesn't work (yet). I know in principle how to make this happen and it's on my list, but I couldn't give it priority before a talk on Thursday. Sorry for not realizing we have a test for this in clang-repl - does this mean we have bots running this natively on RISC-V?

[asb]

In D141380#4053535, @Hahnfeld wrote:

Yes, this is correct: The JITLink backend for RISC-V doesn't (yet) register the eh frames into libunwind, so throwing and catching exceptions through JITted code doesn't work (yet). I know in principle how to make this happen and it's on my list, but I couldn't give it priority before a talk on Thursday. Sorry for not realizing we have a test for this in clang-repl - does this mean we have bots running this natively on RISC-V?

Not yet, but hopefully soon.

clang/test/Interpreter/simple-exception.cpp

 // clang-format off
 // UNSUPPORTED: system-aix
-// XFAIL for arm and arm64, or running on Windows.
-// XFAIL: target=arm{{.*}}, system-windows
+// XFAIL for arm, arm64, riscv, or running on Windows.
+// XFAIL: target={{(arm|riscv).*}}, system-windows
 // RUN: cat %s | clang-repl | FileCheck %s
 extern "C" int printf(const char *, ...);
 
 int f() { throw "Simple exception"; return 0; }
 int checkException() { try { printf("Running f()\n"); f(); } catch (const char *e) { printf("%s\n", e); } return 0; }
 auto r1 = checkException();
 // CHECK: Running f()
 // CHECK-NEXT: Simple exception
 
-%quit
+%quit