- User Since
- Jan 21 2022, 9:49 PM (61 w, 1 d)
Feb 17 2023
I guess this is more generic apporach than https://reviews.llvm.org/D134610.
Feb 9 2023
Feb 8 2023
Feb 7 2023
I think it makes more sense to use stable version of clang-format for that purpose but I'm not in a postion to decide as I don't work with format. Can you change the script to use latest clang-format for format codebase and revert this patch in the meantime? Currently, all patches that touch format part will see format verifiaction ci faliure with this patch.
Wouldn't that mean llvm contributors have to format their code using clang-format built from top-of-tree source code before submitting the patch? Technically that script is for checking if the code has been formatted correctly.
Feb 6 2023
I think buildbot is "formatting" the patch using clang-format-15. The tests of clang-format would be done with latest code.
This seems to be causing builtbot lint script error: https://buildkite.com/llvm-project/premerge-checks/builds/134501#01862630-8fa9-487c-99b1-9addbe6257d0
Feb 3 2023
We don't need this now.
Ping? Also wonder if this is not a problem anymore.
Feb 2 2023
LGTM for me. That validation error has been a problem on Windows too.
Feb 1 2023
Sorry for the delay. I was only looking at the test case; the code change looks reasonable to me. As they are supposed to be discarded anyways, it's safe to just remove COMDAT data as well to make IR valid.
Jan 24 2023
What happens when we actually have duplicate comdat any definitions? IIRC I've seen that in msvcrt.lib.
Jan 13 2023
Maybe @Hahnfeld knows something as he added riscv support to clang-repl recently.
Do you have an exception support in your libstdc++ and it's dynamically linked? I believe if clang-repl was able to execute the program, it must have successfully linked to cxxthrow symbols and so exception handling works correctly.
I think you could just do default: break; but logging can be helpful at this stage of development I guess.
Nov 21 2022
LGTM to me in general. Few minor comments.
Nov 20 2022
Nov 2 2022
Oct 3 2022
Fix test failure. Separate out the platform instance setup part in order to load orc runtime when JIT instance is fully configured. (e.g. in-process symbol generator is set up)
Sep 25 2022
Sep 17 2022
This is actually not related to the conditionals but related to something in my system or cmake which causes it to set MINGW to true. Abandoning this patch as it is going to break clang-cl building case anyways.
Keep only the part relevant for MSVC.
Sep 12 2022
Sep 11 2022
Turned out the different library name was made by a bug in compiler-rt cmake file -- my local build was generating ".a" library files. It should be fixed in https://reviews.llvm.org/D133669. I'll update the code to use just ".lib" I'll invastigate the symbol not found failure shortly.
Sep 9 2022
I mistakenly commited this change to irrelevant commit (https://github.com/llvm/llvm-project/commit/d1c4d96126921e02a8f39b9a8ffa3c875158ffaf)
Aug 26 2022
Aug 24 2022
Add & fix tests.
Aug 23 2022
Aug 19 2022
Aug 18 2022
Aug 15 2022
@kuhar Commited a fix. Thanks for reporting this!
Aug 13 2022
Aug 12 2022
Use path as key.
Aug 11 2022
Thanks for the patch! It's really exciting to see i386 backend coming up.
Aug 10 2022
Aug 8 2022
Fixed by sgraenitz using proper way!
Aug 2 2022
Proper support of multiple jitdylibs.
Make COFFPlatform responsible for vc runtime setup.
Add more tests.
Add license header.