Page MenuHomePhabricator

sunho (Sunho Kim)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2022, 9:49 PM (17 w, 2 d)

Recent Activity

Feb 21 2022

sunho added a comment to D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

Cheers! Can you commit on my behalf?

Feb 21 2022, 11:38 AM · Restricted Project

Feb 20 2022

sunho added a comment to D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

Sorry for the delay. I've separated commits that adds tests to https://reviews.llvm.org/D120214, and make this commit only show the difference between older version.

Feb 20 2022, 10:09 AM · Restricted Project
sunho updated the diff for D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..
Feb 20 2022, 10:07 AM · Restricted Project
sunho updated the diff for D120214: [NFC][AARCH64] Add test cases for negation of select.
Feb 20 2022, 9:56 AM · Restricted Project
sunho requested review of D120214: [NFC][AARCH64] Add test cases for negation of select.
Feb 20 2022, 9:41 AM · Restricted Project

Feb 3 2022

sunho added a comment to D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

Thanks! Can you commit on my behalf?

Feb 3 2022, 4:40 AM · Restricted Project

Feb 2 2022

sunho added inline comments to D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..
Feb 2 2022, 2:17 PM · Restricted Project
sunho updated the diff for D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

Remove space.

Feb 2 2022, 2:07 PM · Restricted Project
sunho updated the diff for D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

Use simpler pattern based on https://reviews.llvm.org/D112204

Feb 2 2022, 2:06 PM · Restricted Project
sunho added a comment to D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

https://alive2.llvm.org/ce/z/2KoTdr It always passes unless I put nsw on sub in tgt block. I guess that means it's okay.

Feb 2 2022, 1:24 PM · Restricted Project
sunho added a comment to D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

IIUC, if nsw flag is not specified it will wrap around, then -(-128) = -128, still yielding the same result. Even if nsw flag is specified, I can define poison value as anything I want so it's still fine?

Feb 2 2022, 12:52 PM · Restricted Project
sunho added a comment to D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

I like your method! It's always reducing negation or keeping the same number of negation unless x and y are both non-negative and it can account for nabs case very well. I was trying to tidy your patch a bit and add some more test cases to address the comments by david-arm and submit it here. However, one thing came to concern me.

Feb 2 2022, 11:24 AM · Restricted Project

Jan 31 2022

sunho added inline comments to D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..
Jan 31 2022, 12:23 PM · Restricted Project
sunho updated the summary of D118563: [AARCH64][NEON] Reuse extended vdup value in low version of long operations when doing tryCombineLongOpWithDup.
Jan 31 2022, 12:19 PM · Restricted Project
sunho updated the diff for D118563: [AARCH64][NEON] Reuse extended vdup value in low version of long operations when doing tryCombineLongOpWithDup.

typo

Jan 31 2022, 12:18 PM · Restricted Project
sunho updated the diff for D118563: [AARCH64][NEON] Reuse extended vdup value in low version of long operations when doing tryCombineLongOpWithDup.

Tidy up test case and code.

Jan 31 2022, 12:16 PM · Restricted Project
sunho updated the diff for D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

Account for comments

Jan 31 2022, 11:28 AM · Restricted Project
sunho updated the diff for D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

Edit existing test

Jan 31 2022, 4:20 AM · Restricted Project
sunho retitled D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern. from [AArch64][DAGCombine] Add combine for negation of CSEL absolute value pattern. to [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..
Jan 31 2022, 4:01 AM · Restricted Project
sunho updated the diff for D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..

Edit typos

Jan 31 2022, 4:00 AM · Restricted Project
sunho added reviewers for D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern.: fhahn, dmgreen.
Jan 31 2022, 3:57 AM · Restricted Project
sunho requested review of D118595: [AARCH64][DAGCombine] Add combine for negation of CSEL absolute value pattern..
Jan 31 2022, 3:54 AM · Restricted Project

Jan 30 2022

sunho updated the summary of D118563: [AARCH64][NEON] Reuse extended vdup value in low version of long operations when doing tryCombineLongOpWithDup.
Jan 30 2022, 5:53 AM · Restricted Project
sunho updated the summary of D118563: [AARCH64][NEON] Reuse extended vdup value in low version of long operations when doing tryCombineLongOpWithDup.
Jan 30 2022, 5:39 AM · Restricted Project
sunho requested review of D118563: [AARCH64][NEON] Reuse extended vdup value in low version of long operations when doing tryCombineLongOpWithDup.
Jan 30 2022, 5:31 AM · Restricted Project

Jan 29 2022

sunho updated the diff for D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

Remove unused line

Jan 29 2022, 6:58 AM · Restricted Project
sunho added a comment to D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

.

Jan 29 2022, 6:55 AM · Restricted Project
sunho updated the diff for D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..
Jan 29 2022, 6:55 AM · Restricted Project
sunho added a comment to D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

@fhahn @dmgreen I've accounted for your comments. Please take a look again!

Jan 29 2022, 6:48 AM · Restricted Project
sunho added inline comments to D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..
Jan 29 2022, 6:45 AM · Restricted Project
sunho updated the diff for D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..
Jan 29 2022, 6:43 AM · Restricted Project

Jan 22 2022

sunho added a comment to D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

@fhahn I've shrinked the test case. Could you take a look?

Jan 22 2022, 9:35 PM · Restricted Project
sunho updated the diff for D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

Make test case compact.

Jan 22 2022, 9:34 PM · Restricted Project
sunho changed the edit policy for D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..
Jan 22 2022, 3:19 PM · Restricted Project

Jan 21 2022

sunho updated the diff for D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..

Tidy up testcases.

Jan 21 2022, 11:23 PM · Restricted Project
sunho requested review of D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull..
Jan 21 2022, 10:56 PM · Restricted Project