These tests cover muli, xor, and, addf, subf, and addi.
The tests themselves are not that interesting, their goal is to provide
code coverage for all the types of reductions currently supported.
NFC
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Could you reformat the CHECK blocks so they don't have so much leading whitespace between the CHECK and the code?
| mlir/test/Dialect/SparseTensor/vectorize_reduction.mlir | ||
|---|---|---|
| 490 | I'd add a newline before this, to separate it from the CHECK stuff. (Usually we don't have a blank line, but then usually we have the func.func op immediately after its corresponding CHECK stuff.) | |
| 563 | ditto. (And ditto for the other tests to follow) | |
Comment Actions
- Reduce leading whitespace between the CHECKs and the code.
- Add a new line between the CHECK blocks and the input IR.
Comment Actions
Could you reformat the CHECK blocks so they don't have so much leading whitespace between the CHECK and the code?
@wrengr Done!
Although I didn't remove all of them because I thought some made the checks more readable (the ones that comes from the block indentation). Let me know if you want these to be flattened.
(Note: the check lines were actually auto generated, so the formatting issue may pop back up if we ever auto update the tests.)
I'd add a newline before this, to separate it from the CHECK stuff. (Usually we don't have a blank line, but then usually we have the func.func op immediately after its corresponding CHECK stuff.)