This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add a newline character in the Linalg debug macro
ClosedPublic

Authored by awarzynski on Dec 29 2022, 1:14 AM.

Diff Detail

Event Timeline

awarzynski created this revision.Dec 29 2022, 1:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
awarzynski requested review of this revision.Dec 29 2022, 1:14 AM

Not sure whether the omission of \n was deliberate? I do struggle to parse the debug logs without it :( Thanks for taking a look!

ftynse accepted this revision.Dec 29 2022, 1:18 AM
ftynse added a subscriber: ftynse.

At the time this was added, we were printing a newline after ops and such by default.

This revision is now accepted and ready to land.Dec 29 2022, 1:18 AM

I think we may have two new lines printed now in some cases. I was adding some explicit "\n" in one of my masking patches.