This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Invert handling of enqueued block detection
ClosedPublic

Authored by arsenm on Dec 23 2022, 3:21 PM.

Details

Reviewers
yaxunl
sameerds
rampitec
jdoerfert
sstefan1
cfang
Group Reviewers
Restricted Project
Summary

Invert the sense of the attribute and let the attributor figure this
out like everything else. If needed we can have the not-OpenCL
languages set amdgpu-no-default-queue and amdgpu-no-completion-action
up front so they never have to pay the cost.

There are also so many of these now, the offset use API should
probably consider all of them at once. Maybe they should merge into
one attribute with used fields. Having separate functions for each
field in AMDGPUBaseInfo is also not the greatest API (might as well
fix this when the patch to get the object version from the module
lands).

Diff Detail

Event Timeline

arsenm created this revision.Dec 23 2022, 3:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 23 2022, 3:21 PM
arsenm requested review of this revision.Dec 23 2022, 3:21 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
arsenm planned changes to this revision.Dec 23 2022, 4:18 PM
arsenm updated this revision to Diff 485179.Dec 23 2022, 7:26 PM
arsenm edited the summary of this revision. (Show Details)
arsenm added a reviewer: cfang.

Don't use the attribute clang emits since that doesn't actually work, and check the underlying accessed fields like every other implicit arg

sameerds accepted this revision.Dec 26 2022, 12:29 AM
This revision is now accepted and ready to land.Dec 26 2022, 12:29 AM