Page MenuHomePhabricator

[update_cc_test_checks] Default to --function-signature for new tests
Needs ReviewPublic

Authored by arichardson on Dec 16 2022, 7:17 AM.

Details

Summary

This is the same as D140212 just for the clang update script. Quite a
bit of churn in the internal tests since they used inputs without the
autogenerated by args.

Depends on D140212

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LeakTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/fuzzer-leak.test.tmp-LeakTest
60,040 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LoadTest.cpp -fsanitize-coverage=trace-gep -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/value-profile-load.test.tmp-LoadTest

Event Timeline

arichardson created this revision.Dec 16 2022, 7:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2022, 7:17 AM
arichardson requested review of this revision.Dec 16 2022, 7:17 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 16 2022, 7:17 AM

I don't understand why we would remove the flag for _cc_. I feel all these patches are going exactly in the opposite direction I would think one would go.

arsenm added a subscriber: arsenm.Dec 16 2022, 10:25 AM
arsenm added inline comments.
clang/test/utils/update_cc_test_checks/Inputs/basic-cplusplus.cpp.expected
3

Why do we still have generated tests using -no-opaque-pointers? Surely that's the lowest hanging fruit?

I don't understand why we would remove the flag for _cc_. I feel all these patches are going exactly in the opposite direction I would think one would go.

The flag is not being removed it's just inside common.py now (see D140212) and defaults to on for new tests without the auto-generated note.

clang/test/utils/update_cc_test_checks/Inputs/basic-cplusplus.cpp.expected
3

Good question, I can update this as a separate NFC change on Monday.