This is mostly going to be used for linalg transformations - to make pooling ops similar to convolution ops.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Great! LGMT. Just a few minor comments.
Could you please also add a description to the diff and effectively to the commit?
Thanks!
mlir/test/Dialect/Linalg/generalize-named-polymorphic-ops.mlir | ||
---|---|---|
141 |
Same below | |
mlir/test/Dialect/Linalg/named-ops.mlir | ||
426 | Remove %{{.+}} = Same below |
Comment Actions
Wondering know if it would make sense to add a "combiner" kind to the pooling ops, similar to the one we have for vector.contract, for example. Is that something that has been considered?
Comment Actions
That is something I considered but would involve changing existing ops, so I deferred from doing that till this sequence of PRs land. Both layout and operations should be parameters to a more abstract op
Same below