This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] use sparse_tensor::StorageSpecifier to store dim/memSizes
ClosedPublic

Authored by Peiming on Dec 15 2022, 11:04 AM.

Diff Detail

Event Timeline

Peiming created this revision.Dec 15 2022, 11:04 AM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Dec 15 2022, 11:04 AM
Peiming updated this revision to Diff 483249.Dec 15 2022, 11:09 AM

revert unnessary change.

Peiming updated this revision to Diff 483264.Dec 15 2022, 11:30 AM

fix some check test.

Peiming updated this revision to Diff 483326.Dec 15 2022, 1:46 PM

fix all check tests.

Peiming updated this revision to Diff 483391.Dec 15 2022, 4:55 PM

rebase + fix check tests

aartbik added inline comments.Dec 22 2022, 2:56 PM
mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td
353–354

While you are here, change this verb form of the old at L354 into Pushes ... and your new at L355 into returns ....

353–354

using the size found at index curSize
or something of that nature Just to make it clear it is not the direct size?

401–402

space after //

// Build an op

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp
118

this has become really nice now!

996

empty line not needed

mlir/test/Dialect/SparseTensor/codegen.mlir
61–71

I realize this is a pain, but the A1 -> 0 and then A6 -> 4 are getting very confusing.
can we just rename this, at all places, into A0, A1, etc

(probably the last time now, since have have the specifier

Peiming updated this revision to Diff 484988.Dec 22 2022, 4:33 PM
Peiming marked 5 inline comments as done.

address comments.

Peiming marked an inline comment as done.Dec 22 2022, 4:33 PM
aartbik accepted this revision.Dec 22 2022, 4:46 PM
This revision is now accepted and ready to land.Dec 22 2022, 4:46 PM
This revision was landed with ongoing or failed builds.Dec 22 2022, 4:47 PM
This revision was automatically updated to reflect the committed changes.