This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Use Python3 for add_new_check.py and rename_check.py
ClosedPublic

Authored by carlosgalvezp on Dec 13 2022, 1:06 PM.

Diff Detail

Event Timeline

carlosgalvezp created this revision.Dec 13 2022, 1:06 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: xazax.hun. · View Herald Transcript
carlosgalvezp requested review of this revision.Dec 13 2022, 1:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 1:06 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revert format changes.

Mention change in the Release Notes.

Eugene.Zelenko added inline comments.Dec 13 2022, 2:21 PM
clang-tools-extra/docs/ReleaseNotes.rst
204 ↗(On Diff #482611)

Should be at the beginning of Improvements to clang-tidy section, because it does not relate to checks.

Address comments

carlosgalvezp marked an inline comment as done.Dec 13 2022, 10:44 PM

Wrap to 80 chars.

Eugene.Zelenko accepted this revision.Dec 14 2022, 7:01 AM

Looks OK for me, but will be good idea to wait for couple of days for other eyes.

This revision is now accepted and ready to land.Dec 14 2022, 7:01 AM
njames93 accepted this revision.Dec 15 2022, 1:56 PM

I'm just a little uneasy with the description, this isn't "fixing" the linked issue, its more a workaround. The issue itself is also a bit of a non-issue.

I'm just a little uneasy with the description, this isn't "fixing" the linked issue, its more a workaround. The issue itself is also a bit of a non-issue.

Thanks for reviewing!

The script has a shebang, whose purpose is to be able to launch it via "./add_new_check.py". Therefore as a user I expect that to work. As such, a supported use case was broken, so IMO the issue is valid, and this is a correct fix, not a workaround. The workaround is invoking the tool as "python3 add_new_check.py".

If the intention is that people should invoke the script as "python3 add_new_check.py" always, instead of "./add_new_check.py", then it should not have any shebang.