[clang-tidy] Use Python3 for add_new_check.py and rename_check.py

[carlosgalvezp]

Summary

Fixes #58782

[carlosgalvezp]

Revert format changes.

[carlosgalvezp]

Mention change in the Release Notes.

[Eugene.Zelenko]

clang-tools-extra/docs/ReleaseNotes.rst

204 ↗

(On Diff #482611)

Should be at the beginning of Improvements to clang-tidy section, because it does not relate to checks.

[carlosgalvezp]

Address comments

[carlosgalvezp]

Wrap to 80 chars.

[Eugene.Zelenko]

Looks OK for me, but will be good idea to wait for couple of days for other eyes.

[njames93]

I'm just a little uneasy with the description, this isn't "fixing" the linked issue, its more a workaround. The issue itself is also a bit of a non-issue.

[carlosgalvezp]

In D139966#3999473, @njames93 wrote:

I'm just a little uneasy with the description, this isn't "fixing" the linked issue, its more a workaround. The issue itself is also a bit of a non-issue.

Thanks for reviewing!

The script has a shebang, whose purpose is to be able to launch it via "./add_new_check.py". Therefore as a user I expect that to work. As such, a supported use case was broken, so IMO the issue is valid, and this is a correct fix, not a workaround. The workaround is invoking the tool as "python3 add_new_check.py".

If the intention is that people should invoke the script as "python3 add_new_check.py" always, instead of "./add_new_check.py", then it should not have any shebang.

clang-tools-extra/clang-tidy/add_new_check.py

-#!/usr/bin/env python
+#!/usr/bin/env python3
 #
 #===- add_new_check.py - clang-tidy check generator ---------*- python -*--===#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 # See https://llvm.org/LICENSE.txt for license information.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 #
 #===-----------------------------------------------------------------------===#

 // CHECK-FIXES: {{^}}void awesome_f();{{$}}
 
 // FIXME: Add something that doesn't trigger the check here.
 void awesome_f2();
 """ % {'check_name_dashes': check_name_dashes})
 
 
 def get_actual_filename(dirname, filename):
-  if not os.path.isdir(dirname): 
+  if not os.path.isdir(dirname):
     return ''
   name = os.path.join(dirname, filename)
   if (os.path.isfile(name)):
     return name
   caselessname = filename.lower()
   for file in os.listdir(dirname):
     if (file.lower() == caselessname):
       return os.path.join(dirname, file)

clang-tools-extra/clang-tidy/rename_check.py

-#!/usr/bin/env python
+#!/usr/bin/env python3
 #
 #===- rename_check.py - clang-tidy check renamer ------------*- python -*--===#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 # See https://llvm.org/LICENSE.txt for license information.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 #
 #===-----------------------------------------------------------------------===#