Page MenuHomePhabricator

Test cases for OpenMP metadirective support and related interop functionality
AcceptedPublic

Authored by jz10 on Nov 29 2022, 7:57 AM.

Details

Summary

fix the git diff and get rid of wrong patch content

Diff Detail

Event Timeline

jz10 created this revision.Nov 29 2022, 7:57 AM
Herald added a project: Restricted Project. · View Herald Transcript
jz10 requested review of this revision.Nov 29 2022, 7:57 AM
jdoerfert requested changes to this revision.Nov 29 2022, 3:40 PM

This patch seems to be all over the place. Make sure you got the right files and baseline. Also adjust the subject line and add a proper description.

This revision now requires changes to proceed.Nov 29 2022, 3:40 PM
jz10 updated this revision to Diff 478890.Nov 30 2022, 4:20 AM
jz10 retitled this revision from verify OpenMP metadriective support and the relative functionality to rinterop to verify OpenMP metadriective support and the relative functionality to interop.
jz10 edited the summary of this revision. (Show Details)
jz10 retitled this revision from verify OpenMP metadriective support and the relative functionality to interop to Test cases for OpenMP metadirective support and related interop functionality.Dec 5 2022, 6:24 PM
jdoerfert accepted this revision.Dec 13 2022, 1:41 PM

LG, but FWIW, we will never return _hip as foreign runtime. We introduced a new _amdhsa enum that we return.

This revision is now accepted and ready to land.Dec 13 2022, 1:41 PM

The tests do not include any runtime conditions.

@jz10 did you create these tests stand-alone or tested them using a metadirective implementation?

jz10 added a comment.Tue, Jan 10, 5:58 PM

@jz10 did you create these tests stand-alone or tested them using a metadirective implementation?

we created them to test metadirective implementation

abidmalikwaterloo added a comment.EditedTue, Jan 10, 6:23 PM

@jz10 did you create these tests stand-alone or tested them using a meta directive implementation?

we created them to test meta-directive implementation

@jz10. Thanks. The clang has meta-directive support for static conditions. Did you implement any new meta-directive support?

@jz10. Thanks. The clang has meta-directive support for static conditions. Did you implement any new meta-directive support for your test?

jz10 added a comment.Sun, Jan 15, 3:15 AM

@jz10. Thanks. The clang has meta-directive support for static conditions. Did you implement any new meta-directive support for your test?

No, this patch only provides test cases