This is an archive of the discontinued LLVM Phabricator instance.

Differential D138916

[AMDGPU] Add error line number checking
ClosedPublic

Authored by foad on Nov 29 2022, 5:56 AM.

Details

Reviewers
dp
Joe_Nash
arsenm
Group Reviewers
Restricted Project
Commits
rGdca1a3f29e82: [AMDGPU] Add error line number checking

Diff Detail

Unit TestsFailed

TimeTest
210 msx64 debian > LLVM.Examples/OrcV2Examples::lljit-with-thinlto-summaries.test
60,050 msx64 debian > MLIR.Examples/standalone::test.toy
60,060 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

foad created this revision.Nov 29 2022, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 5:56 AM
Herald added subscribers: kosarev, kerbowa, tpr and 4 others. · View Herald Transcript
foad requested review of this revision.Nov 29 2022, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 5:56 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B199998: Diff 478548.Nov 29 2022, 6:48 AM
arsenm accepted this revision.Nov 29 2022, 8:11 AM
arsenm added a subscriber: arsenm.

I swear I did this before

This revision is now accepted and ready to land.Nov 29 2022, 8:11 AM
This revision was landed with ongoing or failed builds.Nov 29 2022, 8:34 AM
Closed by commit rGdca1a3f29e82: [AMDGPU] Add error line number checking (authored by foad). · Explain Why
This revision was automatically updated to reflect the committed changes.
foad added a commit: rGdca1a3f29e82: [AMDGPU] Add error line number checking.
thakis added a subscriber: thakis.Nov 29 2022, 9:27 AM

This breaks tests: http://45.33.8.238/linux/92704/step_12.txt

Please take a look and revert for now if it takes a while to fix. (Also please run tests locally before committing.)

foad added a comment.Nov 29 2022, 9:30 AM
In D138916#3957493, @thakis wrote:

This breaks tests: http://45.33.8.238/linux/92704/step_12.txt

Please take a look and revert for now if it takes a while to fix. (Also please run tests locally before committing.)

Are you sure it was this commit? I didn't touch anything in test/CodeGen/.

thakis added a comment.Nov 29 2022, 9:44 AM

Apologies, it was due to https://github.com/llvm/llvm-project/commit/ee29a846c622b52d82e208146a028cf866351fde instead (that commit didn't say "AMDGPU" in the subject, so I got it wrong). https://github.com/llvm/llvm-project/commit/600e9d33a5a21b093485d093cbb6cf4bc5d9d649 has since fixed things.

Apologies again!

foad added a comment.Nov 29 2022, 9:47 AM

No problem!

Large Diff

This large diff affects 116 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
llvm/
test/
MC/
AMDGPU/
84 lines
4 lines
24 lines
24 lines
18 lines
378 lines
16 lines
28 lines
70 lines
20 lines
14 lines
4 lines
6 lines
78 lines
6 lines
12 lines
10 lines
30 lines
28 lines
76 lines
290 lines
190 lines
96 lines
24 lines
182 lines
56 lines
16 lines
34 lines
24 lines
20 lines
182 lines
408 lines
532 lines
56 lines
8 lines
24 lines
336 lines
156 lines
1314 lines
360 lines
104 lines
10 lines
2122 lines
14 lines
1240 lines
28 lines
4 lines
10 lines
468 lines
196 lines
4 lines
5572 lines
282 lines
84 lines
4 lines
70 lines
716 lines
40 lines
32 lines
18 lines
334 lines
32 lines
66 lines
56 lines
30 lines
704 lines
300 lines
12 lines
52 lines
32 lines
68 lines
16 lines
44 lines
76 lines
42 lines
100 lines
78 lines
100 lines
38 lines
regression/
8 lines
36 lines
402 lines
6 lines
26 lines
26 lines
44 lines
8 lines
48 lines
22 lines
46 lines
76 lines
32 lines
430 lines
16 lines
36 lines
28 lines
44 lines
168 lines
38 lines
26 lines
66 lines
38 lines
94 lines
80 lines
54 lines
484 lines
166 lines
8 lines
222 lines
50 lines
392 lines
252 lines
2 lines
132 lines
42 lines
18 lines

Diff 478548

llvm/test/MC/AMDGPU/add-sub-no-carry.s

llvm/test/MC/AMDGPU/atomic-fadd-insts.s

llvm/test/MC/AMDGPU/buf-fmt-d16-packed.s

llvm/test/MC/AMDGPU/buf-fmt-d16-unpacked.s

llvm/test/MC/AMDGPU/cpol-err.s

llvm/test/MC/AMDGPU/dl-insts-err.s

llvm/test/MC/AMDGPU/dpp-err.s

llvm/test/MC/AMDGPU/dpp64.s

llvm/test/MC/AMDGPU/ds-err.s

llvm/test/MC/AMDGPU/ds-gfx9.s

llvm/test/MC/AMDGPU/ds.s

llvm/test/MC/AMDGPU/elf-notes-verify-amdgcn.s

llvm/test/MC/AMDGPU/elf-notes-verify-r600.s

llvm/test/MC/AMDGPU/exp-err.s

llvm/test/MC/AMDGPU/exp-gfx10.s

llvm/test/MC/AMDGPU/expressions-gfx10.s

llvm/test/MC/AMDGPU/expressions-gfx9.s

llvm/test/MC/AMDGPU/expressions.s

llvm/test/MC/AMDGPU/flat-gfx10.s

llvm/test/MC/AMDGPU/flat-gfx9.s

llvm/test/MC/AMDGPU/flat-global.s

llvm/test/MC/AMDGPU/flat-scratch-instructions.s

llvm/test/MC/AMDGPU/flat-scratch-st-mode.s

llvm/test/MC/AMDGPU/flat-scratch.s

llvm/test/MC/AMDGPU/flat.s

llvm/test/MC/AMDGPU/fma-mix.s

llvm/test/MC/AMDGPU/gfx10-constant-bus.s

llvm/test/MC/AMDGPU/gfx1011_err.s

llvm/test/MC/AMDGPU/gfx10_asm_dpp16.s

llvm/test/MC/AMDGPU/gfx10_asm_dpp8.s

llvm/test/MC/AMDGPU/gfx10_asm_err.s

llvm/test/MC/AMDGPU/gfx10_err_pos.s

llvm/test/MC/AMDGPU/gfx11_asm_flat_errs.s

llvm/test/MC/AMDGPU/gfx11_asm_operands.s

llvm/test/MC/AMDGPU/gfx11_asm_sopk_err.s

llvm/test/MC/AMDGPU/gfx11_asm_vinterp_err.s

llvm/test/MC/AMDGPU/gfx11_asm_vop1_t16_err.s

llvm/test/MC/AMDGPU/gfx11_asm_vop2_t16_err.s

llvm/test/MC/AMDGPU/gfx11_asm_vopc_t16_err.s

llvm/test/MC/AMDGPU/gfx11_asm_vopcx_t16_err.s

llvm/test/MC/AMDGPU/gfx11_asm_vopd_err.s

llvm/test/MC/AMDGPU/gfx7_err_pos.s

llvm/test/MC/AMDGPU/gfx7_unsupported.s

llvm/test/MC/AMDGPU/gfx8_err_pos.s

llvm/test/MC/AMDGPU/gfx8_unsupported.s

llvm/test/MC/AMDGPU/gfx9-asm-err.s

llvm/test/MC/AMDGPU/gfx9-vop2be-literal.s

llvm/test/MC/AMDGPU/gfx908_err_pos.s

llvm/test/MC/AMDGPU/gfx90a_asm_features.s

llvm/test/MC/AMDGPU/gfx90a_err.s

llvm/test/MC/AMDGPU/gfx90a_err_pos.s

llvm/test/MC/AMDGPU/gfx90a_ldst_acc.s

llvm/test/MC/AMDGPU/gfx940_asm_features.s

llvm/test/MC/AMDGPU/gfx940_err.s

llvm/test/MC/AMDGPU/gfx940_err_pos.s

llvm/test/MC/AMDGPU/gfx9_err_pos.s

llvm/test/MC/AMDGPU/gfx9_unsupported.s

llvm/test/MC/AMDGPU/lds_direct-err.s

llvm/test/MC/AMDGPU/lds_direct-gfx10.s

llvm/test/MC/AMDGPU/literal16-err.s

llvm/test/MC/AMDGPU/literals.s

llvm/test/MC/AMDGPU/literalv216-err.s

llvm/test/MC/AMDGPU/literalv216.s

llvm/test/MC/AMDGPU/mad-mix.s

llvm/test/MC/AMDGPU/mai-err-gfx940.s

llvm/test/MC/AMDGPU/mai-err.s

llvm/test/MC/AMDGPU/mai-gfx940.s

llvm/test/MC/AMDGPU/mai.s

llvm/test/MC/AMDGPU/mimg-err-gfx940.s

llvm/test/MC/AMDGPU/mimg-err.s

llvm/test/MC/AMDGPU/mimg.s

llvm/test/MC/AMDGPU/misaligned-vgpr-tuples-err.s

llvm/test/MC/AMDGPU/mtbuf-gfx10.s

llvm/test/MC/AMDGPU/mtbuf.s

llvm/test/MC/AMDGPU/mubuf-gfx9.s

llvm/test/MC/AMDGPU/mubuf.s

llvm/test/MC/AMDGPU/out-of-range-registers.s

llvm/test/MC/AMDGPU/reg-syntax-err.s

llvm/test/MC/AMDGPU/reg-syntax-extra.s

llvm/test/MC/AMDGPU/regression/bug28538.s

llvm/test/MC/AMDGPU/smem-err.s

llvm/test/MC/AMDGPU/smem.s

llvm/test/MC/AMDGPU/smrd-err.s

llvm/test/MC/AMDGPU/smrd.s

llvm/test/MC/AMDGPU/sop1-err.s

llvm/test/MC/AMDGPU/sop1.s

llvm/test/MC/AMDGPU/sop2-err.s

llvm/test/MC/AMDGPU/sop2.s

llvm/test/MC/AMDGPU/sopc-err.s

llvm/test/MC/AMDGPU/sopc.s

llvm/test/MC/AMDGPU/sopk-err.s

llvm/test/MC/AMDGPU/sopk.s

llvm/test/MC/AMDGPU/sopp-err.s

llvm/test/MC/AMDGPU/sopp.s

llvm/test/MC/AMDGPU/trap.s

llvm/test/MC/AMDGPU/vintrp-e64-err.s

llvm/test/MC/AMDGPU/vintrp-err.s

llvm/test/MC/AMDGPU/vop-err.s

llvm/test/MC/AMDGPU/vop1-gfx9-err.s

llvm/test/MC/AMDGPU/vop1-gfx9.s

llvm/test/MC/AMDGPU/vop1.s

llvm/test/MC/AMDGPU/vop2-err.s

llvm/test/MC/AMDGPU/vop2.s

llvm/test/MC/AMDGPU/vop3-convert.s

llvm/test/MC/AMDGPU/vop3-errs.s

llvm/test/MC/AMDGPU/vop3-gfx9.s

llvm/test/MC/AMDGPU/vop3-literal.s

llvm/test/MC/AMDGPU/vop3-modifiers-err.s

llvm/test/MC/AMDGPU/vop3.s

llvm/test/MC/AMDGPU/vop3p-err.s

llvm/test/MC/AMDGPU/vop_dpp.s

llvm/test/MC/AMDGPU/vop_sdwa.s

llvm/test/MC/AMDGPU/vopc-errs.s

llvm/test/MC/AMDGPU/vopc-vi.s

llvm/test/MC/AMDGPU/xdl-insts-err.s

llvm/test/MC/AMDGPU/xnack-mask.s