This is an archive of the discontinued LLVM Phabricator instance.

[SVE] Commonise bfmlal* and fmlal* instruction classes
ClosedPublic

Authored by david-arm on Nov 29 2022, 3:38 AM.

Details

Summary

Given the significant commonality between the bfmlal* and fmlal*
instructions it makes sense to use just a single class for both.
We can do this now that the bfmlal* lane intrinsics take a i32
index.

Diff Detail

Event Timeline

david-arm created this revision.Nov 29 2022, 3:38 AM
Herald added a project: Restricted Project. · View Herald Transcript
david-arm requested review of this revision.Nov 29 2022, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 3:38 AM
Matt added a subscriber: Matt.Nov 30 2022, 5:41 PM
paulwalker-arm accepted this revision.Dec 6 2022, 9:51 AM

A minor request and the patch likely needs rebasing but other it looks good to me.

llvm/lib/Target/AArch64/SVEInstrFormats.td
2591–2592

Please can you reformat this to be within the 80 character line length limit. We don't typically have a rule for td files other than for the class definitions where we try to follow the same rule as with function signatures.

This revision is now accepted and ready to land.Dec 6 2022, 9:51 AM
This revision was landed with ongoing or failed builds.Dec 7 2022, 1:30 AM
This revision was automatically updated to reflect the committed changes.