Page MenuHomePhabricator

[dsymutil] fix accidental 32bit truncation in patchFrameInfoForObject
ClosedPublic

Authored by aarzilli on Nov 27 2022, 10:31 AM.

Details

Summary

patchFrameInfoForObject accidentally truncates FDE addresses to the least significant 32bits, which causes the Go bug: https://github.com/golang/go/issues/25841.

Diff Detail

Event Timeline

aarzilli created this revision.Nov 27 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: hiraditya. · View Herald Transcript
aarzilli requested review of this revision.Nov 27 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 27 2022, 10:31 AM

I see that there's a failed test but I don't understand what it is or how this could cause it.

This revision is now accepted and ready to land.Nov 28 2022, 1:48 PM

I don't have permissions to commit, if there is nothing left to the review someone else has to do it.

This revision was landed with ongoing or failed builds.Dec 17 2022, 6:27 AM
This revision was automatically updated to reflect the committed changes.