Page MenuHomePhabricator

[RISCV] Add OPCFG format of vector
ClosedPublic

Authored by JojoR on Nov 9 2022, 12:31 AM.

Diff Detail

Event Timeline

JojoR created this revision.Nov 9 2022, 12:31 AM
JojoR requested review of this revision.Nov 9 2022, 12:31 AM
reames added a subscriber: reames.Nov 10 2022, 9:49 AM

Reading through the spec, I only see mention of OPCFG in that table. Is this format actually used for any instruction? If so, which?

craig.topper added a comment.EditedNov 10 2022, 10:05 AM

Reading through the spec, I only see mention of OPCFG in that table. Is this format actually used for any instruction? If so, which?

It's the funct3(bits 14:12) encoding for vsetvli, vsetivli, and vsetvl.

We should probably update RVInstSetiVLi and friends to use the new definition instead of the raw bit pattern then right?

We should probably update RVInstSetiVLi and friends to use the new definition instead of the raw bit pattern then right?

Yes. I’ll post a patch

reames accepted this revision.Nov 10 2022, 2:25 PM

LGTM since Craig said he was going to do the follow up.

This revision is now accepted and ready to land.Nov 10 2022, 2:25 PM

Do you have commit access?

JojoR added a comment.Nov 10 2022, 5:36 PM

@craig.topper Thanks for your help :)

This revision was automatically updated to reflect the committed changes.