This is an archive of the discontinued LLVM Phabricator instance.

Differential D137464

[NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription()
ClosedPublic

Authored by aeubanks on Nov 4 2022, 2:03 PM.

Details

Reviewers
Michael137
Commits
rGec1bd2546d34: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription()

Diff Detail

Event Timeline

aeubanks created this revision.Nov 4 2022, 2:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 2:03 PM
aeubanks requested review of this revision.Nov 4 2022, 2:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 2:03 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
aeubanks added a reviewer: Michael137.Nov 4 2022, 2:03 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptNov 4 2022, 2:03 PM
Michael137 accepted this revision.Nov 4 2022, 2:11 PM
This revision is now accepted and ready to land.Nov 4 2022, 2:11 PM
Harbormaster completed remote builds in B196216: Diff 473334.Nov 4 2022, 2:14 PM
Closed by commit rGec1bd2546d34: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription() (authored by aeubanks). · Explain WhyNov 7 2022, 10:29 AM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGec1bd2546d34: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription().

Revision Contents

PathSize
lldb/
source/
Plugins/
TypeSystem/
Clang/
10 lines

Diff 473334

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 9,215 Lines • ▼ Show 20 Lines if (type) {
case clang::Type::Record: { case clang::Type::Record: {
GetCompleteType(type); GetCompleteType(type);
auto *record_type = llvm::cast<clang::RecordType>(qual_type.getTypePtr()); auto *record_type = llvm::cast<clang::RecordType>(qual_type.getTypePtr());
const clang::RecordDecl *record_decl = record_type->getDecl(); const clang::RecordDecl *record_decl = record_type->getDecl();
if (level == eDescriptionLevelVerbose) if (level == eDescriptionLevelVerbose)
record_decl->dump(llvm_ostrm); record_decl->dump(llvm_ostrm);
else { else {
if (auto *cxx_record_decl =
llvm::dyn_cast<clang::CXXRecordDecl>(record_decl))
cxx_record_decl->print(llvm_ostrm,
getASTContext().getPrintingPolicy(),
s->GetIndentLevel());
else
record_decl->print(llvm_ostrm, getASTContext().getPrintingPolicy(), record_decl->print(llvm_ostrm, getASTContext().getPrintingPolicy(),
s->GetIndentLevel()); s->GetIndentLevel());
} }
} break; } break;
default: { default: {
if (auto *tag_type = if (auto *tag_type =
llvm::dyn_cast<clang::TagType>(qual_type.getTypePtr())) { llvm::dyn_cast<clang::TagType>(qual_type.getTypePtr())) {
if (clang::TagDecl *tag_decl = tag_type->getDecl()) { if (clang::TagDecl *tag_decl = tag_type->getDecl()) {
if (level == eDescriptionLevelVerbose) if (level == eDescriptionLevelVerbose)
▲ Show 20 Lines • Show All 757 Lines • Show Last 20 Lines