See this bug for more information.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM. Maybe add a test for using the same literal twice (is that allowed?) like v_permlane16_b32 v5, v1, 0x12345678, 0x12345678.
Paths
| Differential D137332
[AMDGPU][MC][GFX10+] Enable literal operands with permlane16/permlanex16 ClosedPublic Authored by dp on Nov 3 2022, 5:10 AM.
Details
Diff Detail Event TimelineComment Actions LGTM. Maybe add a test for using the same literal twice (is that allowed?) like v_permlane16_b32 v5, v1, 0x12345678, 0x12345678. Comment Actions
Yes, it should be allowed. This revision is now accepted and ready to land.Nov 3 2022, 7:50 AM Closed by commit rG6e279f5bb663: [AMDGPU][MC][GFX10+] Enable literal operands with permlane16/permlanex16 (authored by dp). · Explain WhyNov 7 2022, 4:49 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 472902 llvm/lib/Target/AMDGPU/VOP3Instructions.td
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.permlane.ll
llvm/test/MC/AMDGPU/gfx10_asm_vop3.s
llvm/test/MC/AMDGPU/gfx11_asm_vop3.s
llvm/test/MC/Disassembler/AMDGPU/gfx10_vop3.txt
|