Page MenuHomePhabricator

[AMDGPU][MC][GFX10+] Enable literal operands with permlane16/permlanex16
ClosedPublic

Authored by dp on Nov 3 2022, 5:10 AM.

Diff Detail

Event Timeline

dp created this revision.Nov 3 2022, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 5:10 AM
dp requested review of this revision.Nov 3 2022, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2022, 5:10 AM
foad added a comment.Nov 3 2022, 7:16 AM

LGTM. Maybe add a test for using the same literal twice (is that allowed?) like v_permlane16_b32 v5, v1, 0x12345678, 0x12345678.

dp added a comment.Nov 3 2022, 7:42 AM

LGTM. Maybe add a test for using the same literal twice (is that allowed?)

Yes, it should be allowed.

dp updated this revision to Diff 472936.Nov 3 2022, 7:43 AM

Add tests with two literals.

Joe_Nash accepted this revision.Nov 3 2022, 7:50 AM

LGTM

This revision is now accepted and ready to land.Nov 3 2022, 7:50 AM