This is an archive of the discontinued LLVM Phabricator instance.

[mlir][arith][spirv] Remove duplicate test cases
ClosedPublic

Authored by kuhar on Nov 1 2022, 7:56 AM.

Diff Detail

Event Timeline

kuhar created this revision.Nov 1 2022, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2022, 7:56 AM
kuhar requested review of this revision.Nov 1 2022, 7:56 AM
antiagainst accepted this revision.Nov 4 2022, 9:36 AM

LGTM; just need to double check one of the test..

mlir/test/Conversion/ArithToSPIRV/arith-to-spirv.mlir
1297

We should keep this test. Looks it's introduced after duplication of existing ones.

This revision is now accepted and ready to land.Nov 4 2022, 9:36 AM
kuhar updated this revision to Diff 473307.Nov 4 2022, 12:08 PM
kuhar marked an inline comment as done.

Add an exidentally deleted 'vec1cmpf' test. Rebase.

This revision was landed with ongoing or failed builds.Nov 4 2022, 12:11 PM
This revision was automatically updated to reflect the committed changes.