Followup rG325a3083b5b24
Add SRL/SRA/xxx_EXTEND/AND support
Details
Diff Detail
Event Timeline
Sounds good. Should we be handling uxtw and sxtw type operands too? As in getExtendTypeForNode.
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
16915 | SIGN_EXTEND_INREG is usually lsl 48; ashr 48. Any extend can be difficult (especially if we expect the value to be used). Adding some extra 64bit tests would be useful too, for the different And cases for example. |
Thanks. From what I can tell this looks OK, and the performance should be better. LGTM
Perhaps change canbeExtend to isExtendOrShiftOperand, or something like it?