This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add a porting guide to the docs.
ClosedPublic

Authored by sivachandra on Oct 28 2022, 9:01 AM.

Diff Detail

Event Timeline

sivachandra created this revision.Oct 28 2022, 9:01 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 28 2022, 9:01 AM
sivachandra requested review of this revision.Oct 28 2022, 9:01 AM

Add a not about CI builders when contributing a new OS/architecture port.

michaelrj added inline comments.
libc/docs/porting.rst
91

important

jeffbailey added inline comments.Nov 1 2022, 10:33 PM
libc/docs/porting.rst
22

Is it worth a note about Fuchsia? It's mentioned occasionally, and might be worth one here that just notes that because they build it as part of their OS, they're choosing out-of-tree development.

31

its. "it's" is always an abbreviation for "it is"

31

s,the,,

40–41

This sentence is redundant.

104

I would be inclined to bump this to the top of the page. No matter how enthusiastic a person is to do the porting work, we simply don't want the patches unless we know there's a CI available to test it pretty much right away.

Engineering before coding =)

sivachandra marked 5 inline comments as done.

Address comments.

jeffbailey accepted this revision.Nov 2 2022, 7:18 AM
This revision is now accepted and ready to land.Nov 2 2022, 7:18 AM
This revision was automatically updated to reflect the committed changes.