Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People jeffbailey

jeffbailey (Jeff Bailey)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2014, 12:37 PM (499 w, 5 d)

Recent Activity
View All

May 31 2023

jeffbailey accepted D151809: [libc][docs] Update implementation status table for Date and Time Functions..
May 31 2023, 11:44 AM · Restricted Project, Restricted Project

May 25 2023

jeffbailey accepted D151489: [libc][doc] Update math function status page to show more targets..
May 25 2023, 2:09 PM · Restricted Project, Restricted Project

Apr 1 2023

jeffbailey added inline comments to D147350: [libc] Add two more recipes to do a cross build..
Apr 1 2023, 9:52 PM · Restricted Project, Restricted Project

Mar 31 2023

jeffbailey accepted D147350: [libc] Add two more recipes to do a cross build..

Comments within. Generally LGTM

Mar 31 2023, 12:43 PM · Restricted Project, Restricted Project

Mar 15 2023

jeffbailey accepted D146115: [libc][docs] Add a section about allocations and deallocations to the style doc..
Mar 15 2023, 6:52 PM · Restricted Project, Restricted Project

Mar 14 2023

jeffbailey accepted D146112: [libc][docs] Move the link to "Compiler Support" under "Status"..
Mar 14 2023, 11:12 PM · Restricted Project, Restricted Project
jeffbailey committed rG1b89aeb517f1: [libc] Add instructions for linux headers (authored by jeffbailey).
[libc] Add instructions for linux headers
Mar 14 2023, 8:02 PM · Restricted Project, Restricted Project
jeffbailey closed D146049: [libc] Add instructions for linux headers.
Mar 14 2023, 8:02 PM · Restricted Project, Restricted Project
jeffbailey requested review of D146049: [libc] Add instructions for linux headers.
Mar 14 2023, 7:54 AM · Restricted Project, Restricted Project

Mar 13 2023

jeffbailey committed rGea471e2aa8fe: [libc] Update cross-compilation instructions (authored by jeffbailey).
[libc] Update cross-compilation instructions
Mar 13 2023, 10:31 PM · Restricted Project, Restricted Project
jeffbailey closed D145878: [libc] Update cross-compilation instructions.
Mar 13 2023, 10:31 PM · Restricted Project, Restricted Project

Mar 12 2023

jeffbailey requested review of D145878: [libc] Update cross-compilation instructions.
Mar 12 2023, 8:51 AM · Restricted Project, Restricted Project

Mar 1 2023

jeffbailey committed rG81b39145bda7: [libc] Fix mismatch in exception decl (authored by jeffbailey).
[libc] Fix mismatch in exception decl
Mar 1 2023, 12:57 PM · Restricted Project, Restricted Project
jeffbailey closed D144803: [libc] Fix mismatch in exception decl.
Mar 1 2023, 12:57 PM · Restricted Project, Restricted Project

Feb 25 2023

jeffbailey added a reviewer for D144803: [libc] Fix mismatch in exception decl: michaelrj.
Feb 25 2023, 6:06 PM · Restricted Project, Restricted Project
jeffbailey requested review of D144803: [libc] Fix mismatch in exception decl.
Feb 25 2023, 6:05 PM · Restricted Project, Restricted Project

Feb 22 2023

jeffbailey committed rG8aec3b126b54: [libc] Introduce sys/socket.h (authored by jeffbailey).
[libc] Introduce sys/socket.h
Feb 22 2023, 11:11 PM · Restricted Project, Restricted Project
jeffbailey closed D144415: [libc] Introduce sys/socket.h.
Feb 22 2023, 11:11 PM · Restricted Project, Restricted Project
jeffbailey updated the diff for D144415: [libc] Introduce sys/socket.h.

Update comments per Siva's feedback.

Feb 22 2023, 10:44 PM · Restricted Project, Restricted Project

Feb 21 2023

jeffbailey committed rG9ad0ac8eb3d0: [libc] Add Month enum, refactor mktime_test (authored by jeffbailey).
[libc] Add Month enum, refactor mktime_test
Feb 21 2023, 9:25 AM · Restricted Project, Restricted Project
jeffbailey closed D144357: [libc] Add Month enum, refactor mktime_test.
Feb 21 2023, 9:24 AM · Restricted Project, Restricted Project

Feb 20 2023

jeffbailey updated the diff for D144415: [libc] Introduce sys/socket.h.

Add missing newline.

Feb 20 2023, 11:06 AM · Restricted Project, Restricted Project
jeffbailey added reviewers for D144415: [libc] Introduce sys/socket.h: sivachandra, rtenneti.
Feb 20 2023, 10:56 AM · Restricted Project, Restricted Project
jeffbailey requested review of D144415: [libc] Introduce sys/socket.h.
Feb 20 2023, 10:56 AM · Restricted Project, Restricted Project

Feb 19 2023

jeffbailey requested review of D144357: [libc] Add Month enum, refactor mktime_test.
Feb 19 2023, 7:59 PM · Restricted Project, Restricted Project

Feb 15 2023

jeffbailey accepted D143795: [libc] Implement htonl and htons.
Feb 15 2023, 7:08 PM · Restricted Project, Restricted Project

Jan 24 2023

jeffbailey accepted D142434: [libc][NFC] Replace "inline" keyword with "LIBC_INLINE"..
Jan 24 2023, 9:53 AM · Restricted Project, Restricted Project

Jan 5 2023

jeffbailey committed rG6e5c35819e31: [libc] Add documentation on hacking with vscode (authored by jeffbailey).
[libc] Add documentation on hacking with vscode
Jan 5 2023, 9:28 AM · Restricted Project, Restricted Project
jeffbailey closed D140826: [libc] Add documentation on hacking with vscode.
Jan 5 2023, 9:27 AM · Restricted Project, Restricted Project
jeffbailey accepted D141039: [libc] Make the sidebar colors have a higher constract in the white background..
Jan 5 2023, 9:18 AM · Restricted Project, Restricted Project
jeffbailey accepted D141037: [libc] Add document for a recipe to do a full standalone cross-build..
Jan 5 2023, 9:17 AM · Restricted Project, Restricted Project

Jan 1 2023

jeffbailey added a reviewer for D140826: [libc] Add documentation on hacking with vscode: sivachandra.
Jan 1 2023, 12:58 PM · Restricted Project, Restricted Project
jeffbailey requested review of D140826: [libc] Add documentation on hacking with vscode.
Jan 1 2023, 12:56 PM · Restricted Project, Restricted Project
jeffbailey committed rGbc09f1e5c384: [libc] [nfc] Fix heading underline. (authored by jeffbailey).
[libc] [nfc] Fix heading underline.
Jan 1 2023, 12:53 PM · Restricted Project, Restricted Project
jeffbailey closed D140825: [libc] [nfc] Fix heading underline..
Jan 1 2023, 12:53 PM · Restricted Project, Restricted Project
jeffbailey requested review of D140825: [libc] [nfc] Fix heading underline..
Jan 1 2023, 12:45 PM · Restricted Project, Restricted Project

Dec 22 2022

jeffbailey added a comment to D140521: [libc] Introduces localtime to LLVM libc, based on C99/C2X/Single Unix Sp..

I don't think landing this without it having any way of displaying a different time than gmtime is a good idea. Happily, I started working on the TZ patch again, so this might be good to land early in the year.

Dec 22 2022, 8:51 AM · Restricted Project, Restricted Project

Nov 11 2022

jeffbailey updated subscribers of D137881: [libc] Implement gettimeofday.

Did you intend to land this without review?

Nov 11 2022, 11:13 PM · Restricted Project, Restricted Project

Nov 7 2022

jeffbailey added a comment to D137371: [libc] Fix matching on struct tm.

Ate these test changes enough to catch this? It seems a bit magical with the numbers. Should there be an explicit test that tests matching more than one field?

Nov 7 2022, 7:07 AM · Restricted Project, Restricted Project

Nov 3 2022

jeffbailey accepted D137090: [libc] Add example programs and their CMake build and instructions..

I'm marking this as accepted - only the language annotation on the code blocks remains, but I think you'll have to just try something and see how the github MD interpreter copes with it. Thanks!

Nov 3 2022, 5:26 PM · Restricted Project, Restricted Project

Nov 2 2022

jeffbailey accepted D136960: [libc] Add a porting guide to the docs..
Nov 2 2022, 7:18 AM · Restricted Project, Restricted Project
jeffbailey accepted D137229: [libc] Add links to libc Discourse and to the libc Discord channel..
Nov 2 2022, 7:14 AM · Restricted Project, Restricted Project

Nov 1 2022

jeffbailey added a comment to D137090: [libc] Add example programs and their CMake build and instructions..

I'm not sure that the repeated description of sysroot is necessary, but I'm not sure that it's not. I always worry about duplicated info.

Nov 1 2022, 11:08 PM · Restricted Project, Restricted Project
jeffbailey accepted D137061: [libc] Add a doc about the libc fullbuild mode..
Nov 1 2022, 10:56 PM · Restricted Project, Restricted Project
jeffbailey added inline comments to D136960: [libc] Add a porting guide to the docs..
Nov 1 2022, 10:33 PM · Restricted Project, Restricted Project
jeffbailey accepted D136961: [libc] Add a contributing guide to the docs..
Nov 1 2022, 10:28 PM · Restricted Project, Restricted Project
jeffbailey added inline comments to D137061: [libc] Add a doc about the libc fullbuild mode..
Nov 1 2022, 10:27 PM · Restricted Project, Restricted Project

Oct 26 2022

jeffbailey accepted D136810: [libc] Add a doc about the libc overlay mode..

Reviewing from my phone, but LGTM

Oct 26 2022, 8:38 PM · Restricted Project, Restricted Project

Oct 24 2022

jeffbailey accepted D136631: [libc] Add implementation of difftime function..
Oct 24 2022, 12:35 PM · Restricted Project, Restricted Project

Oct 23 2022

jeffbailey updated subscribers of D136562: [libc] Add implementation of difftime function..

Can you please update the status doc at
https://libc.llvm.org/date_and_time.html ?

Oct 23 2022, 1:04 PM · Restricted Project, Restricted Project

Oct 17 2022

jeffbailey committed rG7caae244730e: [libc]Identify which processors are completed for Math (authored by jeffbailey).
[libc]Identify which processors are completed for Math
Oct 17 2022, 8:13 PM · Restricted Project, Restricted Project
jeffbailey closed D136020: [libc]Identify which processors are completed for Math.
Oct 17 2022, 8:12 PM · Restricted Project, Restricted Project

Oct 15 2022

jeffbailey added a reviewer for D136020: [libc]Identify which processors are completed for Math: lntue.
Oct 15 2022, 9:20 AM · Restricted Project, Restricted Project
jeffbailey requested review of D136020: [libc]Identify which processors are completed for Math.
Oct 15 2022, 9:19 AM · Restricted Project, Restricted Project
jeffbailey committed rG998d1ebb2754: [libc][cleanup] Docs clean up (authored by jeffbailey).
[libc][cleanup] Docs clean up
Oct 15 2022, 8:30 AM · Restricted Project, Restricted Project
jeffbailey closed D136016: [libc][cleanup] Docs clean up.
Oct 15 2022, 8:30 AM · Restricted Project, Restricted Project
jeffbailey added a reviewer for D136016: [libc][cleanup] Docs clean up: sivachandra.
Oct 15 2022, 5:35 AM · Restricted Project, Restricted Project
jeffbailey requested review of D136016: [libc][cleanup] Docs clean up.
Oct 15 2022, 5:34 AM · Restricted Project, Restricted Project

Oct 7 2022

jeffbailey committed rGaa8ab5b21323: [libc] Document which date funcs are needed/done (authored by jeffbailey).
[libc] Document which date funcs are needed/done
Oct 7 2022, 5:06 PM · Restricted Project, Restricted Project
jeffbailey closed D135501: [libc] Document which date funcs are needed/done.
Oct 7 2022, 5:06 PM · Restricted Project, Restricted Project
jeffbailey added a reviewer for D135501: [libc] Document which date funcs are needed/done: rtenneti.
Oct 7 2022, 5:00 PM · Restricted Project, Restricted Project
jeffbailey requested review of D135501: [libc] Document which date funcs are needed/done.
Oct 7 2022, 4:59 PM · Restricted Project, Restricted Project

Sep 23 2022

jeffbailey committed rG8f1e362ee927: Implement nanosleep per https://pubs.opengroup. (authored by rtenneti).
Implement nanosleep per https://pubs.opengroup.
Sep 23 2022, 5:14 PM · Restricted Project, Restricted Project
jeffbailey closed D134095: Implement nanosleep per https://pubs.opengroup.org/onlinepubs/009695399/basedefs/time.h.html.
Sep 23 2022, 5:14 PM · Restricted Project, Restricted Project
jeffbailey accepted D134095: Implement nanosleep per https://pubs.opengroup.org/onlinepubs/009695399/basedefs/time.h.html.
Sep 23 2022, 4:40 PM · Restricted Project, Restricted Project

Sep 20 2022

jeffbailey committed rGfaeb237bac7a: [libc] Fix TWS issues in .td files (authored by jeffbailey).
[libc] Fix TWS issues in .td files
Sep 20 2022, 7:26 AM · Restricted Project, Restricted Project
jeffbailey closed D134256: [libc] Fix TWS issues in .td files.
Sep 20 2022, 7:25 AM · Restricted Project, Restricted Project
jeffbailey committed rG6007a4a619a9: [libc] Remove unneeded extra include (authored by jeffbailey).
[libc] Remove unneeded extra include
Sep 20 2022, 7:25 AM · Restricted Project, Restricted Project
jeffbailey closed D134255: [libc] Remove unneeded extra include.
Sep 20 2022, 7:24 AM · Restricted Project, Restricted Project

Sep 19 2022

jeffbailey added a reviewer for D134256: [libc] Fix TWS issues in .td files: sivachandra.
Sep 19 2022, 11:04 PM · Restricted Project, Restricted Project
jeffbailey requested review of D134256: [libc] Fix TWS issues in .td files.
Sep 19 2022, 11:03 PM · Restricted Project, Restricted Project
jeffbailey added a reviewer for D134255: [libc] Remove unneeded extra include: rtenneti.
Sep 19 2022, 11:01 PM · Restricted Project, Restricted Project
jeffbailey requested review of D134255: [libc] Remove unneeded extra include.
Sep 19 2022, 11:00 PM · Restricted Project, Restricted Project

Sep 2 2022

jeffbailey committed rG0dcbe0e1df40: [libc] Add Buildbot to External Links (authored by jeffbailey).
[libc] Add Buildbot to External Links
Sep 2 2022, 7:11 AM · Restricted Project, Restricted Project
jeffbailey closed D133186: [libc] Add Buildbot to External Links.
Sep 2 2022, 7:11 AM · Restricted Project, Restricted Project

Sep 1 2022

jeffbailey retitled D133186: [libc] Add Buildbot to External Links from Add Buildbot to External Links to [libc] Add Buildbot to External Links.
Sep 1 2022, 11:49 PM · Restricted Project, Restricted Project
jeffbailey updated the diff for D133186: [libc] Add Buildbot to External Links.

Fix topic sentence.

Sep 1 2022, 11:48 PM · Restricted Project, Restricted Project
jeffbailey added a reviewer for D133186: [libc] Add Buildbot to External Links: sivachandra.
Sep 1 2022, 11:46 PM · Restricted Project, Restricted Project
jeffbailey requested review of D133186: [libc] Add Buildbot to External Links.
Sep 1 2022, 11:45 PM · Restricted Project, Restricted Project

Aug 19 2022

jeffbailey accepted D132212: [libc] Install startup files with the install-libc target..
Aug 19 2022, 9:25 AM · Restricted Project, Restricted Project

Aug 17 2022

jeffbailey accepted D132015: [libc] Add a target to install libc in the full build mode..
Aug 17 2022, 7:04 AM · Restricted Project, Restricted Project

Aug 8 2022

jeffbailey committed rG7889c41938d2: [libc] Website fixes (sidebar and mobile) (authored by jeffbailey).
[libc] Website fixes (sidebar and mobile)
Aug 8 2022, 11:38 AM · Restricted Project, Restricted Project
jeffbailey closed D131369: [libc] Website fixes (sidebar and mobile).
Aug 8 2022, 11:38 AM · Restricted Project, Restricted Project

Aug 7 2022

jeffbailey added a reviewer for D131369: [libc] Website fixes (sidebar and mobile): michaelrj.
Aug 7 2022, 2:01 PM · Restricted Project, Restricted Project
jeffbailey requested review of D131369: [libc] Website fixes (sidebar and mobile).
Aug 7 2022, 2:00 PM · Restricted Project, Restricted Project

Aug 5 2022

jeffbailey committed rGf493b21e1695: [libc] Update look and feel of libc.llvm.org (authored by jeffbailey).
[libc] Update look and feel of libc.llvm.org
Aug 5 2022, 11:19 AM · Restricted Project, Restricted Project
jeffbailey closed D131242: [libc] Update look and feel of libc.llvm.org.
Aug 5 2022, 11:18 AM · Restricted Project, Restricted Project

Aug 4 2022

jeffbailey added a reviewer for D131242: [libc] Update look and feel of libc.llvm.org: sivachandra.
Aug 4 2022, 11:26 PM · Restricted Project, Restricted Project
jeffbailey requested review of D131242: [libc] Update look and feel of libc.llvm.org.
Aug 4 2022, 11:25 PM · Restricted Project, Restricted Project
jeffbailey committed rG3b631e47fe4c: [libc] Trivial implementation of std::optional (authored by jeffbailey).
[libc] Trivial implementation of std::optional
Aug 4 2022, 7:52 PM · Restricted Project, Restricted Project
jeffbailey closed D129920: [libc] Trivial implementation of std::optional.
Aug 4 2022, 7:52 PM · Restricted Project, Restricted Project

Aug 3 2022

jeffbailey added a comment to D129920: [libc] Trivial implementation of std::optional.

I think this closes out the comments. I'll leave this another day before submitting. Thanks all!

Aug 3 2022, 10:25 PM · Restricted Project, Restricted Project
jeffbailey accepted D131133: [libc] Adjust aarch64 startup code to reliably sniff out the start args..

We don't have span, or I'd be tempted to suggest using it for that code.

Aug 3 2022, 10:21 PM · Restricted Project, Restricted Project

Jul 30 2022

jeffbailey added inline comments to D129920: [libc] Trivial implementation of std::optional.
Jul 30 2022, 12:55 PM · Restricted Project, Restricted Project
jeffbailey updated the diff for D129920: [libc] Trivial implementation of std::optional.

Oops, I noticed that I didn't have clang-format installed. This
diff fixes one formatting error.

Jul 30 2022, 12:51 PM · Restricted Project, Restricted Project
jeffbailey updated the diff for D129920: [libc] Trivial implementation of std::optional.

Added two tests to test code review comment that noticed that an unset
optional would become set on assignment. Then fixed the code for
that situation by factoring our storage into a consistent object.

Jul 30 2022, 12:27 PM · Restricted Project, Restricted Project

Jul 26 2022

jeffbailey added inline comments to D130405: Implement TZ Variable Parsing Function..
Jul 26 2022, 7:27 PM · Restricted Project, Restricted Project
jeffbailey added a comment to D130405: Implement TZ Variable Parsing Function..

Took a quick review while I had a break this morning.

Jul 26 2022, 10:59 AM · Restricted Project, Restricted Project

Jul 22 2022

jeffbailey added a comment to D130405: Implement TZ Variable Parsing Function..

One thing: the test builds should fail with this as this patch depends on my optional.h patch that I'm still reworking. (I'm trying to learn enough about c++ traits to implement the ones I need). However, Raman and I work together on Fridays on our patches and we wanted to get this up for review since it's a large one.

Jul 22 2022, 7:22 PM · Restricted Project, Restricted Project

Jul 21 2022

jeffbailey added inline comments to D129920: [libc] Trivial implementation of std::optional.
Jul 21 2022, 7:51 AM · Restricted Project, Restricted Project