Adds FP CCs opcodes/selection logic, including src mods selection
Depends on D136591, D136448
Resolves #58326 (https://github.com/llvm/llvm-project/issues/58326)
Paths
| Differential D136592
[AMDGPU][GISel] Select llvm.amdgcn.fcmp intrinsics ClosedPublic Authored by Pierre-vh on Oct 24 2022, 4:37 AM.
Details
Summary Adds FP CCs opcodes/selection logic, including src mods selection Depends on D136591, D136448
Diff Detail
Event TimelineComment Actions
Isn't this already done at the IR level in GCNTTIImpl::instCombineIntrinsic?
This revision is now accepted and ready to land.Oct 28 2022, 6:32 AM This revision is now accepted and ready to land.Nov 2 2022, 8:28 AM This revision is now accepted and ready to land.Nov 22 2022, 6:11 AM Closed by commit rG9e7febb4f73c: [AMDGPU][GISel] Select llvm.amdgcn.fcmp intrinsics (authored by Pierre-vh). · Explain WhyNov 22 2022, 6:19 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 477167 llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgcn.fcmp.constants.w32.mir
llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgcn.fcmp.constants.w64.mir
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.fcmp.ll
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.fcmp.w32.ll
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.fcmp.w64.ll
|
Note: I used the ops used in VOPCInstructions.td:1071 - not sure if it's correct or if we want different codegen for these intrinsics.