This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] NFC. Clean up check prefixes in fcmp test
ClosedPublic

Authored by Joe_Nash on Apr 10 2023, 11:46 AM.

Details

Summary

Fix the test introduced in D136592 which appeared to have a few check lines
containing an un-checked prefix "GISEL-GFX".
Also canonicalize the other prefixes to minimize churn if SDag and GISel
diverge.

Diff Detail

Event Timeline

Joe_Nash created this revision.Apr 10 2023, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 11:46 AM
Joe_Nash requested review of this revision.Apr 10 2023, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 11:46 AM
arsenm accepted this revision.Apr 10 2023, 1:59 PM
arsenm added inline comments.
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.fcmp.w64.ll
4

I think the prevailing convention would be -GISEL suffix, not prefix

This revision is now accepted and ready to land.Apr 10 2023, 1:59 PM
Joe_Nash marked an inline comment as done.Apr 11 2023, 6:58 AM
This revision was automatically updated to reflect the committed changes.