This is an archive of the discontinued LLVM Phabricator instance.

[mlir:LLVM] Add attribute/op definitions for debug info
ClosedPublic

Authored by rriddle on Oct 22 2022, 2:15 PM.

Details

Summary

This adds a subset of the necessary metadata for defining
debug info in the LLVM dialect. It doesn't import everything,
but just enough to start actually generating LLVM debug info
the expected way. Export/Import to LLVMIR will be added in a
followup.

Diff Detail

Event Timeline

rriddle created this revision.Oct 22 2022, 2:15 PM
Herald added a project: Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Oct 22 2022, 2:15 PM
Mogball accepted this revision.Oct 23 2022, 12:02 AM
Mogball added inline comments.
mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
159

Why are some of these StringRefParameter vs StringAttr?

mlir/include/mlir/Dialect/LLVMIR/LLVMEnums.td
218

nit: can you do one per line? below as well

mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
103

cast_if_present?

This revision is now accepted and ready to land.Oct 23 2022, 12:02 AM
This revision was landed with ongoing or failed builds.Oct 24 2022, 12:00 AM
This revision was automatically updated to reflect the committed changes.
rriddle marked 3 inline comments as done.