This is an archive of the discontinued LLVM Phabricator instance.

Differential D136519

bazel fix for TranslateLib
ClosedPublic

Authored by aartbik on Oct 21 2022, 7:51 PM.

Details

Reviewers
bixia
cota
Mogball
Commits
rG21ef1cac1372: bazel fix for TranslateLib

Diff Detail

Event Timeline

aartbik created this revision.Oct 21 2022, 7:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2022, 7:51 PM
Herald added subscribers: zero9178, bzcheeseman, sdasgup3 and 19 others. · View Herald Transcript
aartbik requested review of this revision.Oct 21 2022, 7:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2022, 7:51 PM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
aartbik added reviewers: bixia, cota, Mogball.Oct 21 2022, 7:54 PM
Harbormaster completed remote builds in B193705: Diff 469848.Oct 21 2022, 7:59 PM
cota accepted this revision.Oct 21 2022, 8:05 PM
This revision is now accepted and ready to land.Oct 21 2022, 8:05 PM
cota added a comment.EditedOct 21 2022, 8:07 PM

We should later also fix the Utilities typo in the file name.

Closed by commit rG21ef1cac1372: bazel fix for TranslateLib (authored by aartbik). · Explain WhyOct 21 2022, 8:08 PM
This revision was automatically updated to reflect the committed changes.
aartbik added a commit: rG21ef1cac1372: bazel fix for TranslateLib.
cota added a comment.Oct 27 2022, 2:17 PM
In D136519#3876652, @cota wrote:

We should later also fix the Utilities typo in the file name.

https://reviews.llvm.org/D136887

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
6 lines

Diff 469850

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

Show First 20 Lines • Show All 6,188 Lines • ▼ Show 20 Lines deps = [
":Support", ":Support",
":ViewLikeInterface", ":ViewLikeInterface",
"//llvm:Support", "//llvm:Support",
], ],
) )
cc_library( cc_library(
name = "TranslateLib", name = "TranslateLib",
srcs = glob(["lib/Tools/mlir-translate/*.cpp"]), srcs = glob([
"lib/Tools/mlir-translate/*.cpp",
]) + [
"include/mlir/Tools/ParseUtilties.h",
],
hdrs = glob(["include/mlir/Tools/mlir-translate/*.h"]), hdrs = glob(["include/mlir/Tools/mlir-translate/*.h"]),
includes = ["include"], includes = ["include"],
deps = [ deps = [
":IR", ":IR",
":Parser", ":Parser",
":Support", ":Support",
"//llvm:Support", "//llvm:Support",
], ],
▲ Show 20 Lines • Show All 3,867 Lines • Show Last 20 Lines