This is an archive of the discontinued LLVM Phabricator instance.

Disable bf16 tests on AArch64
ClosedPublic

Authored by awarzynski on Oct 19 2022, 10:50 AM.

Details

Summary

This patch disables 2 bf16 tests that are currently not supported on
AArch64. I've triaged these failures and opened [1] to track this. I
don't have a simple reproducer for dense_output_bf16.mlir, but it's
rather clear that both tests fail due to missing support for bfloat
operations in the AArch64 backend.

I'm not sure what the path forward to enable these tests on AArch64
should be. I think that there are two options:

  • AArch64 backened gains capability to legalize these nodes containing bfloat operands, or
  • MLIR (similarly to Clang) is taught not to emit such nodes in the first place.

[1] https://github.com/llvm/llvm-project/issues/58465

Diff Detail

Event Timeline

awarzynski created this revision.Oct 19 2022, 10:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
awarzynski requested review of this revision.Oct 19 2022, 10:50 AM
bkramer accepted this revision.Oct 19 2022, 11:52 AM
This revision is now accepted and ready to land.Oct 19 2022, 11:52 AM
aartbik accepted this revision.Oct 19 2022, 1:25 PM
This revision was automatically updated to reflect the committed changes.