This is an archive of the discontinued LLVM Phabricator instance.

[clang][Sema][NFC] Remove redundant isTypeValid
ClosedPublic

Authored by troyj on Oct 18 2022, 11:00 AM.

Details

Summary

These isTypeValid calls are redundant because the isDerivedFrom call performs the same checks.

Diff Detail

Event Timeline

troyj created this revision.Oct 18 2022, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 11:00 AM
troyj requested review of this revision.Oct 18 2022, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 11:00 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
bruno accepted this revision.Oct 27 2022, 10:05 AM

Nice cleanup, before landing please capitalize remove in the title and also add [NFC] to it!

This revision is now accepted and ready to land.Oct 27 2022, 10:05 AM
troyj retitled this revision from [clang][Sema] remove redundant isTypeValid to [clang][Sema][NFC] Remove redundant isTypeValid.Oct 27 2022, 12:25 PM
This revision was landed with ongoing or failed builds.Oct 27 2022, 12:48 PM
This revision was automatically updated to reflect the committed changes.