Page MenuHomePhabricator

troyj (Troy Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 22 2018, 6:51 AM (51 w, 4 d)

Recent Activity

Sat, Aug 17

troyj committed rG30cde4e2e6a5: [circular_raw_ostream] Delegate is_displayed to contained stream (authored by troyj).
[circular_raw_ostream] Delegate is_displayed to contained stream
Sat, Aug 17, 7:24 AM
troyj committed rL369188: [circular_raw_ostream] Delegate is_displayed to contained stream.
[circular_raw_ostream] Delegate is_displayed to contained stream
Sat, Aug 17, 7:24 AM
troyj closed D66026: Make circular_raw_ostream delegate is_displayed to contained stream.
Sat, Aug 17, 7:24 AM · Restricted Project

Fri, Aug 16

troyj committed rGc0d70bca0f9f: [X86] Support -mlong-double-80 (authored by troyj).
[X86] Support -mlong-double-80
Fri, Aug 16, 9:25 PM
troyj committed rL369183: [X86] Support -mlong-double-80.
[X86] Support -mlong-double-80
Fri, Aug 16, 9:24 PM
troyj committed rG0dd9494d4701: Revert "[X86] Support -mlong-double-80" (authored by troyj).
Revert "[X86] Support -mlong-double-80"
Fri, Aug 16, 4:22 PM
troyj added a reverting change for rG250aafa2c4a1: [X86] Support -mlong-double-80: rG0dd9494d4701: Revert "[X86] Support -mlong-double-80".
Fri, Aug 16, 4:22 PM
troyj committed rL369170: Revert "[X86] Support -mlong-double-80".
Revert "[X86] Support -mlong-double-80"
Fri, Aug 16, 4:22 PM
troyj added a comment to D66055: [X86] Support -mlong-double-80.

I've reverted temporarily. I see the error in the mlong-double-128.c file, just by looking at the diff above (the target checked in the ERR2 line is wrong after I changed the RUN line above), but I don't understand why the mlong-double-64.c test broke.

Fri, Aug 16, 4:22 PM · Restricted Project
troyj added a comment to D66055: [X86] Support -mlong-double-80.

I believe this patch is causing 2 test failures on our x64 clang bots

Fri, Aug 16, 4:13 PM · Restricted Project
troyj committed rG250aafa2c4a1: [X86] Support -mlong-double-80 (authored by troyj).
[X86] Support -mlong-double-80
Fri, Aug 16, 2:02 PM
troyj committed rL369152: [X86] Support -mlong-double-80.
[X86] Support -mlong-double-80
Fri, Aug 16, 2:02 PM
troyj closed D66055: [X86] Support -mlong-double-80.
Fri, Aug 16, 2:02 PM · Restricted Project
troyj committed rG856608c30a8b: [Test Commit] Fix typo in diagtool.rst (authored by troyj).
[Test Commit] Fix typo in diagtool.rst
Fri, Aug 16, 1:29 PM
troyj committed rL369148: [Test Commit] Fix typo in diagtool.rst.
[Test Commit] Fix typo in diagtool.rst
Fri, Aug 16, 1:26 PM
troyj added a comment to D66055: [X86] Support -mlong-double-80.

@MaskRay - I have commit access now, so I'm just waiting on your approval that the patch is fine.

Fri, Aug 16, 6:24 AM · Restricted Project

Thu, Aug 15

troyj added a comment to D66055: [X86] Support -mlong-double-80.
I believe -mlong-double-80 is also rejected on other powerpc targets (fp80 is a x86 specific thing), so we can use a generic ELF platform.
Thu, Aug 15, 6:48 PM · Restricted Project
troyj updated the diff for D66055: [X86] Support -mlong-double-80.

Changed target for test.

Thu, Aug 15, 1:31 PM · Restricted Project
troyj added a comment to D66055: [X86] Support -mlong-double-80.

Do you need me to change the test and commit for you? :)

Thu, Aug 15, 12:50 PM · Restricted Project

Mon, Aug 12

troyj updated the diff for D66055: [X86] Support -mlong-double-80.

@MaskRay -- is this what you meant?

Mon, Aug 12, 11:06 AM · Restricted Project
troyj retitled D66055: [X86] Support -mlong-double-80 from [X86][PowerPC] Support -mlong-double-80 to [X86] Support -mlong-double-80.
Mon, Aug 12, 9:49 AM · Restricted Project
troyj added a comment to D66055: [X86] Support -mlong-double-80.

LGTM. As @MaskRay says, this shouldn't affect PowerPC, so you can remove the '[PowerPC]' from the title.

Mon, Aug 12, 9:49 AM · Restricted Project
troyj updated the diff for D66055: [X86] Support -mlong-double-80.

OK, I removed the other RUN line and the comment. I disagree with you about the comment, but I'm not going to hold up the patch for it -- I can keep it locally.

Mon, Aug 12, 8:53 AM · Restricted Project

Sat, Aug 10

troyj updated the diff for D66055: [X86] Support -mlong-double-80.

OK, I moved it to a driver test. I agree that's more appropriate.

Sat, Aug 10, 9:48 AM · Restricted Project
troyj created D66055: [X86] Support -mlong-double-80.
Sat, Aug 10, 7:42 AM · Restricted Project

Fri, Aug 9

troyj created D66026: Make circular_raw_ostream delegate is_displayed to contained stream.
Fri, Aug 9, 1:17 PM · Restricted Project

Jul 18 2019

troyj added a comment to D64067: [X86][PPC] Support -mlong-double-64.

Hi, we just inherited this commit at Cray when we did our latest upstream merge and there are a few problems with it that I'd like to point out. Sorry that I was not part of the initial discussion here, but I didn't know that this work was being done and I had already done it for x86 in our downstream compiler a while ago.

Jul 18 2019, 12:43 PM · Restricted Project, Restricted Project

Apr 1 2019

troyj added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

Could you simply rebase the patch, or acknowledge the new LLVM license, as your patch was written prior to the license change.

Apr 1 2019, 11:26 AM · Restricted Project, Restricted Project

Mar 26 2019

troyj added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

I do not have commit access. I probably should request it at some point, but I'm fine with someone else merging this for me.

Mar 26 2019, 10:08 AM · Restricted Project, Restricted Project

Mar 22 2019

Herald added projects to D53832: Make instrprof-set-dir-mode test tolerant of group ID: Restricted Project, Restricted Project.

This revision is now accepted and ready to land.Dec 3 2018, 12:55 PM

Mar 22 2019, 12:08 PM · Restricted Project, Restricted Project

Nov 13 2018

troyj added a comment to D54489: Implement -frecord-command-line (-frecord-gcc-switches).

I realize that you're probably striving for option compatibility with gcc, but continuing to name it -frecord-gcc-switches when it actually records Clang switches seems weird to me. It almost sounds like something that would dump gcc equivalents of all Clang options, or maybe let you know which Clang options you've used that match gcc options. Either way, by the name -- if you aren't familiar with the gcc option -- it doesn't read like it records Clang options.

Nov 13 2018, 12:39 PM

Oct 29 2018

troyj created D53832: Make instrprof-set-dir-mode test tolerant of group ID.
Oct 29 2018, 1:56 PM · Restricted Project, Restricted Project

Aug 27 2018

troyj added a comment to D9377: llvm.noalias - don't block EarlyCSE.

LGTM too.

Aug 27 2018, 8:43 AM

Aug 22 2018

troyj added a comment to D9376: llvm.noalias - handling of dead intrinsics.

This is marked Accepted and is first in the sequence in D9375. Is there some reason this isn't merged yet? LGTM too.

Aug 22 2018, 9:44 AM
Herald updated subscribers of D9401: llvm.noalias - The AA implementaton.
Aug 22 2018, 9:30 AM
Herald updated subscribers of D9386: llvm.noalias - CaptureTracking needs to look through them.
Aug 22 2018, 9:30 AM
Herald updated subscribers of D9398: llvm.noalias - GetUnderlyingObjects to optionally collect noalias calls.
Aug 22 2018, 9:30 AM
Herald updated subscribers of D9382: llvm.noalias - don't prevent loop vectorization.
Aug 22 2018, 9:30 AM
Herald updated subscribers of D9378: llvm.noalias - Add IRBuilder support.
Aug 22 2018, 9:30 AM
Herald updated subscribers of D9379: llvm.noalias - don't interfere with llvm.assume.
Aug 22 2018, 9:30 AM
Herald updated subscribers of D9376: llvm.noalias - handling of dead intrinsics.
Aug 22 2018, 9:30 AM
Herald updated subscribers of D9377: llvm.noalias - don't block EarlyCSE.
Aug 22 2018, 9:30 AM
troyj added a comment to D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers.

Hi, I got here via llvm-dev => D9375 => D9403 (this) and have read through everything. I see that this patch has been stalled for about a year and I would like to know its status. Is it waiting on a resolution in LLVM for this problem that Jeroen mentioned on llvm-dev?

Aug 22 2018, 7:28 AM
Herald added a reviewer for D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers: javed.absar.
Aug 22 2018, 7:06 AM