This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Factoring out SparseTensorEnums library
ClosedPublic

Authored by wrengr on Oct 14 2022, 5:17 PM.

Details

Summary

This differential splits the SparseTensorEnums library out from the SparseTensorRuntime library. The actual moving of files will be handled in the next differential.

Depends On D135996

Diff Detail

Event Timeline

wrengr created this revision.Oct 14 2022, 5:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2022, 5:17 PM
wrengr requested review of this revision.Oct 14 2022, 5:17 PM
wrengr updated this revision to Diff 467984.Oct 14 2022, 5:46 PM

git-clang-format

wrengr updated this revision to Diff 468313.Oct 17 2022, 2:06 PM

Got CMake to work on Linux.

aartbik accepted this revision.Oct 17 2022, 5:43 PM
This revision is now accepted and ready to land.Oct 17 2022, 5:43 PM
wrengr updated this revision to Diff 468382.Oct 17 2022, 6:14 PM

Removing the dependency on mlir_float16_utils, so that only users of the MLIR_SPARSETENSOR_FOREVERY_V macro need to pull that dependency in. (See the discussion at https://reviews.llvm.org/D136005#inline-1312119)

wrengr updated this revision to Diff 468658.Oct 18 2022, 12:18 PM

re-rebase

This revision was automatically updated to reflect the committed changes.

This is breaking the mlir-s390x-linux builder (https://lab.llvm.org/buildbot/#/builders/199/builds/11463):

CMake Error at /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt:12 (add_library):
  add_library INTERFACE library requires no source arguments.

I understand this CMake feature has been added in version 3.19, while the builder is still running 3.16 (the default in Ubuntu 20.04). Is a more recent cmake version now a prereq for mlir?

LLVM requires 3.13.4 or greater https://llvm.org/docs/GettingStarted.html#software, I don't know if MLIR has some exception for this.

We (Linaro) are also seeing this failure https://lab.llvm.org/buildbot/#/builders/65/builds/7068. Our flang bots happen to be running 3.24.something, so they are still working.

Hi @uweigand and @DavidSpickett,

Apologies for the breakage. My local version of cmake and the version the phabricator buildbot is using are new enough that they didn't catch this until after I landed the [D136002, D136005, D136123] chain of commits. I'm currently working on a fix in D136217, so please comment there to let me know if that fixes things on your setups.