[mlir][llvm] Use tablegen to import shufflevector from LLVM IR.
ClosedPublic
Actions

Authored by gysit on Oct 13 2022, 8:12 AM.

Details

Reviewers

ftynse
nicolasvasilache
dcaballe

Commits

rGea9cae03d780: [mlir][llvm] Use tablegen to import shufflevector from LLVM IR.

Summary

The revision imports the shuffle vector operation using
tablegen generated builders. Additionally, it moves its test to
the instructions.ll test file.

Depends on D135874

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

gysit created this revision.Oct 13 2022, 8:12 AM

Herald added a reviewer: ftynse. · View Herald TranscriptOct 13 2022, 8:12 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: zero9178, bzcheeseman, awarzynski and 20 others. · View Herald Transcript

gysit requested review of this revision.Oct 13 2022, 8:12 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptOct 13 2022, 8:12 AM

Herald added a reviewer: dcaballe. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

ftynse added inline comments.Oct 13 2022, 8:25 AM

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
925	Shouldn't this be `$mask`?

Harbormaster completed remote builds in B191967: Diff 467476.Oct 13 2022, 8:27 AM

gysit added inline comments.Oct 13 2022, 9:12 AM

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
925	The shufflevector instruction has only two operands and the mask seems to be stored internally in the shufflevector instruction class. Apparently, the way to access this kind of attributes-like data is to cast the operation to its type and then use the getters: auto *svInst = cast<llvm::ShuffleVectorInst>(inst); svInst->getShuffleMask() Maybe I am missing something here? I use the same mechanism to access the position of the insertvalue / extractvalue operations.